Use title case for the clipboard button
ClosedPublic

Authored by ngraham on Aug 25 2018, 4:51 PM.

Details

Summary

Use Title Case for the Copy to Clipboard button. In this case, it means making the word "to" lowercase.

Test Plan

Compile, deploy, open Spectacle, look at button title and docbook

Diff Detail

Repository
R166 Spectacle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Aug 25 2018, 4:51 PM
Restricted Application added a project: Documentation. · View Herald TranscriptAug 25 2018, 4:51 PM
Restricted Application added a subscriber: kde-doc-english. · View Herald Transcript
ngraham requested review of this revision.Aug 25 2018, 4:51 PM

Question for the localization folks: can I change this string in the stable branch? It's just a capitalization change to one letter. Is the policy "no string changes on the stable branch no matter what", or is there some flexibility there?

Question for the localization folks: can I change this string in the stable branch? It's just a capitalization change to one letter. Is the policy "no string changes on the stable branch no matter what", or is there some flexibility there?

It is possible to ask and if nobody objects for a few days commit to the stable branch.

No objections from Ukrainian team.

pino added a subscriber: pino.Aug 25 2018, 5:26 PM

Question for the localization folks: can I change this string in the stable branch?

There is the string freeze in stable branches.

It's just a capitalization change to one letter.

IMHO breaking the string freeze and forcing translators to edit a string for a very minor style change is not a good idea. This kind of i18n style fixes is usually done in master branches only. Others may think differently though.

In D15083#315441, @pino wrote:

Question for the localization folks: can I change this string in the stable branch?

There is the string freeze in stable branches.

So I guess that's my question: is the freeze a total freeze, or does changing capitalization not count? If changing capitalization violates the string freeze, I'm more than happy to re-base this on master instead of the stable branch.

pino added a comment.Aug 25 2018, 5:33 PM
In D15083#315441, @pino wrote:

Question for the localization folks: can I change this string in the stable branch?

There is the string freeze in stable branches.

So I guess that's my question: is the freeze a total freeze, or does changing capitalization not count?

The freeze is usually "lifted" in case a fix really needs to also change strings/messages, because that is something that cannot be avoided otherwise.

If changing capitalization violates the string freeze,

It definitely does. This change does not fix any bug, and the not-that-perfect style of the original string does not affect transitions.

ngraham planned changes to this revision.Aug 25 2018, 5:34 PM

OK, will change. Thanks guys!

ngraham updated this revision to Diff 40437.Aug 25 2018, 5:36 PM

Rebase on master, not the stable branch

ngraham updated this revision to Diff 40438.Aug 25 2018, 5:37 PM

Oops, do that correctly

pino added a comment.Aug 25 2018, 5:39 PM

For the fix itself: you do not need a diff review for this kind of changes, especially for master branches that were recently opened again for development...

OK, no problem. :) I just like to do my work in public. I'll take your comment to mean acceptance and land the patch!

This revision was not accepted when it landed; it landed in state Needs Review.Aug 25 2018, 5:41 PM
This revision was automatically updated to reflect the committed changes.
aacid added a subscriber: aacid.Aug 26 2018, 9:38 PM
In D15083#315441, @pino wrote:

Question for the localization folks: can I change this string in the stable branch?

There is the string freeze in stable branches.

So I guess that's my question: is the freeze a total freeze, or does changing capitalization not count? If changing capitalization violates the string freeze, I'm more than happy to re-base this on master instead of the stable branch.

You neet to understand that if you change the capitalization, the string changes, and all translations "disappear", so your "small tweak" suddenly untranslates the string for every single language, so really not a good idea to do it on a stable branch.