Closing by lack of activity.

Doesn't look like my comments are going to be addressed, closing it for now.

Doesn't look like my comments are going to be addressed, closing it for now.

Doesn't look like my comments are going to be addressed, closing it for now.

This step is in the work in my local repository.

Revamped and rebased in my local repository, can be closed.

Revamped and rebased in my local repository, can be closed.

Revamped and rebased in my local repository, can be closed.

Now we're talking! I can properly review now.

Correction to the first patch on HACKING D4225
I clicked on update patch.

OK, I stopped reviewing mid-way...

Sorry guys for the time to finally review it. I was very busy, on the road... Finally got to it now.

Thanks for looking at completing this. Indeed that's needed. Improvements still required on grammar and on how generic those advises are.

I got a slightly more recent gcc but I doubt it is the issue. The "-std=gnu++11" on your compile line looks odd though, it likely overrides the "-std=c++14" which comes before. I think you should try to track that one down.

I use :
gcc (SUSE Linux) 5.3.1 20160301 [gcc-5-branch revision 233849]
cd /compile/kde5/zanshin/build/src/zanshin/kontact && /usr/bin/c++ -DKCOREADDONS_LIB -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_DISABLE_DEPRECATED_BEFORE=0 -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -DQT_WIDGETS_LIB -DQT_XML_LIB -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -Dkontact_zanshinplugin_EXPORTS -I/compile/kde5/zanshin/build/src/zanshin/kontact -I/compile/kde5/zanshin/src/zanshin/kontact -I/compile/kde5/zanshin -I/compile/kde5/zanshin/build -I/compile/kde5/zanshin/3rdparty/kdepim -I/compile/kde5/zanshin/3rdparty/kdepim/libkdepim -I/compile/kde5/zanshin/src -isystem /opt/kde5-qt5.7/include/KF5/KParts -isystem /opt/kde5-qt5.7/include/KF5 -isystem /opt/kde5-qt5.7/include/KF5/KIOWidgets -isystem /opt/kde5-qt5.7/include/KF5/KIOCore -isystem /opt/kde5-qt5.7/include/KF5/KCoreAddons -isystem /opt/qt5.7/include -isystem /opt/qt5.7/include/QtCore -isystem /opt/qt5.7/./mkspecs/linux-g++ -isystem /opt/kde5-qt5.7/include/KF5/KService -isystem /opt/kde5-qt5.7/include/KF5/KConfigCore -isystem /opt/kde5-qt5.7/include/KF5/KJobWidgets -isystem /opt/qt5.7/include/QtWidgets -isystem /opt/qt5.7/include/QtGui -isystem /opt/qt5.7/include/QtNetwork -isystem /opt/kde5-qt5.7/include/KF5/KCompletion -isystem /opt/kde5-qt5.7/include/KF5/KWidgetsAddons -isystem /opt/kde5-qt5.7/include/KF5/KXmlGui -isystem /opt/qt5.7/include/QtDBus -isystem /opt/qt5.7/include/QtXml -isystem /opt/kde5-qt5.7/include/KF5/KConfigWidgets -isystem /opt/kde5-qt5.7/include/KF5/KCodecs -isystem /opt/kde5-qt5.7/include/KF5/KConfigGui -isystem /opt/kde5-qt5.7/include/KF5/KAuth -isystem /opt/kde5-qt5.7/include/KF5/KTextWidgets -isystem /opt/kde5-qt5.7/include/KF5/SonnetUi -isystem /opt/kde5-qt5.7/include/KF5/KI18n -isystem /opt/kde5-qt5.7/include/KF5/KontactInterface -std=c++0x -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -std=c++14 -fexceptions -fPIC -fexceptions -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fPIC -std=gnu++11 -o CMakeFiles/kontact_zanshinplugin.dir/kontact_plugin.cpp.o -c /compile/kde5/zanshin/src/zanshin/kontact/kontact_plugin.cpp

Compiles here and we pass -std=c++14 to gcc for that purpose, it should build without this patch. Looks like a wrong g++ version or such? Maybe we should be more picky about that in the CMakeLists.txt?

Generate new template