GComprisProject
ActivePublic

Details

Description

GCompris is a high quality educational software suite comprising of numerous activities for children aged 2 to 10.

Recent Activity

Mon, Jan 13

jjazeix closed D26549: clockgame multiple dataset.

Thank you, pushed in https://commits.kde.org/gcompris/730ff4e546edb0227ff5f376ebc1feb77869c91e (I did the change @echarruau mentioned on difficulties)

Mon, Jan 13, 7:36 AM · GCompris, KDE Edu

Sun, Jan 12

echarruau added a comment to D26549: clockgame multiple dataset.

On my side I do not see anything to correct so far. I think next test will be done by real pupils :) Great work!

Sun, Jan 12, 9:46 PM · GCompris, KDE Edu
jjazeix accepted D26549: clockgame multiple dataset.
Sun, Jan 12, 5:32 PM · GCompris, KDE Edu
jjazeix added inline comments to D26549: clockgame multiple dataset.
Sun, Jan 12, 5:26 PM · GCompris, KDE Edu
dekumar added a comment to D26549: clockgame multiple dataset.

I have made all the changes as requested.

Sun, Jan 12, 4:12 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • 24 four hours format reverted back
Sun, Jan 12, 4:10 PM · GCompris, KDE Edu
dekumar added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...

I think for 24 hrs format there is no AM/PM. As 20hr is equal to 8 pm using this format.
Let me know if you want me to remove 24hrs format from the diff for now.

For me, it needs more discussion on how to handle it in a clean way

Sun, Jan 12, 4:00 PM · GCompris, KDE Edu
jjazeix added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...

I think for 24 hrs format there is no AM/PM. As 20hr is equal to 8 pm using this format.
Let me know if you want me to remove 24hrs format from the diff for now.

Sun, Jan 12, 2:33 PM · GCompris, KDE Edu
dekumar added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...
Sun, Jan 12, 2:27 PM · GCompris, KDE Edu
jjazeix added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h?

...

Sun, Jan 12, 2:22 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • typo fixed
Sun, Jan 12, 2:12 PM · GCompris, KDE Edu
jjazeix added inline comments to D26549: clockgame multiple dataset.
Sun, Jan 12, 2:11 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • goal modified
Sun, Jan 12, 2:09 PM · GCompris, KDE Edu

Sat, Jan 11

dekumar updated the diff for D26549: clockgame multiple dataset.
  • levels added
Sat, Jan 11, 7:22 PM · GCompris, KDE Edu

Fri, Jan 10

echarruau added a comment to D26549: clockgame multiple dataset.

Can you modify the options messages to make them shorter. I commented two of them in the code.

Fri, Jan 10, 10:07 PM · GCompris, KDE Edu
dekumar added a reviewer for D26549: clockgame multiple dataset: timotheegiet.
Fri, Jan 10, 5:59 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • all levels added
Fri, Jan 10, 5:57 PM · GCompris, KDE Edu

Thu, Jan 9

jjazeix added a reviewer for D26549: clockgame multiple dataset: GCompris: Improvements.
Thu, Jan 9, 5:12 PM · GCompris, KDE Edu
dekumar added a project to D26549: clockgame multiple dataset: GCompris.
Thu, Jan 9, 5:06 PM · GCompris, KDE Edu

Sat, Dec 28

echarruau added a comment to M146: GCompris multi-dataset mock-up.

I think the possibility to have non exclusif choice in multipledataset config menu will cause problems in smallnumbers where we want to follow a precise plan to teach/train numbers.

Sat, Dec 28, 2:46 PM · GCompris
dekumar abandoned D26176: Add multiple datasets to calendar activity.
Sat, Dec 28, 8:40 AM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.

@jjazeix I have create a new diff D26252 as updating this diff might have again updates all of the files of my latest applied commits.
Thanks!

Sat, Dec 28, 8:39 AM · KDE Edu, GCompris

Fri, Dec 27

dekumar added a comment to D26176: Add multiple datasets to calendar activity.

@jjazeix Sorry, I didn't checked that. I would apply that commit and update the diff again. Thanks!

Fri, Dec 27, 6:57 PM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.
Fri, Dec 27, 6:56 PM · KDE Edu, GCompris
jjazeix changed the visibility for M146: GCompris multi-dataset mock-up.
Fri, Dec 27, 6:54 PM · GCompris
jjazeix added a comment to D26176: Add multiple datasets to calendar activity.

Can you please try once applying the patch to gsoc_akshaychd_calendar_multiple_datasets branch? As I have made changes and created a diff from this branch.
Thanks!

It's the branch we try to apply it

Hi, I tried to apply the patch by deleting the previous akshaychd_calendar branch by trying out these steps and didn't got any error:
git checkout -b gsoc_akshaychd_calendar_multiple_datasets origin/gsoc_akshaychd_calendar_multiple_datasets
arc patch D26176

Can you please check again once?
Thanks!

Fri, Dec 27, 6:24 PM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.

Can you please try once applying the patch to gsoc_akshaychd_calendar_multiple_datasets branch? As I have made changes and created a diff from this branch.
Thanks!

It's the branch we try to apply it

Fri, Dec 27, 5:54 PM · KDE Edu, GCompris

Thu, Dec 26

jjazeix added a comment to D26176: Add multiple datasets to calendar activity.

Can you please try once applying the patch to gsoc_akshaychd_calendar_multiple_datasets branch? As I have made changes and created a diff from this branch.
Thanks!

Thu, Dec 26, 2:47 PM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.

@dekumar the patch does not apply:
git apply calendar.patch
error: patch failed: src/activities/find_the_day/resource/1/Data.qml:43
error: src/activities/find_the_day/resource/1/Data.qml: patch does not apply

Can you please check why?

Thu, Dec 26, 2:42 PM · KDE Edu, GCompris
echarruau closed T10422: Multipledataset description and improvement, a subtask of T10211: Multiple Dataset Design , as Wontfix.
Thu, Dec 26, 1:18 PM · GCompris
jjazeix added a comment to D26176: Add multiple datasets to calendar activity.

@dekumar the patch does not apply:
git apply calendar.patch
error: patch failed: src/activities/find_the_day/resource/1/Data.qml:43
error: src/activities/find_the_day/resource/1/Data.qml: patch does not apply

Thu, Dec 26, 10:43 AM · KDE Edu, GCompris

Wed, Dec 25

jjazeix closed T11922: Fix GCompris neon build as Resolved.

Thank you!
working: https://build.neon.kde.org/view/Snaps/job/bionic_release_extras_gcompris-qt_snap_amd64/
Fix pushed in https://cgit.kde.org/gcompris.git/commit/?id=3b0fcd2b2e0e9c4492a53c158879ba3b2664c528

Wed, Dec 25, 5:46 PM · GCompris
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
  • deleted extra empty file
Wed, Dec 25, 3:11 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
  • updated diff
Wed, Dec 25, 3:05 PM · GCompris: Improvements, KDE Edu

Tue, Dec 24

jjazeix added a comment to T11922: Fix GCompris neon build.

@jriddell can you try with https://gcompris.net/download/qt/src/gcompris-qt-0.98.tar.xz when you have some time?
I've done 2 changes: first look in the default path for box2d and if not found, I remove the CMAKE_ROOT_PATH and look for it again.

Tue, Dec 24, 5:41 PM · GCompris
shubhammishra added a comment to D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.

Fixed the error, rephrased the objectives as well but now it is affecting redraw_symmetric activity. For redraw_symmetric it is looking for a data in src/activities/redraw_symmetric/resource folder but i want them to share data of redraw activity . can you help me in this?

Tue, Dec 24, 4:52 PM · GCompris: Improvements, KDE Edu
jjazeix added a comment to D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.

Thanks for the patch.

Tue, Dec 24, 10:10 AM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.

Updating D26186: Added multilevel dataset in redraw and redraw_symmetrical activity

Tue, Dec 24, 4:28 AM · GCompris: Improvements, KDE Edu

Mon, Dec 23

shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Mon, Dec 23, 6:56 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Mon, Dec 23, 6:46 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Mon, Dec 23, 5:51 PM · GCompris: Improvements, KDE Edu
shubhammishra moved T12418: Add multiple levels in redraw activity from Backlog to Need review on the GCompris board.
Mon, Dec 23, 2:57 PM · GCompris: Improvements
shubhammishra added a task to D26186: Added multilevel dataset in redraw and redraw_symmetrical activity: T12418: Add multiple levels in redraw activity .
Mon, Dec 23, 2:56 PM · GCompris: Improvements, KDE Edu
shubhammishra added a revision to T12418: Add multiple levels in redraw activity : D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Mon, Dec 23, 2:56 PM · GCompris: Improvements
shubhammishra triaged T12418: Add multiple levels in redraw activity as Normal priority.
Mon, Dec 23, 2:55 PM · GCompris: Improvements

Dec 23 2019

shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 1:21 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 1:17 PM · GCompris: Improvements, KDE Edu
shubhammishra requested review of D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 12:10 PM · GCompris: Improvements, KDE Edu
dekumar updated the diff for D26176: Add multiple datasets to calendar activity.

Changes I have done:

  1. Added one level selection to find date in any month
  2. Made the okButton, level and activityConfig visible when there is no tutorial.

@jjazeix Please review it.
Thanks!

Dec 23 2019, 9:06 AM · KDE Edu, GCompris
dekumar requested review of D26176: Add multiple datasets to calendar activity.
Dec 23 2019, 9:03 AM · KDE Edu, GCompris