GCompris is a high quality educational software suite comprising of numerous activities for children aged 2 to 10.
Wed, Nov 6
Tue, Nov 5
Sun, Nov 3
Sat, Nov 2
Thu, Oct 31
Wed, Oct 30
Tested on master, all works good :)
It's merged, please check the master branch to be sure it works fine :)
Tue, Oct 29
Since aman managed to fix the remaining bug, I'd say it's good to merge now.
I tried taking a look at it in the noon. What I figured out is, when the tracks are freshly appended (after the music reaches the end of the last track and the stop signal initiates the re-append of tracks), the 1st music indeed plays, but that's for a very small period of time. After all the songs are appended, I don't know why, but the stop signal of the audio element is triggered again for some reason. This causes the 2nd track to play. I can't see why it happens :/
Ok, the "missing track" issue is fixed, at the cost of bringing back the "restart needed to re-enable music if started without" bug.
As I noted in the commit comment, ideally fixing both would be best, but if not possible it's less bad to keep the restart-needed issue than the missing track one.
Ouch, actually I found a last remaining bug: when the music reaches the end of last track in the list, it restarts on track 2 instead of track 1... (it doesn't happen when using the "Next" button, only when playing normally).
I'll look at it.
All features completed, bugs fixed, and thoroughly tested.
@jjazeix can you please merge it to master ?
Sun, Oct 27
I added a note about this in gcompris-data repository ( https://cgit.kde.org/gcompris-data.git/commit/?id=e0537083aebc8136c123cfe4094d43ccdb43bd30 ).
Let's keep those images a little longer for retro-compatibility with pre-0.95 versions of GCompris.
Sat, Oct 26
@jjazeix @timotheegiet AFAIR, I once experimented with adding metadata to a piece of music and yes, it gets lost when converted to other formats. If we can extract the metadata in the conversion script and add it back once converted, it would be nice.
So, getting back on this, this is the checklist of things to do:
- Fix bug: if starting GCompris with music disabled, enabling it doesn't work (no music played) until restarting the application.
- Add volume slider for background music and audio effects.
- Display the author and license info of each track.
- Consider the format of the music according to the platform.
- Add unit test for the ApplicationSettings changes.
Tue, Oct 22
All rcc files updated on the server with proper tags (artist, title, year and copyright in comments) :)
For the copyright info I'll add them in the COMMENTS tag.
Indeed, here I found a way to transfer metadata to aac using id3v2 command line, at least for ARTIST, TITLE and YEAR.
This should be usable for mp3 too, I'll update the script accordingly.
it does not seem to be the case. I updated the script to keep metadata from ogg to mp3 conversion, but didn't manage yet to find something for aac :/
Thanks, I'll add the tags to ogg files; I've read ffmpeg should keep them during conversion by default, I'll double check and update the rcc on the server.
https://doc.qt.io/qt-5/qml-qtmultimedia-audio.html#metaData-prop to be tested :)
Oct 15 2019
I updated the music set on the gcompris-data repository, and uploaded the .rcc files to the server.
Let me know if you find any issue with that new set.
Can you add a unit test for the ApplicationSettings changes?
I did one new comment in https://phabricator.kde.org/R2:d3224edb5edc6f21dab3880351e11683f9e60a99
At some places, can you take a look if you can use algorithms instead of while/for loops (using filter for example if it works to do the difference between filtered music and all music)?
Oct 10 2019
That's great to hear! :D
Tested quickly, it seems to work fine.
Oct 9 2019
Oct 8 2019
The final feature is done as well!
- Needs testing by other members.
- Discuss more features if needed.
- Update music names on the server.
- Update the design if required.
- Probably merge in master for next release, if possible.
Oct 7 2019
The feature to filter background musics and save/load them to play is implemented. At present, the changes get into effect after the software is restarted.
Next thing to do is to dynamically change the playlist in GCAudio element for background music to make the changes get into effect immediately.