Feed Advanced Search

Sun, Feb 23

jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sun, Feb 23, 4:47 PM · GCompris
jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sun, Feb 23, 4:47 PM · GCompris
jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sun, Feb 23, 4:22 PM · GCompris

Sat, Feb 22

jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 22, 3:33 PM · GCompris
jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 22, 10:34 AM · GCompris
jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 22, 10:31 AM · GCompris

Mon, Feb 17

vivekiit removed a watcher for GCompris: vivekiit.
Mon, Feb 17, 3:18 PM

Thu, Feb 13

timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Thu, Feb 13, 5:23 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Thu, Feb 13, 4:18 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Thu, Feb 13, 3:48 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Thu, Feb 13, 3:46 PM · GCompris

Mon, Feb 10

timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Mon, Feb 10, 3:49 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Mon, Feb 10, 3:27 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Mon, Feb 10, 3:26 PM · GCompris

Thu, Feb 6

timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Thu, Feb 6, 11:30 PM · GCompris

Wed, Feb 5

echarruau added a comment to T12632: General TODO for multi-dataset integration before merge to master.

And maybe also, grey-out the filtered datasets to prevent them from being selected, and display a notification that a Difficulty filter is active (but that point is optional/to discuss).

Wed, Feb 5, 8:38 PM · GCompris

Tue, Feb 4

timotheegiet added a comment to M146: GCompris multi-dataset mock-up.

PS: see this task with the general TODO for multi-dataset to see how it fits the whole design idea: https://phabricator.kde.org/T12632

Tue, Feb 4, 4:28 PM · GCompris
timotheegiet added a comment to M146: GCompris multi-dataset mock-up.

I would really prefer to stick to "cumulative dataset" principle rather than "exclusive dataset".
The reason is to be able to have all datasets selected by default, to not force users to select datasets.

Tue, Feb 4, 4:12 PM · GCompris

Sun, Feb 2

jjazeix created T12639: Improve downloading rcc.
Sun, Feb 2, 3:14 PM · GCompris
jjazeix updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sun, Feb 2, 12:21 PM · GCompris

Sat, Feb 1

timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 1, 3:22 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 1, 3:22 PM · GCompris
timotheegiet updated the task description for T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 1, 3:22 PM · GCompris
timotheegiet created T12632: General TODO for multi-dataset integration before merge to master.
Sat, Feb 1, 3:11 PM · GCompris

Jan 23 2020

vivekiit added a watcher for GCompris: vivekiit.
Jan 23 2020, 7:24 PM

Jan 13 2020

jjazeix closed D26549: clockgame multiple dataset.

Thank you, pushed in https://commits.kde.org/gcompris/730ff4e546edb0227ff5f376ebc1feb77869c91e (I did the change @echarruau mentioned on difficulties)

Jan 13 2020, 7:36 AM · GCompris, KDE Edu

Jan 12 2020

echarruau added a comment to D26549: clockgame multiple dataset.

On my side I do not see anything to correct so far. I think next test will be done by real pupils :) Great work!

Jan 12 2020, 9:46 PM · GCompris, KDE Edu
jjazeix accepted D26549: clockgame multiple dataset.
Jan 12 2020, 5:32 PM · GCompris, KDE Edu
jjazeix added inline comments to D26549: clockgame multiple dataset.
Jan 12 2020, 5:26 PM · GCompris, KDE Edu
dekumar added a comment to D26549: clockgame multiple dataset.

I have made all the changes as requested.

Jan 12 2020, 4:12 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • 24 four hours format reverted back
Jan 12 2020, 4:10 PM · GCompris, KDE Edu
dekumar added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...

I think for 24 hrs format there is no AM/PM. As 20hr is equal to 8 pm using this format.
Let me know if you want me to remove 24hrs format from the diff for now.

For me, it needs more discussion on how to handle it in a clean way

Jan 12 2020, 4:00 PM · GCompris, KDE Edu
jjazeix added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...

I think for 24 hrs format there is no AM/PM. As 20hr is equal to 8 pm using this format.
Let me know if you want me to remove 24hrs format from the diff for now.

Jan 12 2020, 2:33 PM · GCompris, KDE Edu
dekumar added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...
Jan 12 2020, 2:27 PM · GCompris, KDE Edu
jjazeix added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h?

...
I think we should use https://doc.qt.io/qt-5/qml-qtqml-date.html to format the time correctly (but it is work for the other task)

Jan 12 2020, 2:22 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • typo fixed
Jan 12 2020, 2:12 PM · GCompris, KDE Edu
jjazeix added inline comments to D26549: clockgame multiple dataset.
Jan 12 2020, 2:11 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.
  • goal modified
Jan 12 2020, 2:09 PM · GCompris, KDE Edu

Jan 11 2020

dekumar updated the diff for D26549: clockgame multiple dataset.

I have done the following changes:

  1. Added the 24 hours format to some levels as discussed.
  2. Made the minutes hand visible for all of the levels.
Jan 11 2020, 7:22 PM · GCompris, KDE Edu

Jan 10 2020

echarruau added a comment to D26549: clockgame multiple dataset.

Can you modify the options messages to make them shorter. I commented two of them in the code.

Jan 10 2020, 10:07 PM · GCompris, KDE Edu
dekumar added a reviewer for D26549: clockgame multiple dataset: timotheegiet.
Jan 10 2020, 5:59 PM · GCompris, KDE Edu
dekumar updated the diff for D26549: clockgame multiple dataset.

I have added all the different configurations as defined for the dataset of clock-game.

Jan 10 2020, 5:57 PM · GCompris, KDE Edu

Jan 9 2020

jjazeix added a reviewer for D26549: clockgame multiple dataset: GCompris: Improvements.
Jan 9 2020, 5:12 PM · GCompris, KDE Edu
dekumar added a project to D26549: clockgame multiple dataset: GCompris.
Jan 9 2020, 5:06 PM · GCompris, KDE Edu

Dec 28 2019

echarruau added a comment to M146: GCompris multi-dataset mock-up.

I think the possibility to have non exclusif choice in multipledataset config menu will cause problems in smallnumbers where we want to follow a precise plan to teach/train numbers.

Dec 28 2019, 2:46 PM · GCompris
dekumar abandoned D26176: Add multiple datasets to calendar activity.
Dec 28 2019, 8:40 AM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.

@jjazeix I have create a new diff D26252 as updating this diff might have again updates all of the files of my latest applied commits.
Thanks!

Dec 28 2019, 8:39 AM · KDE Edu, GCompris

Dec 27 2019

dekumar added a comment to D26176: Add multiple datasets to calendar activity.

@jjazeix Sorry, I didn't checked that. I would apply that commit and update the diff again. Thanks!

Dec 27 2019, 6:57 PM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.
Dec 27 2019, 6:56 PM · KDE Edu, GCompris
jjazeix changed the visibility for M146: GCompris multi-dataset mock-up.
Dec 27 2019, 6:54 PM · GCompris
jjazeix added a comment to D26176: Add multiple datasets to calendar activity.

Can you please try once applying the patch to gsoc_akshaychd_calendar_multiple_datasets branch? As I have made changes and created a diff from this branch.
Thanks!

It's the branch we try to apply it

Hi, I tried to apply the patch by deleting the previous akshaychd_calendar branch by trying out these steps and didn't got any error:
git checkout -b gsoc_akshaychd_calendar_multiple_datasets origin/gsoc_akshaychd_calendar_multiple_datasets
arc patch D26176

Can you please check again once?
Thanks!

Dec 27 2019, 6:24 PM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.

Can you please try once applying the patch to gsoc_akshaychd_calendar_multiple_datasets branch? As I have made changes and created a diff from this branch.
Thanks!

It's the branch we try to apply it

Dec 27 2019, 5:54 PM · KDE Edu, GCompris

Dec 26 2019

jjazeix added a comment to D26176: Add multiple datasets to calendar activity.

Can you please try once applying the patch to gsoc_akshaychd_calendar_multiple_datasets branch? As I have made changes and created a diff from this branch.
Thanks!

Dec 26 2019, 2:47 PM · KDE Edu, GCompris
dekumar added a comment to D26176: Add multiple datasets to calendar activity.

@dekumar the patch does not apply:
git apply calendar.patch
error: patch failed: src/activities/find_the_day/resource/1/Data.qml:43
error: src/activities/find_the_day/resource/1/Data.qml: patch does not apply

Can you please check why?

Dec 26 2019, 2:42 PM · KDE Edu, GCompris
echarruau closed T10422: Multipledataset description and improvement, a subtask of T10211: Multiple Dataset Design , as Wontfix.
Dec 26 2019, 1:18 PM · GCompris
jjazeix added a comment to D26176: Add multiple datasets to calendar activity.

@dekumar the patch does not apply:
git apply calendar.patch
error: patch failed: src/activities/find_the_day/resource/1/Data.qml:43
error: src/activities/find_the_day/resource/1/Data.qml: patch does not apply

Dec 26 2019, 10:43 AM · KDE Edu, GCompris

Dec 25 2019

jjazeix closed T11922: Fix GCompris neon build as Resolved.

Thank you!
working: https://build.neon.kde.org/view/Snaps/job/bionic_release_extras_gcompris-qt_snap_amd64/
Fix pushed in https://cgit.kde.org/gcompris.git/commit/?id=3b0fcd2b2e0e9c4492a53c158879ba3b2664c528

Dec 25 2019, 5:46 PM · GCompris
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
  • deleted extra empty file
Dec 25 2019, 3:11 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
  • updated diff
Dec 25 2019, 3:05 PM · GCompris: Improvements, KDE Edu

Dec 24 2019

jjazeix added a comment to T11922: Fix GCompris neon build.

@jriddell can you try with https://gcompris.net/download/qt/src/gcompris-qt-0.98.tar.xz when you have some time?
I've done 2 changes: first look in the default path for box2d and if not found, I remove the CMAKE_FIND_ROOT_PATH and look for it again.

Dec 24 2019, 5:41 PM · GCompris
shubhammishra added a comment to D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.

Fixed the error, rephrased the objectives as well but now it is affecting redraw_symmetric activity. For redraw_symmetric it is looking for a data in src/activities/redraw_symmetric/resource folder but i want them to share data of redraw activity . can you help me in this?

Dec 24 2019, 4:52 PM · GCompris: Improvements, KDE Edu
jjazeix added a comment to D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.

Thanks for the patch.

Dec 24 2019, 10:10 AM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.

Updating D26186: Added multilevel dataset in redraw and redraw_symmetrical activity

Dec 24 2019, 4:28 AM · GCompris: Improvements, KDE Edu

Dec 23 2019

shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 6:56 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 6:46 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 5:51 PM · GCompris: Improvements, KDE Edu
shubhammishra moved T12418: Add multiple levels in redraw activity from Backlog to Need review on the GCompris board.
Dec 23 2019, 2:57 PM · GCompris: Improvements
shubhammishra added a task to D26186: Added multilevel dataset in redraw and redraw_symmetrical activity: T12418: Add multiple levels in redraw activity .
Dec 23 2019, 2:56 PM · GCompris: Improvements, KDE Edu
shubhammishra added a revision to T12418: Add multiple levels in redraw activity : D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 2:56 PM · GCompris: Improvements
shubhammishra triaged T12418: Add multiple levels in redraw activity as Normal priority.
Dec 23 2019, 2:55 PM · GCompris: Improvements
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 1:21 PM · GCompris: Improvements, KDE Edu
shubhammishra updated the diff for D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 1:17 PM · GCompris: Improvements, KDE Edu
shubhammishra requested review of D26186: Added multilevel dataset in redraw and redraw_symmetrical activity.
Dec 23 2019, 12:10 PM · GCompris: Improvements, KDE Edu
dekumar updated the diff for D26176: Add multiple datasets to calendar activity.

Changes I have done:

  1. Added one level selection to find date in any month
  2. Made the okButton, level and activityConfig visible when there is no tutorial.

@jjazeix Please review it.
Thanks!

Dec 23 2019, 9:06 AM · KDE Edu, GCompris
dekumar requested review of D26176: Add multiple datasets to calendar activity.
Dec 23 2019, 9:03 AM · KDE Edu, GCompris

Dec 22 2019

dekumar updated the diff for D22266: Add multiple datasets to calendar activity.

@jjazeix Hi, I have tried again by creating a new branch it is still updating all the files.
I have made changes to find_the_day/resources/Data/1.qml and made the level,activityConfig visible only when there is no tutorial.

Dec 22 2019, 11:43 AM · GCompris, KDE Edu
dekumar updated the diff for D22266: Add multiple datasets to calendar activity.
  • reverted changes
Dec 22 2019, 11:32 AM · GCompris, KDE Edu
dekumar added a comment to D22266: Add multiple datasets to calendar activity.

@dekumar it seems you didn't created the branch from Akshay's one, so the diff contains a lot of files that shouldn't be there.
The diff should only contain files from calendar and find_the_day activities.
To do so, checkout the good branch, and do a git checkout -b "your_branch" and update the diff here please

Dec 22 2019, 10:49 AM · GCompris, KDE Edu
jjazeix added a comment to D22266: Add multiple datasets to calendar activity.

@dekumar it seems you didn't created the branch from Akshay's one, so the diff contains a lot of files that shouldn't be there.
The diff should only contain files from calendar and find_the_day activities.
To do so, checkout the good branch, and do a git checkout -b "your_branch" and update the diff here please

Dec 22 2019, 10:36 AM · GCompris, KDE Edu
dekumar added reviewers for D22266: Add multiple datasets to calendar activity: jjazeix, echarruau.
Dec 22 2019, 9:58 AM · GCompris, KDE Edu
dekumar updated the diff for D22266: Add multiple datasets to calendar activity.

Changes done:

  1. I have added a new level selection in Data/1.qml to select day from any months.
  2. I have made the level selection and the activity config only visible when there is no tutorial.

Thanks !

Dec 22 2019, 9:53 AM · GCompris, KDE Edu

Dec 1 2019

timotheegiet closed T11924: release 0.97 as Resolved.

Release published and announced :)

Dec 1 2019, 9:40 PM · GCompris

Nov 6 2019

timotheegiet updated the task description for T11924: release 0.97.
Nov 6 2019, 1:39 PM · GCompris
timotheegiet updated the task description for T11924: release 0.97.
Nov 6 2019, 1:36 PM · GCompris
timotheegiet updated the task description for T11924: release 0.97.
Nov 6 2019, 1:23 PM · GCompris
timotheegiet updated the task description for T11924: release 0.97.
Nov 6 2019, 1:17 PM · GCompris
timotheegiet updated the task description for T11924: release 0.97.
Nov 6 2019, 12:57 PM · GCompris

Nov 5 2019

timotheegiet updated the task description for T11924: release 0.97.
Nov 5 2019, 8:02 PM · GCompris

Nov 3 2019

jjazeix moved T11924: release 0.97 from Backlog to WIP on the GCompris board.
Nov 3 2019, 1:42 PM · GCompris

Nov 2 2019

jjazeix closed T7828: Chess: add list of taken pieces, a subtask of T11924: release 0.97, as Resolved.
Nov 2 2019, 2:22 PM · GCompris

Oct 31 2019

jjazeix closed T11932: Addition of a "try again" voice, a subtask of T11924: release 0.97, as Resolved.
Oct 31 2019, 7:30 PM · GCompris

Oct 30 2019

timotheegiet updated the task description for T11924: release 0.97.
Oct 30 2019, 9:49 PM · GCompris
timotheegiet added a comment to T1543: Background music.

Tested on master, all works good :)

Oct 30 2019, 9:45 PM · GCompris
jjazeix closed T1543: Background music, a subtask of T11924: release 0.97, as Resolved.
Oct 30 2019, 8:39 PM · GCompris
jjazeix closed T1543: Background music as Resolved.

It's merged, please check the master branch to be sure it works fine :)

Oct 30 2019, 8:39 PM · GCompris

Oct 29 2019

timotheegiet added a comment to T1543: Background music.

Since aman managed to fix the remaining bug, I'd say it's good to merge now.

Oct 29 2019, 6:56 PM · GCompris
amankumargupta added a comment to T1543: Background music.

I tried taking a look at it in the noon. What I figured out is, when the tracks are freshly appended (after the music reaches the end of the last track and the stop signal initiates the re-append of tracks), the 1st music indeed plays, but that's for a very small period of time. After all the songs are appended, I don't know why, but the stop signal of the audio element is triggered again for some reason. This causes the 2nd track to play. I can't see why it happens :/

Oct 29 2019, 5:52 PM · GCompris
timotheegiet added a comment to T1543: Background music.

Ok, the "missing track" issue is fixed, at the cost of bringing back the "restart needed to re-enable music if started without" bug.
As I noted in the commit comment, ideally fixing both would be best, but if not possible it's less bad to keep the restart-needed issue than the missing track one.

Oct 29 2019, 5:46 PM · GCompris
jjazeix added a subtask for T11924: release 0.97: T11932: Addition of a "try again" voice.
Oct 29 2019, 7:42 AM · GCompris
timotheegiet added a comment to T1543: Background music.

Ouch, actually I found a last remaining bug: when the music reaches the end of last track in the list, it restarts on track 2 instead of track 1... (it doesn't happen when using the "Next" button, only when playing normally).
I'll look at it.

Oct 29 2019, 3:53 AM · GCompris