valeriymalov (Valeriy Malov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 24 2016, 9:05 AM (147 w, 3 d)
Availability
Available

Recent Activity

Yesterday

valeriymalov requested review of D24149: Cleanup ViewModel a bit and try to fix crash on exit.
Sun, Sep 22, 6:32 PM

Jun 27 2019

valeriymalov committed R247:333dd3748b1f: wacomtablet stable branch switched from 3.1 to 3.2 (authored by valeriymalov).
wacomtablet stable branch switched from 3.1 to 3.2
Jun 27 2019, 5:57 PM
valeriymalov committed R530:2799d060db3e: Remove old way of button detection from the readme (authored by valeriymalov).
Remove old way of button detection from the readme
Jun 27 2019, 5:45 PM
valeriymalov committed R530:a680f5bcaf19: Bump version to 3.2.0 (authored by valeriymalov).
Bump version to 3.2.0
Jun 27 2019, 5:36 PM
valeriymalov committed R530:17feb0574bb0: Merge branch '3.1' (authored by valeriymalov).
Merge branch '3.1'
Jun 27 2019, 5:31 PM
valeriymalov committed R530:a431056224a4: Add mapping for Wacom Intuos BT S (bluetooth) (authored by valeriymalov).
Add mapping for Wacom Intuos BT S (bluetooth)
Jun 27 2019, 4:47 PM
valeriymalov committed R530:fcb003a2525e: Add mapping for Wacom Intuos BT S (authored by valeriymalov).
Add mapping for Wacom Intuos BT S
Jun 27 2019, 4:33 PM

Jun 23 2019

valeriymalov committed R530:f6ca04f45d76: Button layout for Wacom Intuos Small and Medium with Bluetooth connection (CTL… (authored by stefanog).
Button layout for Wacom Intuos Small and Medium with Bluetooth connection (CTL…
Jun 23 2019, 1:44 PM
valeriymalov closed D21834: Button layout for Wacom Intuos Small and Medium with Bluetooth connection (CTL-4100, CTL-4100WL, CTL-6100WL).
Jun 23 2019, 1:44 PM
valeriymalov committed R530:e8e3c226717f: Support for tablet Wacom Intuos Medium with Bluetooth (CTL-6100WL) (authored by stefanog).
Support for tablet Wacom Intuos Medium with Bluetooth (CTL-6100WL)
Jun 23 2019, 1:19 PM
valeriymalov closed D21833: Support for tablet Wacom Intuos Medium with Bluetooth (CTL-6100WL).
Jun 23 2019, 1:19 PM
valeriymalov added a comment to D21834: Button layout for Wacom Intuos Small and Medium with Bluetooth connection (CTL-4100, CTL-4100WL, CTL-6100WL).

Just to clarify the email used is going to be public anyway in the commit history.

Jun 23 2019, 12:13 PM
valeriymalov added a comment to D21834: Button layout for Wacom Intuos Small and Medium with Bluetooth connection (CTL-4100, CTL-4100WL, CTL-6100WL).

Emails on identity.kde.org are only public for developers or to sysadmins. Can you post it here?

Jun 23 2019, 12:12 PM

Jun 18 2019

valeriymalov accepted D21834: Button layout for Wacom Intuos Small and Medium with Bluetooth connection (CTL-4100, CTL-4100WL, CTL-6100WL).

Thanks for the patch.

Jun 18 2019, 9:04 PM
valeriymalov committed R530:8d242c7400be: add fixme for libwacom button code (authored by valeriymalov).
add fixme for libwacom button code
Jun 18 2019, 8:47 PM
valeriymalov committed R530:4be87fb7cd65: final -> final override to mute some warnings (authored by valeriymalov).
final -> final override to mute some warnings
Jun 18 2019, 8:46 PM
valeriymalov accepted D21833: Support for tablet Wacom Intuos Medium with Bluetooth (CTL-6100WL).

Hi, thanks for the patch.

Jun 18 2019, 8:45 PM
valeriymalov committed R530:989e26879b68: Remove x11-xlib dependency (authored by valeriymalov).
Remove x11-xlib dependency
Jun 18 2019, 7:01 PM

Jun 13 2019

valeriymalov committed R530:fd099f89c5de: Correct width/height values from X11Wacom::getMaximumTabletArea (authored by jgerecke).
Correct width/height values from X11Wacom::getMaximumTabletArea
Jun 13 2019, 9:22 PM
valeriymalov committed R530:ed47f67a439a: Correct width/height values from X11Wacom::getMaximumTabletArea (authored by jgerecke).
Correct width/height values from X11Wacom::getMaximumTabletArea
Jun 13 2019, 9:20 PM
valeriymalov closed D21775: Correct width/height values from X11Wacom::getMaximumTabletArea.
Jun 13 2019, 9:20 PM
valeriymalov accepted D21775: Correct width/height values from X11Wacom::getMaximumTabletArea.

Hi, thanks for the patch. Hopefully this is the last calibration issue, unfortunately I can't really test/track them down because I currently don't have access to a screen tablet.
I should make a bugfix release with it in the next few days.

Jun 13 2019, 9:19 PM

May 23 2019

valeriymalov committed R16:9565ef61abee: Add support for smartmontools 7.0 user_capacity json output (authored by valeriymalov).
Add support for smartmontools 7.0 user_capacity json output
May 23 2019, 2:44 PM
valeriymalov closed D21311: Add support for smartmontools 7.0 user_capacity json output.
May 23 2019, 2:43 PM

May 20 2019

valeriymalov requested review of D21311: Add support for smartmontools 7.0 user_capacity json output.
May 20 2019, 7:25 PM

May 2 2019

valeriymalov committed R530:a8bac2225fa6: Drop support for systems without xcb-xinput (part 2) (authored by valeriymalov).
Drop support for systems without xcb-xinput (part 2)
May 2 2019, 5:26 PM
valeriymalov committed R530:fdc9abdd352f: Drop support for systems without xcb-xinput (part 1) (authored by valeriymalov).
Drop support for systems without xcb-xinput (part 1)
May 2 2019, 5:26 PM
valeriymalov committed R530:2dccb37fe344: rename x11info module -> screensinfo (authored by valeriymalov).
rename x11info module -> screensinfo
May 2 2019, 5:26 PM
valeriymalov committed R530:efd3e3eb08c2: Clean up X11Info class (authored by valeriymalov).
Clean up X11Info class
May 2 2019, 5:26 PM

Apr 28 2019

valeriymalov committed R530:810487c4fa24: (Supposedly) fix building with gcc9 (authored by valeriymalov).
(Supposedly) fix building with gcc9
Apr 28 2019, 4:48 PM
valeriymalov committed R530:20d6c2876a9d: Use override where applicable (authored by valeriymalov).
Use override where applicable
Apr 28 2019, 4:48 PM

Mar 13 2019

valeriymalov committed R293:eb68430ae5f4: Baloo engine: treat every non-success code as a failure (authored by valeriymalov).
Baloo engine: treat every non-success code as a failure
Mar 13 2019, 10:17 PM
valeriymalov closed D18664: Baloo engine: treat every non-success code as a failure.
Mar 13 2019, 10:17 PM · Baloo, Frameworks

Mar 10 2019

valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • do not ignore results of PostingDB::iter in case of an error/end of db
Mar 10 2019, 5:19 PM · Baloo, Frameworks

Feb 21 2019

valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • fix MTimeDB::get loop
Feb 21 2019, 6:16 PM · Baloo, Frameworks
valeriymalov committed R293:f5f1ae889fe9: add baloo engine debugging category (authored by valeriymalov).
add baloo engine debugging category
Feb 21 2019, 4:48 PM
valeriymalov closed D18873: add baloo engine debugging category.
Feb 21 2019, 4:48 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • review warning fixes
Feb 21 2019, 4:29 PM · Baloo, Frameworks
valeriymalov updated the summary of D18664: Baloo engine: treat every non-success code as a failure.
Feb 21 2019, 4:25 PM · Baloo, Frameworks

Feb 9 2019

valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • fix ::del error logging criteria, don't return without closing cursor in
Feb 9 2019, 7:16 PM · Baloo, Frameworks
valeriymalov added inline comments to D18664: Baloo engine: treat every non-success code as a failure.
Feb 9 2019, 6:09 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • update logging per review
Feb 9 2019, 6:09 PM · Baloo, Frameworks
valeriymalov updated the diff for D18873: add baloo engine debugging category.

is it now how it's supposed to look in the end? not really sure where .category syntax is defined

Feb 9 2019, 6:03 PM · Baloo, Frameworks
valeriymalov updated the diff for D18873: add baloo engine debugging category.
  • update categories per review
Feb 9 2019, 3:10 PM · Baloo, Frameworks
valeriymalov added a dependent revision for D18873: add baloo engine debugging category: D18664: Baloo engine: treat every non-success code as a failure.
Feb 9 2019, 2:45 PM · Baloo, Frameworks
valeriymalov added a dependency for D18664: Baloo engine: treat every non-success code as a failure: D18873: add baloo engine debugging category.
Feb 9 2019, 2:45 PM · Baloo, Frameworks
valeriymalov added inline comments to D18873: add baloo engine debugging category.
Feb 9 2019, 2:30 PM · Baloo, Frameworks
valeriymalov updated the diff for D18873: add baloo engine debugging category.
  • use new syntax for baloo.categories
Feb 9 2019, 2:30 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
Feb 9 2019, 1:59 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • clean up rest of the asserts
Feb 9 2019, 1:56 PM · Baloo, Frameworks
valeriymalov requested review of D18873: add baloo engine debugging category.
Feb 9 2019, 1:09 PM · Baloo, Frameworks

Feb 3 2019

valeriymalov planned changes to D18664: Baloo engine: treat every non-success code as a failure.
  1. Are we actually sure this is gonna fix all those crashes? Otherwise I would suggest using CCBUG instead of BUG inside the commit message.

I've chosen those bugs based on backtraces I could get myself but without core dumps I can't vouch for that, even with core dumps it'd be hard to tell. Alternatively I can CCBUG and after this gets into a release, ask in those bugs people if they still experience the crash and close them if they won't get back in a month or so.

  1. For now, logging is the only way to know if there's something bad going on. In that case I would suggest to at least increase severity of those messages - it would increase chances users will notice it. For example, use qCCritical (but this would also require additional check for okayish/non-critical return codes, such as MDB_NOTFOUND)

These errors have good potential to flood users log files. I get around 30 megabytes of those on each boot. I'd rather see them disabled by default.
It might make sense to add a catch-all error message somewhere on higher level, that would get printed out once, but I haven't looked yet where such message could be placed.

  1. Looks like this patch is composed of two parts - introducing new logging category and and improving error handling. It would be also nice to split those into two separate patches.
  2. There are a lot of redundant Q_ASSERT_X left, which could be removed. I suggest just grep'ing over the code to catch'em all. I've started marking them here, but then I gave up - too many of them.
  3. There are also several unchecked return codes as well, such as inside *DB::size() calls. Those can also be found by grep'ing over Q_ASSERT_X.

I'll look into these this week.

Feb 3 2019, 9:43 PM · Baloo, Frameworks

Feb 2 2019

valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • unbreak documentdatadb::contains, oops :(
Feb 2 2019, 11:36 AM · Baloo, Frameworks
valeriymalov added a reviewer for D18664: Baloo engine: treat every non-success code as a failure: Baloo.
Feb 2 2019, 11:27 AM · Baloo, Frameworks
valeriymalov requested review of D18664: Baloo engine: treat every non-success code as a failure.
Feb 2 2019, 11:26 AM · Baloo, Frameworks

Dec 16 2018

valeriymalov committed R530:14bdd343a7a0: bump version to 3.1.1 (authored by valeriymalov).
bump version to 3.1.1
Dec 16 2018, 4:36 PM

Dec 9 2018

valeriymalov committed R530:35b3f18d6af2: fix Messages.sh target for plasmoid (authored by valeriymalov).
fix Messages.sh target for plasmoid
Dec 9 2018, 5:05 PM
valeriymalov committed R530:3291c95519f0: fix Messages.sh target for plasmoid (authored by valeriymalov).
fix Messages.sh target for plasmoid
Dec 9 2018, 5:05 PM
valeriymalov committed R530:47c26f713763: Minor preparations for new tablet page widget (authored by valeriymalov).
Minor preparations for new tablet page widget
Dec 9 2018, 4:30 PM
valeriymalov committed R530:f51af9cf11a1: Minor tweaks (authored by valeriymalov).
Minor tweaks
Dec 9 2018, 4:29 PM
valeriymalov committed R530:082ae1803949: Add tablet page autotest stub (authored by valeriymalov).
Add tablet page autotest stub
Dec 9 2018, 4:29 PM

Sep 20 2018

valeriymalov committed R530:c2be24a66d47: Fix reading of button mapping in tabletfinder (authored by valeriymalov).
Fix reading of button mapping in tabletfinder
Sep 20 2018, 6:41 PM
valeriymalov committed R530:6ccb10dc4d7b: Update README.md (authored by valeriymalov).
Update README.md
Sep 20 2018, 3:53 PM

Sep 19 2018

valeriymalov committed R530:05a99643e33b: Fix licensing in the file introduced in last commit (authored by valeriymalov).
Fix licensing in the file introduced in last commit
Sep 19 2018, 6:51 PM
valeriymalov committed R530:48ea95790955: ScreenSpace: expand supported types of screen spaces (authored by valeriymalov).
ScreenSpace: expand supported types of screen spaces
Sep 19 2018, 6:47 PM

Sep 12 2018

valeriymalov committed R295:cc4ecfdcd48a: Manually resize KCMUtilDialog to sizeHint() (authored by valeriymalov).
Manually resize KCMUtilDialog to sizeHint()
Sep 12 2018, 2:20 AM
valeriymalov closed D15406: Manually resize KCMUtilDialog to sizeHint().
Sep 12 2018, 2:20 AM · Frameworks

Sep 11 2018

valeriymalov added a comment to D15406: Manually resize KCMUtilDialog to sizeHint().

neither QWidget::adjustSize() nor QWidget::adjustedSize() seem to use devicePixelRatio (https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/kernel/qwidget.cpp#n8665), but I can't test that to vouch that it works on HiDPI as intended
I can land it as is but I don't really want to break kcmshell further for HiDPI users

Sep 11 2018, 1:42 PM · Frameworks

Sep 10 2018

acrouthamel awarded D15406: Manually resize KCMUtilDialog to sizeHint() a Like token.
Sep 10 2018, 3:02 PM · Frameworks
valeriymalov requested review of D15406: Manually resize KCMUtilDialog to sizeHint().
Sep 10 2018, 2:46 PM · Frameworks

Sep 5 2018

valeriymalov committed R473:2d73d5f25a1a: Fix memory corruption in ScanFolder plugin (authored by valeriymalov).
Fix memory corruption in ScanFolder plugin
Sep 5 2018, 6:07 PM
valeriymalov closed D15265: Fix memory corruption in ScanFolder plugin.

Landed it on 5.1, messed up with arc so it didn't close the diff
https://cgit.kde.org/ktorrent.git/commit/?id=2d73d5f25a1a364a2115fb1d3262377f7fdf99cd

Sep 5 2018, 5:54 PM

Sep 4 2018

valeriymalov added a comment to D15265: Fix memory corruption in ScanFolder plugin.

Backtraces are a bit inconsistent, usually it ends with malloc aborting with invalid porinter or other memory error

Sep 4 2018, 9:55 PM
valeriymalov updated the diff for D15265: Fix memory corruption in ScanFolder plugin.
  • fix typo
Sep 4 2018, 9:25 PM
valeriymalov requested review of D15265: Fix memory corruption in ScanFolder plugin.
Sep 4 2018, 11:59 AM

Sep 3 2018

valeriymalov committed R530:d21699e98bc6: Minor fixes (authored by valeriymalov).
Minor fixes
Sep 3 2018, 5:23 PM

Aug 28 2018

valeriymalov added inline comments to D3484: Center systemmonitor window properly on multi-screen setup.
Aug 28 2018, 12:18 AM · Plasma

Aug 13 2018

valeriymalov committed R295:23ba2b37ef82: Use custom QScrollArea with size hint not limited by font size (authored by valeriymalov).
Use custom QScrollArea with size hint not limited by font size
Aug 13 2018, 9:00 AM
valeriymalov closed D14692: Use custom QScrollArea with size hint not limited by font size.
Aug 13 2018, 9:00 AM · Frameworks

Aug 12 2018

valeriymalov added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

I don't know, it's frameworks after all but I guess I can land it today since it's a popular bug. Should I just land it on master since there seem to be no other branches?

Aug 12 2018, 11:19 AM · Frameworks

Aug 8 2018

valeriymalov updated the diff for D14692: Use custom QScrollArea with size hint not limited by font size.
  • add link to qt bug
Aug 8 2018, 1:44 PM · Frameworks
valeriymalov added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

I think it's this bug/suggestion: https://bugreports.qt.io/browse/QTBUG-10459

Aug 8 2018, 1:30 PM · Frameworks
valeriymalov added a reviewer for D14692: Use custom QScrollArea with size hint not limited by font size: Frameworks.

Context for the size hint limitation this patch is supposed to circumvent: https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qscrollarea.cpp.html#403

Aug 8 2018, 12:38 PM · Frameworks
valeriymalov requested review of D14692: Use custom QScrollArea with size hint not limited by font size.
Aug 8 2018, 12:35 PM · Frameworks

Jul 19 2018

valeriymalov committed R530:978bd40e0e2f: Fix spelling error in kded plugin (authored by scarlettclark).
Fix spelling error in kded plugin
Jul 19 2018, 6:58 PM
valeriymalov committed R530:ecb23d7824ba: Make tabs scrollable (authored by valeriymalov).
Make tabs scrollable
Jul 19 2018, 2:04 PM

Jul 14 2018

valeriymalov committed R530:f5c83ca5013c: Replace saveprofile.ui with KMessageBox (authored by valeriymalov).
Replace saveprofile.ui with KMessageBox
Jul 14 2018, 2:27 PM

Jul 12 2018

valeriymalov committed R530:781452ca93cd: Clean up StylusPageWidget and PressureCurveDialog interaction (authored by valeriymalov).
Clean up StylusPageWidget and PressureCurveDialog interaction
Jul 12 2018, 6:36 PM
valeriymalov committed R530:303f9b6d8871: Make KCM pages a bit more test-friendly (authored by valeriymalov).
Make KCM pages a bit more test-friendly
Jul 12 2018, 5:24 PM
valeriymalov committed R530:b9c84bd9e7cf: Un-pimpl styluspagewidget, add second test stub (authored by valeriymalov).
Un-pimpl styluspagewidget, add second test stub
Jul 12 2018, 4:13 PM

Jul 6 2018

valeriymalov committed R530:5a946f72d1da: Fix TestTabletHandler (authored by valeriymalov).
Fix TestTabletHandler
Jul 6 2018, 2:23 PM
valeriymalov committed R530:de2c52307a24: Add "Configure" button on the "new tablet" notification popup (authored by valeriymalov).
Add "Configure" button on the "new tablet" notification popup
Jul 6 2018, 2:22 PM

Jul 4 2018

valeriymalov committed R658:8332ffe800d9: Add .gitignore (authored by valeriymalov).
Add .gitignore
Jul 4 2018, 6:35 PM
valeriymalov committed R658:443e0e3a639a: add some X-KDE-Keywords for search in system settings (authored by valeriymalov).
add some X-KDE-Keywords for search in system settings
Jul 4 2018, 6:35 PM

Jun 29 2018

valeriymalov committed R530:2f45395d6889: Add basic test for stylus page settings persistency. (authored by valeriymalov).
Add basic test for stylus page settings persistency.
Jun 29 2018, 6:51 PM

Jun 28 2018

valeriymalov committed R530:ac06c96043e9: Initial setup for KCM testing (authored by valeriymalov).
Initial setup for KCM testing
Jun 28 2018, 5:45 PM

Jun 27 2018

valeriymalov committed R530:6f34b768b4e0: Buttons 6 and 7 are mouse wheel left/right (authored by valeriymalov).
Buttons 6 and 7 are mouse wheel left/right
Jun 27 2018, 3:27 PM
valeriymalov committed R530:adbf24fbdb6d: Fix pressure curve widget being too sticky (authored by valeriymalov).
Fix pressure curve widget being too sticky
Jun 27 2018, 1:03 PM

Jun 14 2018

valeriymalov committed R530:190ca9735ae0: Add Wacom Intuos Pro 2 M to device list (authored by Jeff H <nomasteryoda@gmail.com>).
Add Wacom Intuos Pro 2 M to device list
Jun 14 2018, 3:17 PM
valeriymalov committed R530:475211f7887d: Add Wacom Intuos Pro 2 M to device list (authored by Jeff H <nomasteryoda@gmail.com>).
Add Wacom Intuos Pro 2 M to device list
Jun 14 2018, 3:17 PM