valeriymalov (Valeriy Malov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 24 2016, 9:05 AM (116 w, 5 d)
Availability
Available

Recent Activity

Sat, Feb 9

valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • fix ::del error logging criteria, don't return without closing cursor in
Sat, Feb 9, 7:16 PM · Baloo, Frameworks
valeriymalov added inline comments to D18664: Baloo engine: treat every non-success code as a failure.
Sat, Feb 9, 6:09 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • update logging per review
Sat, Feb 9, 6:09 PM · Baloo, Frameworks
valeriymalov updated the diff for D18873: add baloo engine debugging category.

is it now how it's supposed to look in the end? not really sure where .category syntax is defined

Sat, Feb 9, 6:03 PM · Baloo, Frameworks
valeriymalov updated the diff for D18873: add baloo engine debugging category.
  • update categories per review
Sat, Feb 9, 3:10 PM · Baloo, Frameworks
valeriymalov added a dependent revision for D18873: add baloo engine debugging category: D18664: Baloo engine: treat every non-success code as a failure.
Sat, Feb 9, 2:45 PM · Baloo, Frameworks
valeriymalov added a dependency for D18664: Baloo engine: treat every non-success code as a failure: D18873: add baloo engine debugging category.
Sat, Feb 9, 2:45 PM · Baloo, Frameworks
valeriymalov added inline comments to D18873: add baloo engine debugging category.
Sat, Feb 9, 2:30 PM · Baloo, Frameworks
valeriymalov updated the diff for D18873: add baloo engine debugging category.
  • use new syntax for baloo.categories
Sat, Feb 9, 2:30 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
Sat, Feb 9, 1:59 PM · Baloo, Frameworks
valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • clean up rest of the asserts
Sat, Feb 9, 1:56 PM · Baloo, Frameworks
valeriymalov requested review of D18873: add baloo engine debugging category.
Sat, Feb 9, 1:09 PM · Baloo, Frameworks

Sun, Feb 3

valeriymalov planned changes to D18664: Baloo engine: treat every non-success code as a failure.
  1. Are we actually sure this is gonna fix all those crashes? Otherwise I would suggest using CCBUG instead of BUG inside the commit message.

I've chosen those bugs based on backtraces I could get myself but without core dumps I can't vouch for that, even with core dumps it'd be hard to tell. Alternatively I can CCBUG and after this gets into a release, ask in those bugs people if they still experience the crash and close them if they won't get back in a month or so.

  1. For now, logging is the only way to know if there's something bad going on. In that case I would suggest to at least increase severity of those messages - it would increase chances users will notice it. For example, use qCCritical (but this would also require additional check for okayish/non-critical return codes, such as MDB_NOTFOUND)

These errors have good potential to flood users log files. I get around 30 megabytes of those on each boot. I'd rather see them disabled by default.
It might make sense to add a catch-all error message somewhere on higher level, that would get printed out once, but I haven't looked yet where such message could be placed.

  1. Looks like this patch is composed of two parts - introducing new logging category and and improving error handling. It would be also nice to split those into two separate patches.
  2. There are a lot of redundant Q_ASSERT_X left, which could be removed. I suggest just grep'ing over the code to catch'em all. I've started marking them here, but then I gave up - too many of them.
  3. There are also several unchecked return codes as well, such as inside *DB::size() calls. Those can also be found by grep'ing over Q_ASSERT_X.

I'll look into these this week.

Sun, Feb 3, 9:43 PM · Baloo, Frameworks

Sat, Feb 2

valeriymalov updated the diff for D18664: Baloo engine: treat every non-success code as a failure.
  • unbreak documentdatadb::contains, oops :(
Sat, Feb 2, 11:36 AM · Baloo, Frameworks
valeriymalov added a reviewer for D18664: Baloo engine: treat every non-success code as a failure: Baloo.
Sat, Feb 2, 11:27 AM · Baloo, Frameworks
valeriymalov requested review of D18664: Baloo engine: treat every non-success code as a failure.
Sat, Feb 2, 11:26 AM · Baloo, Frameworks

Dec 16 2018

valeriymalov committed R530:14bdd343a7a0: bump version to 3.1.1 (authored by valeriymalov).
bump version to 3.1.1
Dec 16 2018, 4:36 PM

Dec 9 2018

valeriymalov committed R530:35b3f18d6af2: fix Messages.sh target for plasmoid (authored by valeriymalov).
fix Messages.sh target for plasmoid
Dec 9 2018, 5:05 PM
valeriymalov committed R530:3291c95519f0: fix Messages.sh target for plasmoid (authored by valeriymalov).
fix Messages.sh target for plasmoid
Dec 9 2018, 5:05 PM
valeriymalov committed R530:47c26f713763: Minor preparations for new tablet page widget (authored by valeriymalov).
Minor preparations for new tablet page widget
Dec 9 2018, 4:30 PM
valeriymalov committed R530:f51af9cf11a1: Minor tweaks (authored by valeriymalov).
Minor tweaks
Dec 9 2018, 4:29 PM
valeriymalov committed R530:082ae1803949: Add tablet page autotest stub (authored by valeriymalov).
Add tablet page autotest stub
Dec 9 2018, 4:29 PM

Sep 20 2018

valeriymalov committed R530:c2be24a66d47: Fix reading of button mapping in tabletfinder (authored by valeriymalov).
Fix reading of button mapping in tabletfinder
Sep 20 2018, 6:41 PM
valeriymalov committed R530:6ccb10dc4d7b: Update README.md (authored by valeriymalov).
Update README.md
Sep 20 2018, 3:53 PM

Sep 19 2018

valeriymalov committed R530:05a99643e33b: Fix licensing in the file introduced in last commit (authored by valeriymalov).
Fix licensing in the file introduced in last commit
Sep 19 2018, 6:51 PM
valeriymalov committed R530:48ea95790955: ScreenSpace: expand supported types of screen spaces (authored by valeriymalov).
ScreenSpace: expand supported types of screen spaces
Sep 19 2018, 6:47 PM

Sep 12 2018

valeriymalov committed R295:cc4ecfdcd48a: Manually resize KCMUtilDialog to sizeHint() (authored by valeriymalov).
Manually resize KCMUtilDialog to sizeHint()
Sep 12 2018, 2:20 AM
valeriymalov closed D15406: Manually resize KCMUtilDialog to sizeHint().
Sep 12 2018, 2:20 AM · Frameworks

Sep 11 2018

valeriymalov added a comment to D15406: Manually resize KCMUtilDialog to sizeHint().

neither QWidget::adjustSize() nor QWidget::adjustedSize() seem to use devicePixelRatio (https://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/kernel/qwidget.cpp#n8665), but I can't test that to vouch that it works on HiDPI as intended
I can land it as is but I don't really want to break kcmshell further for HiDPI users

Sep 11 2018, 1:42 PM · Frameworks

Sep 10 2018

acrouthamel awarded D15406: Manually resize KCMUtilDialog to sizeHint() a Like token.
Sep 10 2018, 3:02 PM · Frameworks
valeriymalov requested review of D15406: Manually resize KCMUtilDialog to sizeHint().
Sep 10 2018, 2:46 PM · Frameworks

Sep 5 2018

valeriymalov committed R473:2d73d5f25a1a: Fix memory corruption in ScanFolder plugin (authored by valeriymalov).
Fix memory corruption in ScanFolder plugin
Sep 5 2018, 6:07 PM
valeriymalov closed D15265: Fix memory corruption in ScanFolder plugin.

Landed it on 5.1, messed up with arc so it didn't close the diff
https://cgit.kde.org/ktorrent.git/commit/?id=2d73d5f25a1a364a2115fb1d3262377f7fdf99cd

Sep 5 2018, 5:54 PM

Sep 4 2018

valeriymalov added a comment to D15265: Fix memory corruption in ScanFolder plugin.

Backtraces are a bit inconsistent, usually it ends with malloc aborting with invalid porinter or other memory error

Sep 4 2018, 9:55 PM
valeriymalov updated the diff for D15265: Fix memory corruption in ScanFolder plugin.
  • fix typo
Sep 4 2018, 9:25 PM
valeriymalov requested review of D15265: Fix memory corruption in ScanFolder plugin.
Sep 4 2018, 11:59 AM

Sep 3 2018

valeriymalov committed R530:d21699e98bc6: Minor fixes (authored by valeriymalov).
Minor fixes
Sep 3 2018, 5:23 PM

Aug 28 2018

valeriymalov added inline comments to D3484: Center systemmonitor window properly on multi-screen setup.
Aug 28 2018, 12:18 AM · Plasma

Aug 13 2018

valeriymalov committed R295:23ba2b37ef82: Use custom QScrollArea with size hint not limited by font size (authored by valeriymalov).
Use custom QScrollArea with size hint not limited by font size
Aug 13 2018, 9:00 AM
valeriymalov closed D14692: Use custom QScrollArea with size hint not limited by font size.
Aug 13 2018, 9:00 AM · Frameworks

Aug 12 2018

valeriymalov added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

I don't know, it's frameworks after all but I guess I can land it today since it's a popular bug. Should I just land it on master since there seem to be no other branches?

Aug 12 2018, 11:19 AM · Frameworks

Aug 8 2018

valeriymalov updated the diff for D14692: Use custom QScrollArea with size hint not limited by font size.
  • add link to qt bug
Aug 8 2018, 1:44 PM · Frameworks
valeriymalov added a comment to D14692: Use custom QScrollArea with size hint not limited by font size.

I think it's this bug/suggestion: https://bugreports.qt.io/browse/QTBUG-10459

Aug 8 2018, 1:30 PM · Frameworks
valeriymalov added a reviewer for D14692: Use custom QScrollArea with size hint not limited by font size: Frameworks.

Context for the size hint limitation this patch is supposed to circumvent: https://code.woboq.org/qt5/qtbase/src/widgets/widgets/qscrollarea.cpp.html#403

Aug 8 2018, 12:38 PM · Frameworks
valeriymalov requested review of D14692: Use custom QScrollArea with size hint not limited by font size.
Aug 8 2018, 12:35 PM · Frameworks

Jul 19 2018

valeriymalov committed R530:978bd40e0e2f: Fix spelling error in kded plugin (authored by scarlettclark).
Fix spelling error in kded plugin
Jul 19 2018, 6:58 PM
valeriymalov committed R530:ecb23d7824ba: Make tabs scrollable (authored by valeriymalov).
Make tabs scrollable
Jul 19 2018, 2:04 PM

Jul 14 2018

valeriymalov committed R530:f5c83ca5013c: Replace saveprofile.ui with KMessageBox (authored by valeriymalov).
Replace saveprofile.ui with KMessageBox
Jul 14 2018, 2:27 PM

Jul 12 2018

valeriymalov committed R530:781452ca93cd: Clean up StylusPageWidget and PressureCurveDialog interaction (authored by valeriymalov).
Clean up StylusPageWidget and PressureCurveDialog interaction
Jul 12 2018, 6:36 PM
valeriymalov committed R530:303f9b6d8871: Make KCM pages a bit more test-friendly (authored by valeriymalov).
Make KCM pages a bit more test-friendly
Jul 12 2018, 5:24 PM
valeriymalov committed R530:b9c84bd9e7cf: Un-pimpl styluspagewidget, add second test stub (authored by valeriymalov).
Un-pimpl styluspagewidget, add second test stub
Jul 12 2018, 4:13 PM

Jul 6 2018

valeriymalov committed R530:5a946f72d1da: Fix TestTabletHandler (authored by valeriymalov).
Fix TestTabletHandler
Jul 6 2018, 2:23 PM
valeriymalov committed R530:de2c52307a24: Add "Configure" button on the "new tablet" notification popup (authored by valeriymalov).
Add "Configure" button on the "new tablet" notification popup
Jul 6 2018, 2:22 PM

Jul 4 2018

valeriymalov committed R658:8332ffe800d9: Add .gitignore (authored by valeriymalov).
Add .gitignore
Jul 4 2018, 6:35 PM
valeriymalov committed R658:443e0e3a639a: add some X-KDE-Keywords for search in system settings (authored by valeriymalov).
add some X-KDE-Keywords for search in system settings
Jul 4 2018, 6:35 PM

Jun 29 2018

valeriymalov committed R530:2f45395d6889: Add basic test for stylus page settings persistency. (authored by valeriymalov).
Add basic test for stylus page settings persistency.
Jun 29 2018, 6:51 PM

Jun 28 2018

valeriymalov committed R530:ac06c96043e9: Initial setup for KCM testing (authored by valeriymalov).
Initial setup for KCM testing
Jun 28 2018, 5:45 PM

Jun 27 2018

valeriymalov committed R530:6f34b768b4e0: Buttons 6 and 7 are mouse wheel left/right (authored by valeriymalov).
Buttons 6 and 7 are mouse wheel left/right
Jun 27 2018, 3:27 PM
valeriymalov committed R530:adbf24fbdb6d: Fix pressure curve widget being too sticky (authored by valeriymalov).
Fix pressure curve widget being too sticky
Jun 27 2018, 1:03 PM

Jun 14 2018

valeriymalov committed R530:190ca9735ae0: Add Wacom Intuos Pro 2 M to device list (authored by Jeff H <nomasteryoda@gmail.com>).
Add Wacom Intuos Pro 2 M to device list
Jun 14 2018, 3:17 PM
valeriymalov committed R530:475211f7887d: Add Wacom Intuos Pro 2 M to device list (authored by Jeff H <nomasteryoda@gmail.com>).
Add Wacom Intuos Pro 2 M to device list
Jun 14 2018, 3:17 PM

Jun 4 2018

valeriymalov committed R247:fa7564b4ec3c: wacomtablet stable branch switched from 3.0 to 3.1 (authored by valeriymalov).
wacomtablet stable branch switched from 3.0 to 3.1
Jun 4 2018, 6:31 PM
valeriymalov committed R530:c407d990f7cd: TabletDatabase: Add a version of `lookupTablet` which requires companyId (authored by jgerecke).
TabletDatabase: Add a version of `lookupTablet` which requires companyId
Jun 4 2018, 5:31 PM
valeriymalov closed D12645: TabletDatabase: Add a version of `lookupTablet` which requires companyId.
Jun 4 2018, 5:31 PM
valeriymalov committed R530:c417c9e0f035: bump version to 3.1.0 (authored by valeriymalov).
bump version to 3.1.0
Jun 4 2018, 4:58 PM
valeriymalov committed R530:774744c0984e: Minor fixes (authored by valeriymalov).
Minor fixes
Jun 4 2018, 3:43 PM
valeriymalov committed R530:ad8b411655e5: libwacomwrapper: Calculate a better StatusLEDs value (authored by jgerecke).
libwacomwrapper: Calculate a better StatusLEDs value
Jun 4 2018, 3:30 PM
valeriymalov closed D12646: libwacomwrapper: Calculate a better StatusLEDs value.
Jun 4 2018, 3:30 PM

Jun 3 2018

valeriymalov accepted D12645: TabletDatabase: Add a version of `lookupTablet` which requires companyId.

Looks good, works, thanks

Jun 3 2018, 12:57 PM
valeriymalov accepted D12646: libwacomwrapper: Calculate a better StatusLEDs value.

I have a couple of nitpicks, but otherwise it should be good, thanks!

Jun 3 2018, 12:26 PM

Jun 1 2018

valeriymalov committed R530:3d5f745a7e5d: move README to markdown (authored by valeriymalov).
move README to markdown
Jun 1 2018, 5:16 PM

May 29 2018

valeriymalov committed R530:15a27bb26443: Fix a bunch of klazy warnings (authored by valeriymalov).
Fix a bunch of klazy warnings
May 29 2018, 5:29 PM
valeriymalov committed R530:47953dce807b: Add tablet mapping basic fine tuning (authored by valeriymalov).
Add tablet mapping basic fine tuning
May 29 2018, 2:52 PM

May 21 2018

valeriymalov committed R530:de4bd0bce1aa: Implement "Lock propotions" option for tablet mapping screen (authored by valeriymalov).
Implement "Lock propotions" option for tablet mapping screen
May 21 2018, 11:38 AM

May 20 2018

valeriymalov committed R530:319a7bb32779: tabletfinder: support for devices with separate touch (authored by valeriymalov).
tabletfinder: support for devices with separate touch
May 20 2018, 4:28 PM
valeriymalov committed R530:6049677410d2: Open calibration dialogue on the calibrated screen (authored by valeriymalov).
Open calibration dialogue on the calibrated screen
May 20 2018, 10:39 AM
valeriymalov committed R530:4df75b40d433: Prevent global hotkeys from making increased number of calls every press (authored by valeriymalov).
Prevent global hotkeys from making increased number of calls every press
May 20 2018, 10:30 AM
valeriymalov added a comment to D12970: Fixed grammar issue.

@ssaxena for future patches, please configure your git to use full name in the author field

May 20 2018, 9:29 AM
valeriymalov committed R530:2627742156f6: Fixed grammar issue (authored by ssaxena).
Fixed grammar issue
May 20 2018, 9:27 AM
valeriymalov closed D12970: Fixed grammar issue.
May 20 2018, 9:27 AM

May 19 2018

valeriymalov committed R530:11f8e8b85e52: Save ::Rotate property on touch tab (authored by valeriymalov).
Save ::Rotate property on touch tab
May 19 2018, 8:50 PM
valeriymalov committed R530:e70dd80f5e36: Merge devices that have different USB ID for touch in the KCM (authored by valeriymalov).
Merge devices that have different USB ID for touch in the KCM
May 19 2018, 4:38 PM
valeriymalov accepted D12970: Fixed grammar issue.

English is not my first langauge, so I'll trust you on this one :v
Looks good to land, or I can land it for you

May 19 2018, 10:49 AM

May 18 2018

valeriymalov committed R530:b21db5e74395: DeviceType: don't downgrade from strict enum to string (authored by valeriymalov).
DeviceType: don't downgrade from strict enum to string
May 18 2018, 7:58 PM

May 17 2018

valeriymalov committed R530:5eef6364ede0: Fix some Cintiq related calibration issues (authored by valeriymalov).
Fix some Cintiq related calibration issues
May 17 2018, 2:00 PM

May 16 2018

valeriymalov committed R128:1ffbcb72ee53: Merge remote-tracking branch 'origin/Plasma/5.12' (authored by valeriymalov).
Merge remote-tracking branch 'origin/Plasma/5.12'
May 16 2018, 4:03 PM
valeriymalov committed R128:ff88e24e4380: Split replaceAccount from addAccountToCache (authored by valeriymalov).
Split replaceAccount from addAccountToCache
May 16 2018, 4:01 PM
valeriymalov closed D12837: Split replaceAccount from addAccountToCache.
May 16 2018, 4:01 PM · Plasma
valeriymalov added a comment to D12837: Split replaceAccount from addAccountToCache.

I meant it more in terms of "not landing it right before next stable release" :v But if it's okay to land now I can land it right now

May 16 2018, 3:52 PM · Plasma
valeriymalov added a comment to D12837: Split replaceAccount from addAccountToCache.

Any chance we could land this on the stable branch?

May 16 2018, 3:42 PM · Plasma

May 15 2018

valeriymalov added inline comments to D12837: Split replaceAccount from addAccountToCache.
May 15 2018, 1:13 PM · Plasma
valeriymalov added a comment to D12837: Split replaceAccount from addAccountToCache.

We have addAccountToCache which has an argument pos, which determines if we're adding or replacing.

I've actually removed this bit, addAccountToCache now only adds accounts (either inserts at pos or appends)

May 15 2018, 10:29 AM · Plasma

May 14 2018

valeriymalov committed R530:710406d7fce3: Basic support for status LED brightness (authored by vtasoulas).
Basic support for status LED brightness
May 14 2018, 3:25 PM
valeriymalov committed R530:869f3c1b0fd6: Updated the status led paths according to the Linux kernel documentation (authored by vtasoulas).
Updated the status led paths according to the Linux kernel documentation
May 14 2018, 11:30 AM
valeriymalov committed R530:4480c77c6154: Add kdebugsettings categories (authored by valeriymalov).
Add kdebugsettings categories
May 14 2018, 11:30 AM

May 12 2018

valeriymalov requested review of D12837: Split replaceAccount from addAccountToCache.
May 12 2018, 3:38 PM · Plasma

May 9 2018

valeriymalov committed R530:bf388efedf81: Fix uinput detection, fix some clang warnings (authored by valeriymalov).
Fix uinput detection, fix some clang warnings
May 9 2018, 9:53 PM
valeriymalov committed R530:f10de06f2a5a: Check for modern uinput API availability (authored by valeriymalov).
Check for modern uinput API availability
May 9 2018, 8:45 PM

May 7 2018

valeriymalov committed R530:1e7dc6b8f067: TestButtonShortcut: split tests and test data (authored by valeriymalov).
TestButtonShortcut: split tests and test data
May 7 2018, 12:26 PM

May 5 2018

valeriymalov accepted D12705: Fix autotests on FreeBSD.

Thanks, looks OK

May 5 2018, 8:54 PM