add baloo engine debugging category
AcceptedPublic

Authored by valeriymalov on Sat, Feb 9, 1:09 PM.

Details

Reviewers
mlaurent
bruns
Group Reviewers
Baloo

Diff Detail

Repository
R293 Baloo
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8086
Build 8104: arc lint + arc unit
valeriymalov created this revision.Sat, Feb 9, 1:09 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptSat, Feb 9, 1:09 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
valeriymalov requested review of this revision.Sat, Feb 9, 1:09 PM
mlaurent requested changes to this revision.Sat, Feb 9, 2:28 PM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
baloo.categories
4

Please use new syntax see previous line.

src/engine/CMakeLists.txt
31

which files uses it ?
you generate it but it seems that you don't use it in file no ?

This revision now requires changes to proceed.Sat, Feb 9, 2:28 PM
  • use new syntax for baloo.categories
valeriymalov marked an inline comment as done.Sat, Feb 9, 2:30 PM
valeriymalov added inline comments.
src/engine/CMakeLists.txt
31
mlaurent accepted this revision.Sat, Feb 9, 2:35 PM

Ok so you need to commit this one first and making second patch dependancy against it.

This revision is now accepted and ready to land.Sat, Feb 9, 2:35 PM
bruns requested changes to this revision.Sat, Feb 9, 3:08 PM
bruns added a subscriber: bruns.
bruns added inline comments.
baloo.categories
4

description "Baloo engine debug" -> "Baloo Engine"
identifier "Baloo::ENGINE"

This revision now requires changes to proceed.Sat, Feb 9, 3:08 PM
  • update categories per review

Baloo::ENGINE it's wrong as you generate it as "IDENTIFIER "ENGINE" CATEGORY_NAME "org.kde.baloo.engine")"
it's not Baloo::ENGINE but ENGINE

so you need to change IDENTIFIER "ENGINE" in ecm_qt_declare_logging_category(

DEFAULT_SEVERITY [WARNING] is false too as you don't force it.

bruns added a comment.Sat, Feb 9, 3:17 PM

DEFAULT_SEVERITY [WARNING] is false too as you don't force it.

i.e. add "DEFAULT_SEVERITY Warning" in ecm_qt_declare_logging_category
compare with https://phabricator.kde.org/source/baloo/browse/master/src/kioslaves/timeline/CMakeLists.txt

ecm_qt_declare_logging_category(kio_timeline_SRCS

	                                HEADER kio_timeline_debug.h
	                                IDENTIFIER Baloo::KIO_TIMELINE
	                                DEFAULT_SEVERITY Warning
	                                CATEGORY_NAME kf5.kio.kio_timeline

yep you force DEFAULT_SEVERITY Warning

here ;ecm_qt_declare_logging_category(

BALOO_ENGINE_SRCS
HEADER "enginedebug.h"

IDENTIFIER "ENGINE"

CATEGORY_NAME "org.kde.baloo.engine")

I don't see where you force DEFAULT_SEVERITY here :)

is it now how it's supposed to look in the end? not really sure where .category syntax is defined

bruns added a comment.Sat, Feb 9, 7:19 PM

Looks good to me. @mlaurent ?

mlaurent accepted this revision.Sun, Feb 10, 8:53 AM

Now it's ok for me :)
Thanks

bruns accepted this revision.Sun, Feb 10, 4:35 PM
This revision is now accepted and ready to land.Sun, Feb 10, 4:35 PM