Baloo engine: treat every non-success code as a failure
eb68430ae5f4
Actions

Authored by valeriymalov on Mar 10 2019, 5:19 PM.

Description

Baloo engine: treat every non-success code as a failure

Summary:
Treating only MDB_NOTFOUND as an error leads to use of uninitliazed
pointers and handle IDs in other cases (e.g. when get fails with
MDB_BAD_TXN) and wreaks havoc in the application.

CCBUG: 361186
CCBUG: 390823
CCBUG: 372880
CCBUG: 395888
CCBUG: 367480
CCBUG: 403720

Reviewers: Baloo, bruns, poboiko

Reviewed By: Baloo, bruns

Subscribers: cullmann, ngraham, bruns, kde-frameworks-devel, Baloo

Tags: Frameworks, Baloo

Differential Revision: https://phabricator.kde.org/D18664

Details

Committed

valeriymalov

Mar 13 2019, 9:50 PM

Reviewer

Baloo

Differential Revision

D18664: Baloo engine: treat every non-success code as a failure

Parents

R293:f2d14fff7667: GIT_SILENT Upgrade KF5 version to 5.57.0.

Branches

Unknown

Tags

Unknown

Changes (21)

				Path	Packages
	M			src/engine/database.cpp
	M			src/engine/documentdatadb.cpp
	M			src/engine/documentdb.cpp
	M			src/engine/documentiddb.cpp
	M			src/engine/documenttimedb.cpp
	M			src/engine/documenturldb.cpp
	M			src/engine/documenturldb.h
	M			src/engine/fsutils.cpp
	M			src/engine/idfilenamedb.cpp
	M			src/engine/idtreedb.cpp
	M			src/engine/mtimedb.cpp
	M			src/engine/phraseanditerator.cpp
	M			src/engine/positiondb.cpp
	M			src/engine/postingdb.cpp
	M			src/engine/transaction.cpp
	M			src/engine/transaction.h
	M			src/file/extractorprocess.cpp
	M			src/file/fileindexscheduler.cpp
	M			src/file/indexcleaner.cpp
	M			src/file/main.cpp
	M			src/file/metadatamover.cpp