Cleanup ViewModel a bit and try to fix crash on exit
ClosedPublic
Actions

Authored by valeriymalov on Sep 22 2019, 6:32 PM.

Details

Reviewers

Commits

R473:b819ef6a3549: Cleanup ViewModel a bit and try to fix crash on exit

Summary

removeTorrent makes changes to torrent list we are currently iterating
on per-item basis, this causees heap-use-after-free in onExit
Just call removeRows which should be functionally the same, but should
delete all items in one batch

CCBUG: 383127

Compact ViewModel::Item::update
Fix a few warnings (0 as nullptr, c-style casts)
Remove useless ViewModel::torrentFromIndex variant
Remove unused headers
add CMakeLists.txt.user to gitignore

Test Plan

build with asan, run & exit, see asan stacktrace before changing onExit

Diff Detail

Repository

R473 KTorrent

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

valeriymalov requested review of this revision.Sep 22 2019, 6:32 PM

valeriymalov created this revision.

Harbormaster completed remote builds in B16891: Diff 66629.Sep 22 2019, 6:32 PM

stikonas accepted this revision.Sep 22 2019, 9:30 PM

This revision is now accepted and ready to land.Sep 22 2019, 9:30 PM

Should I land it on master or it seems good enough for the stable branch?

In D24149#536863, @valeriymalov wrote:

Should I land it on master or it seems good enough for the stable branch?

I don't have a strong opinion on this but maybe stable? I neever observed crash on exit but a lot of other people complained. Otherwise, it might take a long time for a fix to reach them.

Closed by commit R473:b819ef6a3549: Cleanup ViewModel a bit and try to fix crash on exit (authored by valeriymalov). · Explain WhySep 29 2019, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			.gitignore (1 line)
M			ktorrent/CMakeLists.txt (1 line)
M			ktorrent/view/viewmodel.h (21 lines)
M			ktorrent/view/viewmodel.cpp (197 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66629	e5b9fa8		Sep 22 2019, 6:32 PM	★	★
Diff 2	67044	bb3c4d6	R473:b819ef6a35495e12a204cbb241cdb2502c4cd11e	Sep 29 2019, 8:31 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8cb2ee507917	93341b9955a0	43ceee7c9773	Valerii Malov	add CMakeLists.txt.user to gitignore	Sep 22 2019, 6:29 PM
43ceee7c9773	daf13ac38af3	e60c85ef9573	Valerii Malov	ViewModel: avoid calling removeTorrent in onExit (Show More…)	Sep 22 2019, 6:26 PM
e60c85ef9573	fe86b634f7d7	e5b9fa8afded	Valerii Malov	Cleanup ViewModel a bit (Show More…)	Sep 22 2019, 6:20 PM