Rewrite the taglib extractor to use the generic PropertyMap interface
Needs ReviewPublic

Authored by astippich on Thu, Feb 7, 8:05 PM.

Details

Summary

Rewrite the taglib extractor to use taglib's
PropertyMap. Since this largely unifies the handling of the
different tag formats, but not quite, a lot of code is removed.
The resulting code is also faster. Additionally, this avoids the
usage of a FileRef object, which fixes a potential crash due to
a known bug in taglib.

BUG: 403902

Test Plan

all tests pass

Diff Detail

Repository
R286 KFileMetaData
Branch
rewrite_taglib_extractor
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8001
Build 8019: arc lint + arc unit
astippich created this revision.Thu, Feb 7, 8:05 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptThu, Feb 7, 8:05 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Thu, Feb 7, 8:05 PM
astippich edited the test plan for this revision. (Show Details)Thu, Feb 7, 8:06 PM

ping. I know this is quite a large diff, but it fixes a potential crash