User Details
User Details
- User Since
- Jun 6 2016, 9:59 AM (412 w, 22 h)
- Availability
- Available
Sep 26 2016
Sep 26 2016
Undo rename of KisGrbBrush
nishantjr added a reverting change for R37:3f7612734074: Rename KisGbrBrus to KisGimpBrush for clarity: R37:f1657cb30207: Undo rename of KisGrbBrush.
Sep 25 2016
Sep 25 2016
nishantjr committed R37:3f7612734074: Rename KisGbrBrus to KisGimpBrush for clarity (authored by nishantjr).
Rename KisGbrBrus to KisGimpBrush for clarity
nishantjr committed R37:23283fc45d7b: Q_DECL_OVERRIDE -> override for consistency (authored by nishantjr).
Q_DECL_OVERRIDE -> override for consistency
nishantjr committed R37:353d0af7733d: KisBrush: Remove unneeded friend declarations (authored by nishantjr).
KisBrush: Remove unneeded friend declarations
nishantjr committed R37:4aca7d30ea56: Remove commented KisGbrBrush::outline (authored by nishantjr).
Remove commented KisGbrBrush::outline
nishantjr committed R37:17123d751fae: Rename KisBrushTest -> KisGrbBrushTest (authored by nishantjr).
Rename KisBrushTest -> KisGrbBrushTest
nishantjr committed R37:c7f61f1772f1: Rename *Autobrush* -> AutoBrush for consistency (authored by nishantjr).
Rename *Autobrush* -> AutoBrush for consistency
nishantjr committed R37:317f4413b522: KisBrush::characteristicSize: Fix use of shape.scaleY instead of ratio (authored by nishantjr).
KisBrush::characteristicSize: Fix use of shape.scaleY instead of ratio
Sep 19 2016
Sep 19 2016
nishantjr committed R37:386841275b16: KisAutoBrush: override maskWidth and characteristicSize too (authored by nishantjr).
KisAutoBrush: override maskWidth and characteristicSize too
nishantjr committed R37:bc3fc56d67b4: Merge branch 'nishant/autobrush-ratio-option-clipping' (authored by nishantjr).
Merge branch 'nishant/autobrush-ratio-option-clipping'
nishantjr committed R37:eaaa0a9f5e46: KisBrush: characteristicSize: take ratio into account (authored by nishantjr).
KisBrush: characteristicSize: take ratio into account
nishantjr committed R37:23e9f7567b58: kis_memory_pool_test: TestingClass make dummy member public to workaround… (authored by nishantjr).
kis_memory_pool_test: TestingClass make dummy member public to workaround…
nishantjr committed R37:038d1e4f3648: KoToolBase, KoShape, KoPatternBackground: Remove unused Q_Ds (authored by nishantjr).
KoToolBase, KoShape, KoPatternBackground: Remove unused Q_Ds
nishantjr committed R37:2c3e509c2f7c: KoStreamedMath: clearPixel, copyPixel: Fail at link time instead of runtime… (authored by nishantjr).
KoStreamedMath: clearPixel, copyPixel: Fail at link time instead of runtime…
nishantjr committed R37:dbe4cca86302: KMainWindow: Remove deprecated register keyword (authored by nishantjr).
KMainWindow: Remove deprecated register keyword
nishantjr committed R37:e29253a15569: libs/store/KoXmlReader.cpp:140:20: error: unused function qHash [-Werror… (authored by nishantjr).
libs/store/KoXmlReader.cpp:140:20: error: unused function qHash [-Werror…
Aug 30 2016
Aug 30 2016
nishantjr committed R37:1b43dde6d098: KisAutoBrush: override maskWidth and characteristicSize too (authored by nishantjr).
KisAutoBrush: override maskWidth and characteristicSize too
nishantjr committed R37:c3f6a27b7d32: KisBrush: characteristicSize: take ratio into account (authored by nishantjr).
KisBrush: characteristicSize: take ratio into account
nishantjr committed R37:d80a7ebd7d4c: KoToolBase, KoShape, KoPatternBackground: Remove unused Q_Ds (authored by nishantjr).
KoToolBase, KoShape, KoPatternBackground: Remove unused Q_Ds
nishantjr committed R37:76f6c825ad71: kis_memory_pool_test: TestingClass make dummy member public to workaround… (authored by nishantjr).
kis_memory_pool_test: TestingClass make dummy member public to workaround…
nishantjr committed R37:a5c9bbffd7fb: KoStreamedMath: clearPixel, copyPixel: Fail at link time instead of runtime… (authored by nishantjr).
KoStreamedMath: clearPixel, copyPixel: Fail at link time instead of runtime…
nishantjr committed R37:f149c2736ed1: KMainWindow: Remove deprecated register keyword (authored by nishantjr).
KMainWindow: Remove deprecated register keyword
nishantjr committed R37:f6f3e6a26e70: libs/store/KoXmlReader.cpp:140:20: error: unused function qHash [-Werror… (authored by nishantjr).
libs/store/KoXmlReader.cpp:140:20: error: unused function qHash [-Werror…
Aug 16 2016
Aug 16 2016
nishantjr committed R37:ffc4d9cf102a: Merge branch 'nishant/ratio-option-skewing/366030' (authored by nishantjr).
Merge branch 'nishant/ratio-option-skewing/366030'
nishantjr committed R37:61c422b9ad25: KisQImagePyramid: Peform scale before transform to prevent skewing of DABs (authored by nishantjr).
KisQImagePyramid: Peform scale before transform to prevent skewing of DABs
nishantjr retitled D2463: KisQImagePyramid: Peform scale before transform to prevent skewing of DABs from to KisQImagePyramid: Peform scale before transform to prevent skewing of DABs.
nishantjr committed R37:1d8e3e920923: KisQImagePyramid: baseBrushTransform: Peform scale before transform (authored by nishantjr).
KisQImagePyramid: baseBrushTransform: Peform scale before transform
Jul 23 2016
Jul 23 2016
Merge branch 'nishant/ratio-option'
nishantjr closed T2826: Bind ratio to the sensor system as Resolved by committing R37:9d183892ade9: Merge branch 'nishant/ratio-option'.
nishantjr added a comment to D1818: Create KisPressureRatioOption and integrate it with the pixel brush..
Hey @dkazakov
Just confirmed that it's working with the basic_circle brush too, here.
Please check that you have this commit as part of your build:
nishantjr added a comment to D1818: Create KisPressureRatioOption and integrate it with the pixel brush..
Hey Dmitry,
Jul 22 2016
Jul 22 2016
nishantjr committed R37:703acc9dfc99: KisSpacingInformation: Remove redundant isIsotropic member. (authored by nishantjr).
KisSpacingInformation: Remove redundant isIsotropic member.
nishantjr committed R37:606b33652b48: KisMaskGenerator::effectiveSrcHeight: Use scaleY instead of scaleX (authored by nishantjr).
KisMaskGenerator::effectiveSrcHeight: Use scaleY instead of scaleX
nishantjr added a comment to D1818: Create KisPressureRatioOption and integrate it with the pixel brush..
Hi Dmitry, Boud,
Jul 21 2016
Jul 21 2016
nishantjr committed R37:432003fb1c15: KisAutoBrush: override maskHeight so we get a more appropriate value when… (authored by nishantjr).
KisAutoBrush: override maskHeight so we get a more appropriate value when…
nishantjr committed R37:b6f2f4038e5f: KisGaussCircleMaskGenerator: update ycoef when scale changes (authored by nishantjr).
KisGaussCircleMaskGenerator: update ycoef when scale changes
nishantjr committed R37:28db9864db90: QImagePyramid: Correctly take into account ratio (authored by nishantjr).
QImagePyramid: Correctly take into account ratio
nishantjr committed R37:bacb4d999540: KisBrushOp: Add ratioOption to KisBrush and pass ratio to DabCache (authored by nishantjr).
KisBrushOp: Add ratioOption to KisBrush and pass ratio to DabCache
nishantjr committed R37:f24b30e6c0f5: AutoBrushTest: Extract function dabSizeHelper to peform repeated test logic. (authored by nishantjr).
AutoBrushTest: Extract function dabSizeHelper to peform repeated test logic.
nishantjr committed R37:d80c80a31058: Fix transformation being applied twice in DeformBrush (authored by nishantjr).
Fix transformation being applied twice in DeformBrush
nishantjr committed R37:b36803841c45: KisDabShape: convenience class for grouping scale, ratio and rotation. (authored by nishantjr).
KisDabShape: convenience class for grouping scale, ratio and rotation.
nishantjr committed R37:93f2ab2044ae: Add Q_DECL_OVERRIDE to appropriate members of KisBrush (authored by nishantjr).
Add Q_DECL_OVERRIDE to appropriate members of KisBrush
nishantjr committed R37:85ed3d088b39: Make member function static. It wasn't using any class members. (authored by nishantjr).
Make member function static. It wasn't using any class members.
nishantjr committed R37:ea7813916aac: Paintops::brushOutline(): Extract function makeTiltIndicator (authored by nishantjr).
Paintops::brushOutline(): Extract function makeTiltIndicator
Jul 14 2016
Jul 14 2016
nishantjr added a comment to D1818: Create KisPressureRatioOption and integrate it with the pixel brush..
OK, noted. Thanks for taking the time to explain things. Could you point
out the location in the code where KisQImagePyramid's sampling algorithm is
implemented?
Jul 13 2016
Jul 13 2016
nishantjr committed R37:b056758cca31: KisAutoBrush: When generating mask, don't try to predict the width from scaleY (authored by nishantjr).
KisAutoBrush: When generating mask, don't try to predict the width from scaleY
nishantjr committed R37:f295b9cb15d2: KisBaseMaskGenerator: effectiveSrcWidth: Use ScaleY instead of scaleX (authored by nishantjr).
KisBaseMaskGenerator: effectiveSrcWidth: Use ScaleY instead of scaleX
nishantjr committed R37:62a120bc2eab: KisBrush: ratio option in paintdevice... (authored by nishantjr).
KisBrush: ratio option in paintdevice...
nishantjr committed R37:79f8e32f44f3: Revert "fixup! KisDabCache: Merge fetchDabCommon and postProcessDab" (authored by nishantjr).
Revert "fixup! KisDabCache: Merge fetchDabCommon and postProcessDab"
nishantjr committed R37:c4a9f665fd05: Revert "KisDabCache: Merge fetchDabCommon and postProcessDab" (authored by nishantjr).
Revert "KisDabCache: Merge fetchDabCommon and postProcessDab"
nishantjr committed R37:5dd03fb372c0: Create KisPressureRatioOption and integrate it with the pixel brush. (authored by nishantjr).
Create KisPressureRatioOption and integrate it with the pixel brush.
nishantjr committed R37:e7e28c674653: fixup! KisDabCache: Merge fetchDabCommon and postProcessDab (authored by nishantjr).
fixup! KisDabCache: Merge fetchDabCommon and postProcessDab
nishantjr committed R37:85dd91239176: KisDabCache: Take 'scale' and 'ratio' instead of 'scaleX' and 'scaleY' (authored by nishantjr).
KisDabCache: Take 'scale' and 'ratio' instead of 'scaleX' and 'scaleY'
nishantjr committed R37:d024312caba5: KisDabCache: Merge fetchDabCommon and postProcessDab (authored by nishantjr).
KisDabCache: Merge fetchDabCommon and postProcessDab
nishantjr committed R37:a37de56324f1: KisQImagePyramid: merge calculateParams and imageSize (authored by nishantjr).
KisQImagePyramid: merge calculateParams and imageSize
nishantjr committed R37:c74302635198: KisQImagePyramid::calculateParams: Remove commented code (that doesn't compile) (authored by nishantjr).
KisQImagePyramid::calculateParams: Remove commented code (that doesn't compile)
nishantjr committed R37:65e4b96c0d22: KisQImagePyramid::calculateParams: Remove unused output parameter… (authored by nishantjr).
KisQImagePyramid::calculateParams: Remove unused output parameter…
nishantjr committed R37:fdcc179b6e7c: KisQImagePyramid::calculateParams: merge identical (except unused params)… (authored by nishantjr).
KisQImagePyramid::calculateParams: merge identical (except unused params)…
nishantjr committed R37:dcf4d3328283: KisQImagePyramid: Remove unused functions and related tests (authored by nishantjr).
KisQImagePyramid: Remove unused functions and related tests
Jul 12 2016
Jul 12 2016
nishantjr added a comment to D1818: Create KisPressureRatioOption and integrate it with the pixel brush..
Also, let me know if you want me to add those patches to Differential.
nishantjr added a comment to D1818: Create KisPressureRatioOption and integrate it with the pixel brush..
@rempt Sorry about taking so much time about this.
nishantjr committed R37:e98844e6ac44: Implement ratio option for paintDevice based brushes. (authored by nishantjr).
Implement ratio option for paintDevice based brushes.
nishantjr committed R37:8f475cba50f4: KisAutoBrush: When generating mask, don't try to predict the width from scaleY (authored by nishantjr).
KisAutoBrush: When generating mask, don't try to predict the width from scaleY
nishantjr committed R37:de649448372d: KisBaseMaskGenerator: effectiveSrcWidth: Use ScaleY instead of scaleX (authored by nishantjr).
KisBaseMaskGenerator: effectiveSrcWidth: Use ScaleY instead of scaleX
nishantjr committed R37:1bdfc2504218: KisBrushOp: Take ratio into account when calculating spacing. (authored by nishantjr).
KisBrushOp: Take ratio into account when calculating spacing.
nishantjr committed R37:5d484c56e3a8: Create KisPressureRatioOption and integrate it with the pixel brush. (authored by nishantjr).
Create KisPressureRatioOption and integrate it with the pixel brush.
nishantjr committed R37:565ef3575897: ----- The next few commits implement the ratio option for AutoBrush ----- (authored by nishantjr).
----- The next few commits implement the ratio option for AutoBrush -----
nishantjr committed R37:ba504c151854: KisBrushTest: Add helper for printing images as ASCII art. (authored by nishantjr).
KisBrushTest: Add helper for printing images as ASCII art.
nishantjr committed R37:404a05b1c112: KisDabCache: Take 'scale' and 'ratio' instead of 'scaleX' and 'scaleY' (authored by nishantjr).
KisDabCache: Take 'scale' and 'ratio' instead of 'scaleX' and 'scaleY'
nishantjr committed R37:e2081ede3c09: KisBrush: Use HighQualityAntialiasing to get around QPainter bug. (authored by nishantjr).
KisBrush: Use HighQualityAntialiasing to get around QPainter bug.
nishantjr committed R37:8e77267b9aee: KisBrush: Copy work-around for sub-pixel translations to KisBrush (authored by nishantjr).
KisBrush: Copy work-around for sub-pixel translations to KisBrush
nishantjr committed R37:cc1dc3a81762: Remove brushPyramid from the KisBrush. (authored by nishantjr).
Remove brushPyramid from the KisBrush.
nishantjr committed R37:75058d4d9c7e: ----- Commits upto this point are purely refactoring ----- (authored by nishantjr).
----- Commits upto this point are purely refactoring -----
nishantjr committed R37:2a1d081bcafe: KisBrush::mask: Move if condition closer to where it's used for readablility (authored by nishantjr).
KisBrush::mask: Move if condition closer to where it's used for readablility
nishantjr committed R37:10170fe2d993: KisSpacingInformation: Remove redundant isIsotropic member. (authored by nishantjr).
KisSpacingInformation: Remove redundant isIsotropic member.
nishantjr committed R37:0e617a893586: KisDabCache: Remove redundant calculation of height and width (authored by nishantjr).
KisDabCache: Remove redundant calculation of height and width
nishantjr committed R37:fd909df10788: KisDabCache: Merge fetchDabCommon and postProcessDab (authored by nishantjr).
KisDabCache: Merge fetchDabCommon and postProcessDab
Remove KisPainter::renderMirrorMask
nishantjr committed R37:f9fab712fc9b: KisPainter: Remove renderMirrorMaskSafe (We always pass false to it anyway) (authored by nishantjr).
KisPainter: Remove renderMirrorMaskSafe (We always pass false to it anyway)
nishantjr committed R37:23e1ebba6d88: Fix transformation being applied twice in DeformBrush (authored by nishantjr).
Fix transformation being applied twice in DeformBrush
Remove caching from DabCache
nishantjr committed R37:fb11f2518d91: Paintops::brushOutline(): Extract function makeTiltIndicator (authored by nishantjr).
Paintops::brushOutline(): Extract function makeTiltIndicator
nishantjr committed R37:894664f3859f: Make member function static. It wasn't using any class members. (authored by nishantjr).
Make member function static. It wasn't using any class members.
Jul 7 2016
Jul 7 2016
nishantjr committed R37:1d6303580bf9: KisBrushOp: Take ratio into account when calculating spacing. (authored by nishantjr).
KisBrushOp: Take ratio into account when calculating spacing.
nishantjr committed R37:a2f3e88674f3: XXX! Silence warning due to generated dab rectangle not matching calculated one. (authored by nishantjr).
XXX! Silence warning due to generated dab rectangle not matching calculated one.
nishantjr committed R37:c9ea4d23e333: KisSpacingInformation: Remove redundant isIsotropic member. (authored by nishantjr).
KisSpacingInformation: Remove redundant isIsotropic member.
nishantjr committed R37:cfb15b75e638: KisBrush::mask: Move if condition closer to where it's used for readablility (authored by nishantjr).
KisBrush::mask: Move if condition closer to where it's used for readablility
nishantjr committed R37:295d24a3128e: KisAutoBrush: XXX height doesn't considere ratio (authored by nishantjr).
KisAutoBrush: XXX height doesn't considere ratio
nishantjr committed R37:a6383ba9d78b: KisBaseMaskGenerator: effectiveSrcWidth: Use ScaleY instead of scaleX (authored by nishantjr).
KisBaseMaskGenerator: effectiveSrcWidth: Use ScaleY instead of scaleX
nishantjr committed R37:f8defa156eec: KisDabCache: Remove redundant calculation of height and width (authored by nishantjr).
KisDabCache: Remove redundant calculation of height and width
Remove KisPainter::renderMirrorMask
nishantjr committed R37:b36f2d5eb8bb: Create KisPressureRatioOption and integrate it with the pixel brush. (authored by nishantjr).
Create KisPressureRatioOption and integrate it with the pixel brush.
nishantjr committed R37:cfe539128ffa: Remove brushPyramid from the KisBrush. (authored by nishantjr).
Remove brushPyramid from the KisBrush.
nishantjr committed R37:030a356a0045: KisDabCache: Merge fetchDabCommon and postProcessDab (authored by nishantjr).
KisDabCache: Merge fetchDabCommon and postProcessDab
nishantjr committed R37:7ef9dc5e4172: KisPainter: Remove renderMirrorMaskSafe (We always pass false to it anyway) (authored by nishantjr).
KisPainter: Remove renderMirrorMaskSafe (We always pass false to it anyway)
nishantjr committed R37:f8ee79a61483: Fix transformation being applied twice in DeformBrush (authored by nishantjr).
Fix transformation being applied twice in DeformBrush