luebking (Thomas Lübking)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 3 2016, 9:43 PM (193 w, 4 d)
Availability
Available

Recent Activity

May 10 2019

luebking added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

I'll try to reason that out, because I think there's some confusion about the development of the topic.

May 10 2019, 7:54 PM · KWin
luebking added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

Quick reminder: the constantly brought argument for this was that it would allow mass closing of windows, what's outright silly, because the window layout would change w/ every closed window - not necessarily in a predictable way (not only because of the re-layout but attempting to close a window might instead add a dialog - in worst case not a transient one)

May 10 2019, 12:25 PM · KWin

Aug 15 2018

luebking added a comment to D14850: [effects] Turn off Translucency by default.
In D14850#309476, @zzag wrote:
Aug 15 2018, 10:33 AM · KWin
luebking added a comment to D14850: [effects] Turn off Translucency by default.

The functional justification for translucent moving/resizing windows has always been to control its geometry in relation to windows lower in the stack ("what and how much will be covered", "where's a free area")
There may also have been references to early WMs when windows were just hinted by an outline during geometry transitions (though typically not unmapping the actual window), simply because displaying them while resizing them is resource intense (what's more of a concern when you're short on resources) - those WMs would often have presented an outline to allow controlling the initial position for the window before actually mapping it.

Aug 15 2018, 9:50 AM · KWin

May 9 2018

luebking added a comment to D12749: Do not save kwinrulesrc on every window opening/closing.

iirc the set rules are used by kstart

May 9 2018, 6:39 PM · KWin

Jan 20 2018

luebking added a comment to D9982: From 22% of cpu in hasTransientInternal to 1.0x%.

'key...?!
I'd assume the const casting avoids deep copies of the QList - at least that's the only explanation I could come up without a deeper investigation.

Jan 20 2018, 9:51 AM · KWin
luebking added a comment to D9982: From 22% of cpu in hasTransientInternal to 1.0x%.

Did you compare that to a profile with the updated cast?
This makes little sense and a simplified testcase doesn't measure significant differences in casting times on the wall clock time. And certainly not factor 22.

Jan 20 2018, 8:59 AM · KWin

Jan 14 2018

Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: Plasma; removed KWin.

I'm not actually smiling ...

Jan 14 2018, 8:57 PM · KWin
Restricted Application edited projects for D9848: Updated the blur method to use the more efficient dual kawase blur algorithm., added: KWin; removed Plasma.

Why was that a problem?
(Or how can I see the previous patch in this messy review tool which draws an entire core when typing...)

Jan 14 2018, 8:42 PM · KWin
Restricted Application edited projects for D9879: [effects/blur] Disable texture cache on Wayland, added: KWin; removed Plasma.

On a general note, UI-wise: if there's no way to ever enable an item it should not be shown anyway.

Jan 14 2018, 8:23 PM · Plasma

Jan 6 2018

Restricted Application edited projects for D9699: Keep fullscreen windows in active layer based on transients not the group, added: KWin; removed Plasma.

The original implementation based the fullscreen status on the stack position of the window (ie. whenever a window would rise above the plain stack position of the FS window, it would loose the FS status, ie. top layer)
The result was iirc that random notifications would not only show up but also de-fullscreen the window and also virtual desktop switches would constantly kill the FS state.

Jan 6 2018, 7:37 PM · KWin

Jan 2 2018

Restricted Application edited projects for D9608: [KScreen Effect] Fade opacity only for transparent windows, added: KWin; removed Plasma.

Should the lock screen not be guarded by a black layer in the compositor?
As of the effect, maybe this should rather fade in a black layer than fade out everything else?

Jan 2 2018, 1:09 PM · KWin

Dec 13 2017

luebking added a comment to D9294: KWin: tooltips.

requestToolTip(QString) and treat an empty string reasonably?

Dec 13 2017, 9:53 AM · KWin

Nov 13 2017

luebking added a comment to D8796: Support dynamic output enabling/disabling from KScreen.

Ignore the request as "probably temporary" and just freeze rendering?

Nov 13 2017, 8:26 PM · KWin

Nov 7 2017

luebking added inline comments to D8682: Improve some strings and UI elements in KWin KCM.
Nov 7 2017, 2:42 PM · KWin
luebking added inline comments to D8682: Improve some strings and UI elements in KWin KCM.
Nov 7 2017, 7:18 AM · KWin

Oct 5 2017

luebking added a comment to D8145: Update pointer position whenever a window gets (un)minimized.

Why should it? The stack remains the same, just one window changes its visibility.

Oct 5 2017, 10:04 PM · KWin

Aug 25 2017

luebking added a comment to D7521: Make use of foreign protocol.

There's a major pitfall to inter-process modality:
In case of a persistent transient (used by several clients), the leader may loose the focus access "forever" (because the modal window remains)

Aug 25 2017, 7:48 PM · Plasma
luebking added a comment to D7398: Don't create QWhatsThis when user presses showContextHelp button.

Probably to handle internal WhatsThis online help (ie. you click the maximize button of a deco and get the information that this is a maximize button) but I don't know either.
Apparently even Lubos was already unsure what this was about.

Aug 25 2017, 2:16 PM · KWin

Aug 23 2017

luebking added a comment to D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11.

I take there's no such support announcement on native wayland at all?

Aug 23 2017, 6:44 PM · KWin
luebking added a comment to D7475: Make EffectsHandlerImpl::announceSupportProperty work without X11.

Pretty uninformed consideration:
When dealing with X11/wayland hybrids, won't one end up with two property indexes which are hard -if not impossible- to align (because one will be assigned by kwin internally and the other by the casual xwayland server)?
Might the xwayland property even change over the runtime of kwin (is the xwayland server conditionally removed)?

Aug 23 2017, 12:28 PM · KWin

Aug 20 2017

luebking added a comment to D7096: Only send active window changes to X11 root window if the X11 window changed.

Unless things changed for the worse, clients (through this function) still send a client message (on _NET_ACTIVE_WINDOW) - the difference between the regular call and the force version is the source indication being "2" ("i'm a pager/taskbar and know what i'm doing so please do") - but the actual property is still set by the WM after receiving (and honoring) such message.

Aug 20 2017, 12:30 PM · KWin
luebking added a comment to D7096: Only send active window changes to X11 root window if the X11 window changed.

There's no technical advantage in a local static, only a design one. You prevent it from future mis-use beyond its limited purpose, because m_activeWindow isn't actually a "property" of RootInfo.
If you however at some point need several instances, that's no longer an option (resp. you'd need a local hash which is but even uglier than the "false" member)

Aug 20 2017, 8:14 AM · KWin
luebking added a comment to D7096: Only send active window changes to X11 root window if the X11 window changed.

David has some point though - m_activeWindow *can* get out of sync (server error, mal... stupid client - and will be temporarily due to the async setup) and must not be used directly to query the active window.

Aug 20 2017, 7:20 AM · KWin

Aug 15 2017

luebking added a comment to D7323: Expose Cursor position to DeclarativeScripting.

2¢ - you don't have to expose the cursor position for those effects, just a signal that the cursor position changed and the ability to "do some" at the "current" cursor position (which is then resolved by the core)

Aug 15 2017, 6:08 PM · KWin

Jul 15 2017

luebking committed R546:02915e29d9c2: trigger save request for editing list item (authored by luebking).
trigger save request for editing list item
Jul 15 2017, 3:09 PM

Jul 14 2017

luebking committed R546:0f91fdd8ddbf: change contact name on list edit (authored by luebking).
change contact name on list edit
Jul 14 2017, 5:05 PM

Jun 19 2017

luebking added inline comments to D6186: Implement software cursor in OpenGL backend .
Jun 19 2017, 11:34 AM · KWin, Plasma on Wayland
luebking added inline comments to D6186: Implement software cursor in OpenGL backend .
Jun 19 2017, 5:30 AM · KWin, Plasma on Wayland

Jun 18 2017

luebking added inline comments to D6186: Implement software cursor in OpenGL backend .
Jun 18 2017, 9:20 PM · KWin, Plasma on Wayland
luebking added inline comments to D6186: Implement software cursor in OpenGL backend .
Jun 18 2017, 9:09 PM · KWin, Plasma on Wayland

Jun 9 2017

luebking added a comment to D6160: Make kwin_wayland remotely debuggable.

What about lldb and in case this is meant as security measure(?): this only checks a tail, ie. ~/mysuperspytool/trick_kwin/gdb would work just as well - check the binary to be UID0 at least?

Jun 9 2017, 9:11 PM · KWin
luebking added a comment to D6141: make shadows work for windows 100%width or height.

I think what David has in mind is a shadow constellation like

Jun 9 2017, 7:24 PM · KWin

Jun 6 2017

luebking added a comment to D6077: Port most cases of Q_FOREACH to the new for loop..
In D6077#114439, @apol wrote:
Jun 6 2017, 12:20 PM · KWin

Jun 4 2017

luebking added a comment to D5114: support for high dpi in aurorae.

Just saw this because of a bug report.
Why was this patch approved at all?

Jun 4 2017, 7:20 AM · KWin

May 6 2017

luebking accepted D5731: Fix regression for timestamp handling for Xwayland windows.

Matter of semantics only (if you would want to use the XCB_CURRENT_TIME symbol wrt backend abstraction matters and readability - the invalidity isn't implicitly explained, maybe read as bool "if (timestamp && ...") but I'm out of position for an informed comment on this.

May 6 2017, 8:17 PM · KWin
luebking added a comment to D5726: Fix regression for timestamp handling for Xwayland windows.

0L is XCB_CURRENT_TIME iow "kinda invalid", so it's sane to block that in setX11Time()

May 6 2017, 7:29 AM · KWin

May 4 2017

luebking added a comment to D5704: Improve the x11 timestamp handling.
In D5704#106951, @cfeck wrote:

I may be totally unaware about what the changes do, but from reading the comments on the bug report, I had expected to see something like

if (timestamp > m_X11Time || int(timestamp + INT_MAX / 2) < m_X11Time) ...

May 4 2017, 10:02 PM · KWin
luebking added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

The desktop grid seeems more suited to handle the windows VD.
There're PW modes where this feature is pointless (because you only see the current VD anyway) and for the other ones there's (as mentioned) no feedback nor oversight on the status quo. Nor is there even visibility of the feature.
A merge between PW and DG (aka "Mission Control"; what you seem to be after?) would imo require a sane re-draft of such effect/tool.

May 4 2017, 4:16 PM · KWin
luebking added a comment to D5682: Creates keyboard shortcuts for Present Windows Effects actions.

KWin *has* global shortcuts for minimizing and stickyness. Those should either be forwarded or picked up from KGlobalAccel, rather than adding some randonmly hardcoded strings where the user might have entirely different expectation on what they do.

May 4 2017, 5:48 AM · KWin

May 3 2017

luebking added a comment to D5704: Improve the x11 timestamp handling.

Another problem related to timestamp handling is KWin getting broken by wrong timestamps sent by applications. A prominent example is clusterssh

May 3 2017, 8:08 PM · KWin
luebking added a comment to D5704: Improve the x11 timestamp handling.

This should also mitigate the "idiotic client confused X11 time with epoch" condition (iirc some ssh per script?), yesno?

May 3 2017, 8:07 PM · KWin

Apr 26 2017

luebking added a comment to D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down.

According to the bug kwin_wayland receives a SIGINT, not a SIGSEGV?

Apr 26 2017, 7:57 PM · KWin
luebking added a comment to D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down.

This boils down to the question why the process is still lingering around. If the only parent/child link is actually the socket, then it's more likely to zombie around on a bad socket.
In this case you can fire as many signals as you want - they'll never be handled (the process isn't interruptable)

Apr 26 2017, 3:18 PM · KWin
luebking added a comment to D5589: [helper] Terminate xclipboardsyncer if kwin_wayland goes down.

If the child survives the parent that normally means it's forked at some point and the fork will clear the flag - anyway:
Kai says the process knocks out gdb - is it a zombie process (indicated by "D", cannot be stopped or killed, let alone being terminated) and/or is the socket actually closed or still around?

Apr 26 2017, 6:40 AM · KWin

Mar 29 2017

luebking added a comment to D5249: [RFC] New effect plugin - projector (keystone) correction.

ftr, not sure about --transform correctnes, but metamodes ViewportIn/ViewportOut work flawless on at least the nvidia blob.

Mar 29 2017, 8:57 PM · Plasma
luebking added a comment to D5245: Desaturate non-responsive windows.

This is something we do not know. We do not know what color scheme the window uses. Given that a desaturation is probably the best we can do.

Mar 29 2017, 7:38 PM · KWin
luebking added a comment to D5232: Add override to methods that override methods on their parent class.

In case you'd rather not want to introduce a git history wall:
-Wno-inconsistent-missing-override -Wno-inconsistent-missing-destructor-override -Wno-initializer-overrides

Mar 29 2017, 6:53 AM · KWin

Mar 27 2017

luebking added a comment to D5164: fix occassional crash caused by needlessly delayed signals (bko#363224).
In D5164#98159, @lunakl wrote:
Mar 27 2017, 8:38 PM · KWin

Mar 24 2017

luebking added a comment to D5164: fix occassional crash caused by needlessly delayed signals (bko#363224).

To keep the delay, one would have to wire the call through a secure dispatcher which guarantees (by searching the list of all windows) the effectwindow still points valid memory before passing the function call on (or use a guarded pointer)

Mar 24 2017, 6:57 PM · KWin

Feb 22 2017

luebking added inline comments to D4718: support for auto-hidden windows to resize.
Feb 22 2017, 3:44 PM · KWin

Jan 20 2017

luebking added a comment to D4220: Add a basic SNI for keyboard layout.
Jan 20 2017, 3:02 PM · KWin, Plasma on Wayland
luebking added a comment to D4220: Add a basic SNI for keyboard layout.

"On Wayland that kded has no real access to the layouts and cannot
properly implement switching. Given that it's better to integrate the
SNI directly in KWin."

Jan 20 2017, 8:13 AM · KWin, Plasma on Wayland

Jan 17 2017

luebking accepted D4113: Correct inital loading of BorderActivate.
Jan 17 2017, 1:43 PM · Plasma

Jan 13 2017

luebking added a comment to D4113: Correct inital loading of BorderActivate.

The entire parsing is totally not safe against JoeReddiot murking around in the config file, I wonder what happens if we pass "-1" and what is " " cast as...

Jan 13 2017, 8:17 PM · Plasma

Jan 8 2017

luebking added a comment to D4025: [KScreen Helper Effect] Avoid windows and desktop shining through.

xcb_randr, gamma ramps. yes.
Look at the inversion implementation in kwin and/or simply the xgamma/xcalib code =)

Jan 8 2017, 7:28 PM · KWin
luebking added a comment to D4025: [KScreen Helper Effect] Avoid windows and desktop shining through.

I'm no longer sufficiently in touch with the code, but one could probably "abuse" the (unstyled) effectframe for the matter (ie. generalize it and make the current frame a special case reg. color, roundness and opacity) - or introduce a similar class for such purposes.

Jan 8 2017, 6:20 PM · KWin
luebking added a comment to D4025: [KScreen Helper Effect] Avoid windows and desktop shining through.

Wouldn't it make more sense to leave the windows alone and trail the screen paint with a black rectangle, in doubt by adding a black window?

Jan 8 2017, 6:15 PM · KWin

Dec 25 2016

luebking added inline comments to D3617: [Touchpad KCM] New KWin Wayland version.
Dec 25 2016, 9:51 PM · KWin, Plasma on Wayland

Dec 14 2016

luebking added inline comments to D3602: Cycle between windows of the same desktop on switch.
Dec 14 2016, 8:39 PM · KWin

Dec 6 2016

luebking added a comment to D3602: Cycle between windows of the same desktop on switch.

Featurewise, there's iirc a config item to wrap around virtual desktops - maybe this should be invoked here? (Although that link is currently not made clear by the config dialog)

Dec 6 2016, 8:29 PM · KWin

Nov 25 2016

luebking added a comment to D3472: API for window tabbing.

On a general note: this terribly looks like doubling all (or a lot of) the core logics reg. tabs - which we had in initial KDE 4 tabbing and which made tabbing *incredibly* buggy.
I'd suggest to forward the cores tab logics and not keep local states, counters etc. around, you'll easily get out of sync.

Nov 25 2016, 2:28 PM · KWin

Oct 24 2016

luebking added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 24 2016, 3:07 PM · Plasma

Oct 23 2016

luebking added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 23 2016, 7:30 PM · Plasma
luebking added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 23 2016, 6:38 PM · Plasma
luebking added inline comments to D3132: [platformx/x11] Add a freeze protection against OpenGL.
Oct 23 2016, 5:35 PM · Plasma

Oct 16 2016

luebking added inline comments to D2931: Destroy DebugConsole on hide of QWindow.
Oct 16 2016, 4:36 PM · KWin, Plasma on Wayland
luebking added a comment to D3037: Support docks which take input.
Oct 16 2016, 4:29 PM · KWin, Plasma on Wayland

Oct 12 2016

luebking added a comment to D3037: Support docks which take input.

Errrr... this does not allow the dock to control input, ie. the dock can or can not take focus but you want focus if eg. clicking into a lineedit while do certainly not want it when clicking a button that will activate a window (FSP trouble)

Oct 12 2016, 1:47 PM · KWin, Plasma on Wayland

Oct 6 2016

luebking added inline comments to D2945: Workaround xkbcommon behavior concerning consumed modifiers.
Oct 6 2016, 10:46 AM · KWin, Plasma on Wayland
luebking added inline comments to D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling.
Oct 6 2016, 7:27 AM · Plasma
luebking added inline comments to D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling.
Oct 6 2016, 7:18 AM · Plasma

Oct 4 2016

luebking added inline comments to D2931: Destroy DebugConsole on hide of QWindow.
Oct 4 2016, 2:45 PM · KWin, Plasma on Wayland
luebking added inline comments to D2931: Destroy DebugConsole on hide of QWindow.
Oct 4 2016, 2:45 PM · KWin, Plasma on Wayland
luebking added inline comments to D2931: Destroy DebugConsole on hide of QWindow.
Oct 4 2016, 2:37 PM · KWin, Plasma on Wayland
luebking added inline comments to D2931: Destroy DebugConsole on hide of QWindow.
Oct 4 2016, 2:28 PM · KWin, Plasma on Wayland
luebking added inline comments to D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.
Oct 4 2016, 2:17 PM · KWin

Sep 24 2016

luebking added a comment to D2851: [kwinrules] Properly setting the value of the activity combo box.

This looks like editing the rule while the activity daemon does not respond (in time) is prone to alter the setting?
Maybe disable the combo until there's response from the activity dameon and ensure to not write back the setting until it's enabled?

Sep 24 2016, 1:08 PM · KWin

Sep 19 2016

luebking added a comment to D2782: parent qaction in test.

The statement is legal, this is either a problem in Qt (API break) or the compiler (resolving function signatures, maybe related to "explicit" or template usage)

Sep 19 2016, 8:57 AM · KWin

Sep 15 2016

luebking added inline comments to D2787: Add support for resize only borders on Wayland.
Sep 15 2016, 8:25 PM · KWin, Plasma on Wayland
luebking added a comment to D2786: [server] Don't send key release for not pressed keys and no double key press.

Sounds reasonable enough, but seems to point out an issue in wayland:

Sep 15 2016, 8:16 PM · KWin, Plasma on Wayland
luebking added a comment to D2782: parent qaction in test.

This is BC, but undocumented.

Sep 15 2016, 12:03 PM · KWin

Sep 13 2016

luebking added inline comments to D2584: Introduce a config option whether applications are allowed to block compositing.
Sep 13 2016, 12:58 PM · KWin, Plasma on Wayland

Sep 10 2016

luebking committed R108:d3bb21b61436: set highlightwindows inactive while screen locked (authored by luebking).
set highlightwindows inactive while screen locked
Sep 10 2016, 6:33 AM
luebking committed R108:b1c876188018: fix off-by-1 on multiscreen toppanel strutting (authored by luebking).
fix off-by-1 on multiscreen toppanel strutting
Sep 10 2016, 6:33 AM
luebking committed R108:6db1c056b1f3: ensure to show clients that need sessionInteract (authored by luebking).
ensure to show clients that need sessionInteract
Sep 10 2016, 6:33 AM
luebking committed R108:9979789e2744: fix sendToScreen for QuickTiled windows (authored by luebking).
fix sendToScreen for QuickTiled windows
Sep 10 2016, 6:33 AM
luebking committed R108:1de1c2e0484e: reset desktopChangedWhileRotating on activation (authored by luebking).
reset desktopChangedWhileRotating on activation
Sep 10 2016, 6:33 AM
luebking committed R108:51422e095519: fix frontbuffer copying swap preference (authored by luebking).
fix frontbuffer copying swap preference
Sep 10 2016, 6:33 AM
luebking committed R108:03cdc9ed7dfd: be more aggressive about exiting zoom effect (authored by luebking).
be more aggressive about exiting zoom effect
Sep 10 2016, 6:33 AM
luebking committed R108:507887657da7: spatial present windows zoom calculation (authored by luebking).
spatial present windows zoom calculation
Sep 10 2016, 6:33 AM
luebking committed R108:1eb969438995: align zoomed cursor to hotspot (authored by luebking).
align zoomed cursor to hotspot
Sep 10 2016, 6:33 AM
luebking committed R108:cdc743b8f420: Merge branch 'KDE/4.11' (authored by luebking).
Merge branch 'KDE/4.11'
Sep 10 2016, 6:33 AM
luebking committed R108:ce32856c8543: mouseclick FX, don't collect clicks unless active (authored by luebking).
mouseclick FX, don't collect clicks unless active
Sep 10 2016, 6:33 AM
luebking committed R108:97a6676a4fa9: depend noborder on motif_noborder after reshape (authored by luebking).
depend noborder on motif_noborder after reshape
Sep 10 2016, 6:33 AM
luebking committed R108:8a95ac8dfb4e: Merge branch 'KDE/4.11' (authored by luebking).
Merge branch 'KDE/4.11'
Sep 10 2016, 6:32 AM
luebking committed R108:e716d8299376: remove clientMachine from session handling (authored by luebking).
remove clientMachine from session handling
Sep 10 2016, 6:32 AM
luebking committed R108:24138f7d04d1: no autogrouping if deco doesn't support it (authored by luebking).
no autogrouping if deco doesn't support it
Sep 10 2016, 6:32 AM
luebking committed R108:ae9bff20b69a: full repaints in logout effect (authored by luebking).
full repaints in logout effect
Sep 10 2016, 6:32 AM
luebking committed R108:b712b5c038cc: cut spurious \0 byte from string properties (authored by luebking).
cut spurious \0 byte from string properties
Sep 10 2016, 6:32 AM