Make kwin_wayland remotely debuggable
ClosedPublic

Authored by Kanedias on Jun 9 2017, 10:56 AM.

Details

Summary

Now only gdb is allowed.
When using gdbserver :5555 ./kwin_wayland it doesn't work due to KWin disabling PTRACE capability

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Kanedias created this revision.Jun 9 2017, 10:56 AM
Restricted Application added subscribers: KWin, kwin. · View Herald TranscriptJun 9 2017, 10:56 AM
davidedmundson accepted this revision.Jun 9 2017, 11:42 AM
This revision is now accepted and ready to land.Jun 9 2017, 11:42 AM

Err... How do I apply this change? Should I just push this commit to master?

Yes.

As long as your commit contains
"Differential Revision: https://phabricator.kde.org/D6160"
this should automatically close.

This revision was automatically updated to reflect the committed changes.
cfeck reopened this revision.Jun 9 2017, 8:51 PM
cfeck added a subscriber: cfeck.

Reopening, and awaiting review from maintainer to not need to revert it again.

This revision is now accepted and ready to land.Jun 9 2017, 8:51 PM

What about lldb and in case this is meant as security measure(?): this only checks a tail, ie. ~/mysuperspytool/trick_kwin/gdb would work just as well - check the binary to be UID0 at least?

Reopening, and awaiting review from maintainer to not need to revert it again.

What why?

What about lldb and in case this is meant as security measure(?)

Yes, this is existing check is pretty rubbish, but adding gdbserver doesn't make it any less so.

No problem, I can wait for Martin

graesslin accepted this revision.Jun 10 2017, 9:28 PM

The existing check is btw what IIRC the man page suggested 😉 so not completely rubbish. It's not secure, but that's not the point of it. Extending the check seems fine to me.

This revision was automatically updated to reflect the committed changes.