Don't create QWhatsThis when user presses showContextHelp button
ClosedPublic

Authored by graesslin on Aug 18 2017, 7:02 PM.

Details

Summary

I don't know what the idea of entering QWhatsThis mode was, but the code
is pretty much dead. There is no QWhatsThis window shown as KWin does
not have any UI or help. The window which eventually gets shown in
context help is provided by the client application.

Furthermore KWin never leaves the QWhatsThis mode. At least one code
path entering in leave is dead in general and one at least on Wayland
(but probably also on X11 as the window never gets shown).

The show context help functionality works fine without the QWhatsThis
handling, so let's remove it.

I tried to blame what was the idea behind it, but it was unchanged since
decades and blame ended in a code moving commit.

Test Plan

Used show context help (kcmshell5 --platform xcb kwinoptions)

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Aug 18 2017, 7:02 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 18 2017, 7:02 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

Probably to handle internal WhatsThis online help (ie. you click the maximize button of a deco and get the information that this is a maximize button) but I don't know either.
Apparently even Lubos was already unsure what this was about.

I'm not sure whether WhatsThis is actually still used by real users as of today, so I'd suggest to accidentally™ break it and see whether somebody misses something afterwards.

Probably to handle internal WhatsThis online help (ie. you click the maximize button of a deco and get the information that this is a maximize button) but I don't know either.
Apparently even Lubos was already unsure what this was about.

I'm not sure whether WhatsThis is actually still used by real users as of today, so I'd suggest to accidentally™ break it and see whether somebody misses something afterwards.

Not inside KWin, I spent quite some time in git grep and blame ;-)

This revision was automatically updated to reflect the committed changes.