SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting
ClosedPublic

Authored by jpoelen on Aug 4 2018, 2:39 PM.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jpoelen created this revision.Aug 4 2018, 2:39 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 4 2018, 2:39 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
jpoelen requested review of this revision.Aug 4 2018, 2:39 PM

I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with ## as for IncludeRules.

cullmann added a subscriber: cullmann.

Hi,

the idea "I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with ## as for IncludeRules."

sounds reasonable.
Do you want to give it a try to implement that? Volker, what do you think about that?

Yes, I can start tomorrow.

cullmann accepted this revision.Aug 12 2018, 2:39 PM

I would be for merging this and later replacing with the include list stuff.

This revision is now accepted and ready to land.Aug 12 2018, 2:39 PM

Ok, i'm doing this in the week.

This revision was automatically updated to reflect the committed changes.
cullmann reopened this revision.Aug 19 2018, 4:04 PM

The unit tests fail du to errors like:

-<dsNormal></dsNormal><br/>
-<dsNormal></dsNormal><br/>
+<Normal Text></Normal Text><br/>
+<Normal Text></Normal Text><br/>

Could it be your local version wasn't up to date?
I will regen the references, I see only empty lines change their attributes.

This revision is now accepted and ready to land.Aug 19 2018, 4:04 PM
This revision was automatically updated to reflect the committed changes.

Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files). If there was no more error it was because I saw them in the conflicts.

Currently I put find_package (ECM 5.31.0 ... (instead of 5.49.0) and delete include (ECMAddQch) which I think should be in if (BUILD_QCH).