Jam: various improvements and fixes

Authored by jpoelen on May 30 2019, 10:14 PM.


  • fix x=: is a rule named x=, not a variable
  • fix exe onxxxxx: is a rule call, not a variable
  • fix ifxxx, rulexxx, etc: not keywords
  • fix variable default = xxx ;
  • fix keywords and operators in a condition: they must be separated by spaces
  • fix on target
  • fix switch
  • fix class and module
  • fix for local x
  • new styles: Feature and FeatureOperator for <xxx>, -<xxx>, <xxx>abc:<yyy>abc, <xxx>abc/<yyy>abc, <xxx>abc&&def
  • don't use black color in Rule

Diff Detail

R216 Syntax Highlighting
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
jpoelen requested review of this revision.May 30 2019, 10:14 PM
jpoelen created this revision.

Looks reasonable + test case, nice.
Btw., would it be possible to remove the last remaining hard coded color <itemData name="CommentTitle" defStyleNum="dsComment" color="darkorange" bold="1"/> here, too?

cullmann accepted this revision.May 31 2019, 11:11 AM

(the hard coded color was already there, therefore this doesn't block this request)

This revision is now accepted and ready to land.May 31 2019, 11:11 AM

I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would like to be sure.

In any case I have to do an update because I mixed class and module :/

jpoelen updated this revision to Diff 59150.Jun 4 2019, 6:46 PM
  • fix module
  • remove hard coded color
dhaumann accepted this revision.Jun 4 2019, 9:37 PM
This revision was automatically updated to reflect the committed changes.