fix additionalDeliminator attribute
ClosedPublic

Authored by jpoelen on Tue, Aug 13, 10:52 PM.

Details

Summary

The initialization of the Rule::m_wordDelimiter cache was done before the delimiters were extracted, which can invalidate the character number.

BUG: 399348

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jpoelen requested review of this revision.Tue, Aug 13, 10:52 PM
jpoelen created this revision.
jpoelen added a comment.EditedTue, Aug 13, 10:56 PM

I don't understand why there's so much difference in what's displayed :/

Edit: With the option History -> Whitespace Changes: ignore trailing, the difference is normal, but I do not understand the behavior of phabricator

Could you add a unit test for this?

  • add the dummy xml similar to the one in the bug report. This can be done by using the additional search folder in the Repository.
  • add a test highlighting like done with the others

The so only when the unit tests run, the Repository contains the additional search path.

jpoelen updated this revision to Diff 63771.Wed, Aug 14, 11:14 PM
  • add unit test
cullmann accepted this revision.Thu, Aug 15, 6:37 PM

Thanks for the test.
With git diff -w the patch looks fine.

This revision is now accepted and ready to land.Thu, Aug 15, 6:37 PM
This revision was automatically updated to reflect the committed changes.