Highlighting indexer: check kateversion
ClosedPublic

Authored by jpoelen on Aug 25 2019, 1:59 AM.

Details

Summary

Checks that files using <include> are in version 5.53 and that contexts do not reference a higher version.

The output looks like this:

$ ninja data/index.katesyntax
".../data/syntax/markdown.xml" depends on a language in version 5.53. Please, increase kateversion.
".../data/syntax/djangotemplate.xml" depends on a language in version 5.0. Please, increase kateversion.
...

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jpoelen requested review of this revision.Aug 25 2019, 1:59 AM
jpoelen created this revision.
cullmann accepted this revision.Aug 25 2019, 10:30 AM

Nice!
I have no idea why the diff looks here that big, locally after arc patch I have a nicer diff that shows the added code is fine.
Thanks that you take care of such things!

This revision is now accepted and ready to land.Aug 25 2019, 10:30 AM
This revision was automatically updated to reflect the committed changes.

Thanks for pushing this forward, very much appreciated!