- User Since
- Aug 26 2018, 5:21 PM (25 w, 2 d)
Sun, Feb 10
Thanks @elvisangelaccio :)
Thanks. Do you have commit access?
Please remove the QEXPECT_FAIL at line 498 of cli7ztest.cpp, then this is good to go.
Add checking for directory in Attributes
However, I'm hitting the Q_ASSERT in Archive::Entry::appendEntry when opening any 7z archive:
Remove the lines, they seem to be unnecessary
Sun, Feb 3
Any review on this patch? It's waiting the review for a week.
Tue, Jan 29
Thanks. Can you share a test archive that works with this patch but doesn't without?
Sun, Jan 27
Jan 17 2019
@davidedmundson, can you please merge it into master? I don't have a developer account, so I can't do this by myself.
Jan 12 2019
I would also scrap all the stuff about ~/.local
Jan 11 2019
Jan 1 2019
Prevent the theme from rebuilding each time
Dec 31 2018
Dec 28 2018
Hello, is there any progress on the review?
Dec 26 2018
Remove compiled themes from the sources; now the building process doesn't modify the sources at all
But files in the source repo are still overwritten during the build process if you do an in-source build.
Summary of changes done:
It seems to be the issue with parallel Make. The original scripts often overwrite sources, so they can't be built in parallel. I'll try to fix it to resolve the race conditions.
Dec 25 2018
Why are you using npm for this? There is sassc which is a compiled binary and doesn't have many dependencies.
Dec 24 2018
Add gtk-dark.css support for Breeze
Fix GTK+ 3.18 theme installation
Oops, sorry, I forgot to check the installation.
Fix finding Python package for CMake <3.12
Make Sass a required dependency
Dec 22 2018
Use CMake for building themes
Dec 9 2018
Add a comment about value 0.77
This patch is not reviewed for two weeks. How soon can I get some feedback on it?
Nov 25 2018
Aug 30 2018
@davidedmundson, can you please merge this revision? I don't have a developer account, so I can't do it.