- User Since
- Aug 26 2018, 5:21 PM (63 w, 1 d)
Tue, Oct 15
Thanks. Can you please merge it? I don't have a developer access to KDE repos.
Oct 6 2019
Aug 17 2019
Thanks, now I got your point much clearer.
Aug 16 2019
Aug 11 2019
Still waiting for the feedback.
Aug 1 2019
Jul 29 2019
Here is how it looks on tall panels:
Now the widget doesn't become too wide if the panel is tall. The size formula now looks similar to the size formula of the clock widget. Expanatory comment is updated.
I don't follow how it makes them the same when the other number is different.
Change magic value to 0.86, as it looks nearer to the clock font size
Minor change in the comment for the "magic" value 0.84
The rationale is to make the clock font size and the timer font size identical. Setting 0.84 as timer height multiplier indeed reaches this goal. But two other problems remain:
- the fonts are different itself, as clock uses the real font, and timer uses SVGs to render digits
- if the panel is large enough, the vertical position of the text differs (timer's top and bottom margins are equal, but clock's top and bottom margins have different size)
Should I fix some of these issues also?
Jul 27 2019
After some experiments, I finally set clock size to 0.84:
Updating D17464: [Timer applet] Minor fixes for the applet
May 31 2019
Was KDing only German <-> English?
Mar 21 2019
You are welcome :)
Use a more compact way, as suggested in IRC
Fix commit message: Ark -> Apper
I have some suggestions to prevent such errors in the future:
- sass (but not sassc) has -E option to set the encoding for building
- it may be a good idea to add such lines to all the SCSS files
Feb 10 2019
Thanks @elvisangelaccio :)
Thanks. Do you have commit access?
Please remove the QEXPECT_FAIL at line 498 of cli7ztest.cpp, then this is good to go.
Add checking for directory in Attributes
However, I'm hitting the Q_ASSERT in Archive::Entry::appendEntry when opening any 7z archive:
Remove the lines, they seem to be unnecessary
Feb 3 2019
Any review on this patch? It's waiting the review for a week.
Jan 29 2019
Thanks. Can you share a test archive that works with this patch but doesn't without?
Jan 27 2019
Jan 17 2019
@davidedmundson, can you please merge it into master? I don't have a developer account, so I can't do this by myself.
Jan 12 2019
I would also scrap all the stuff about ~/.local
Jan 11 2019
Jan 1 2019
Prevent the theme from rebuilding each time
Dec 31 2018
Dec 28 2018
Hello, is there any progress on the review?
Dec 26 2018
Remove compiled themes from the sources; now the building process doesn't modify the sources at all
But files in the source repo are still overwritten during the build process if you do an in-source build.