| muhlenpfordt | |
| mmazur | |
| friedreich | |
| ngraham | |
| davidedmundson |
| Plasma |
BUG: 395182
BUG: 361025
Here are the changes made:
Tried placing the timer on a panel, then tried to resize the panel. Tested on both vertical and horizontal panels.
I regularly use this applet on a vertical panel without issues.
| No Linters Available |
| No Unit Test Coverage |
| Buildable 14549 | |
| Build 14567: arc lint + arc unit |
| applets/timer/package/contents/ui/TimerView.qml | ||
|---|---|---|
| 46 | Doesn't it use the default sizing settings (as used before this patch)? | |
| applets/timer/package/contents/ui/TimerView.qml | ||
|---|---|---|
| 65 | As I remember, I was trying to make the digits size of timer equal nearer to clock font size. Setting this to 1.0 won't break anything, but the digits will take the full height of the panel. BTW, clock itself uses height * 0.71. | |
| applets/timer/package/contents/ui/TimerView.qml | ||
|---|---|---|
| 65 | I dislike the clock code, but if you leave a comment of why it's that way, then ok. | |
| applets/timer/package/contents/ui/TimerView.qml | ||
|---|---|---|
| 53 | Can't get it work with implicitWidth and implicitHeight. By the way, when using parent.width and parent.height it works OK (but parent.implicitWidth and parent.implicitHeight don't work correctly). Is it OK or are there other ideas how to rewrite this part of code? | |
| applets/timer/package/contents/ui/TimerView.qml | ||
|---|---|---|
| 65 | Clock is 0.71 | |
Updating D17464: [Timer applet] Minor fixes for the applet
Change clock size ratio to 0.84 for better compatibility with Clock's font size
After some experiments, I finally set clock size to 0.84:
The main problem is that the clock widget uses a real font, but the timer uses SVGs to render digits, so the ideal is not so easy to reach.
I still can't accept a patch with an unexplained magic number.
If the rationale is that it's to match the clock, then it has to match the clock. If there's something else, please can the comment say what.
The rationale is to make the clock font size and the timer font size identical. Setting 0.84 as timer height multiplier indeed reaches this goal. But two other problems remain:
Should I fix some of these issues also?
The rationale is to make the clock font size and the timer font size identical. Setting 0.84 as timer height multiplier indeed reaches this goal. But two other problems remain:
I don't follow how it makes them the same when the other number is different.
I don't follow how it makes them the same when the other number is different.
Timer applet is rendered using SVGs, clock applet is rendered using text. So, as the SVGs and font glyphs have different sizes, we need different coefficients. The coefficient 0.86 itself is obtained by trying different other "magic" numbers and finding the nearest one visually.
Here is how it looks:
Or, I can just give up and remove 0.86 from the code :)
Now the widget doesn't become too wide if the panel is tall. The size formula now looks similar to the size formula of the clock widget. Expanatory comment is updated.
If it's the exact same code as before, then my opinion will be the same.
The digital clock set the text height to 0.7 of the panel and the width is inferred through layouting.
This patch sets the width based on the height of the parent. Which is why you need a different magic number.
We adjust the layout with which in turn adjust the width which in turn adjusts the digitH..it's all very messy.
Our best bet will be to fix the layouting, so that the width can be inferred automatically and you can use the same logic to set the height.
