Differential D18314

Cosmetic fixes for build_theme.sh
ClosedPublic
Actions

Authored by gepardo on Jan 17 2019, 11:07 AM.

Details

Reviewers
davidedmundson
Commits
R98:6a6a432546bb: Cosmetic fixes for build_theme.sh
Summary

I saw the changes introduced by https://phabricator.kde.org/D18287. It's a really good idea :)

The commit contains some minor fixes into the build script (like quoting "$4" parameter)

Test Plan

Builds on my machine. The changes are minor and should not affect anything.

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gepardo created this revision.Jan 17 2019, 11:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 17 2019, 11:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
gepardo requested review of this revision.Jan 17 2019, 11:07 AM
davidedmundson accepted this revision.Jan 17 2019, 11:39 AM
This revision is now accepted and ready to land.Jan 17 2019, 11:39 AM
gepardo added a comment.Jan 17 2019, 2:36 PM

@davidedmundson, can you please merge it into master? I don't have a developer account, so I can't do this by myself.

Closed by commit R98:6a6a432546bb: Cosmetic fixes for build_theme.sh (authored by gepardo, committed by davidedmundson). · Explain WhyJan 17 2019, 9:29 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Jan 17 2019, 9:34 PM

@davidedmundson should we land this to the 5.15 branch, or just master?

ngraham added a comment.Jan 17 2019, 9:35 PM

lol too fast for me

Revision Contents
Changeset List

PathPackages
Msrc/build_theme.sh (8 lines)

Diff 49759

View Options

src/build_theme.sh

Loading...