garg (Rohan Garg)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 5 2015, 5:16 PM (233 w, 5 h)
Availability
Available

Recent Activity

Oct 11 2019

garg added a reviewer for D24556: [platforms/drm] Fix hardware cursor initialization: KWin.
Oct 11 2019, 2:45 PM · KWin

Jan 30 2019

garg added a comment to D18460: Make sure we check for any GL errors generated from glGetIntegerv.

I've heard back from Mali upstream and this particular bug has been fixed in r20 of their blob, and I'm pushing Rockchip to get that driver released. I'm still of the opinion that adding the error check is a good idea though. Any thoughts?

Jan 30 2019, 5:43 PM · KWin

Jan 23 2019

garg added a comment to D18460: Make sure we check for any GL errors generated from glGetIntegerv.
In D18460#398164, @zzag wrote:

I don't think that's the right way to fix the problem.

Do you have OpenGL ES 3.2?

Jan 23 2019, 9:04 AM · KWin
garg added a comment to D18460: Make sure we check for any GL errors generated from glGetIntegerv.
In D18460#398165, @zzag wrote:

Also, it looks like we don't create debug context.

Jan 23 2019, 9:01 AM · KWin

Jan 22 2019

garg requested review of D18460: Make sure we check for any GL errors generated from glGetIntegerv.
Jan 22 2019, 7:07 PM · KWin

Jul 1 2018

garg added a comment to T8170: Attend External Events 2018: Embedded Linux Conference Europe.

I submitted a talk about deploying Plasma on Embedded devices.

Jul 1 2018, 1:03 PM · Plasma, KDE Promo

Jun 19 2018

garg added a comment to T8170: Attend External Events 2018: Embedded Linux Conference Europe.

Hey
I'd like to attend and help run the booth and anything else that might need doing, I've worked on getting Plasma working on the Pinebook and other misc. ARM devices.

Jun 19 2018, 1:42 PM · Plasma, KDE Promo

Apr 23 2018

garg committed R108:757ed91a5dd2: Handle errors with drmModeSetCursor instead of silently failing (authored by garg).
Handle errors with drmModeSetCursor instead of silently failing
Apr 23 2018, 8:39 AM
garg closed D12447: Handle errors with drmModeSetCursor instead of silently failing.
Apr 23 2018, 8:39 AM · KWin

Apr 22 2018

garg updated the diff for D12447: Handle errors with drmModeSetCursor instead of silently failing.

Update return types

Apr 22 2018, 7:47 PM · KWin
garg updated the diff for D12447: Handle errors with drmModeSetCursor instead of silently failing.

Update as per comments

Apr 22 2018, 4:12 PM · KWin
garg updated the diff for D12447: Handle errors with drmModeSetCursor instead of silently failing.

Make sure we return the right value

Apr 22 2018, 2:28 PM · KWin
garg requested review of D12447: Handle errors with drmModeSetCursor instead of silently failing.
Apr 22 2018, 1:20 PM · KWin

Feb 26 2018

garg added a comment to D10541: make kdesu available in bindir and thus $PATH by default (opt-out).

LGTM

Feb 26 2018, 4:41 PM · Plasma

Feb 8 2018

garg committed R108:3e37f896e30a: Simplify compositing setup code (authored by garg).
Simplify compositing setup code
Feb 8 2018, 7:24 PM
garg closed D10393: Simplify compositing setup code.
Feb 8 2018, 7:24 PM · KWin
garg requested review of D10393: Simplify compositing setup code.
Feb 8 2018, 7:12 PM · KWin
Restricted Application edited projects for D10346: check for EGL_KHR_platform_gbm extension as well, added: KWin; removed Plasma.

BTW this patch works as tested on both the Rock64 and Pinebook, but kwin fails in another place now. Will continue investigating.

Feb 8 2018, 5:27 PM · Plasma

Dec 22 2017

garg committed R369:2c26a6c59dc5: Ship a dbus service file (authored by leszeklesner).
Ship a dbus service file
Dec 22 2017, 12:20 PM
garg closed D9315: Ship a dbus service file.
Dec 22 2017, 12:20 PM

Sep 5 2017

garg added a comment to T6076: Scripts in /etc/profile.d/* don't get sourced.

Simple Login does not evaluate it. It should, or we should use sddm on the phone too.

Sep 5 2017, 11:14 AM · Plasma: Mobile

Aug 29 2017

garg created T6892: QtWS biz cards.
Aug 29 2017, 2:48 PM · KDE Promo

Jul 4 2017

garg added a comment to D6459: Fix the National Geographic PoTD dataengine.

Can this also go into the next 5.10 release?

Jul 4 2017, 9:22 PM · Plasma

Jul 3 2017

garg added a comment to D6459: Fix the National Geographic PoTD dataengine.

You can checkout the XML on http://www.nationalgeographic.com/photography/photo-of-the-day/ by just viewing the source :)

Jul 3 2017, 2:34 PM · Plasma

Jul 1 2017

garg added a comment to D6459: Fix the National Geographic PoTD dataengine.

Unfortunately I couldn't figure out a way to relax the XML parser, so if anyone has tips on how to achieve that, I'd highly appreciate them :)

Jul 1 2017, 11:28 AM · Plasma
garg created D6459: Fix the National Geographic PoTD dataengine.
Jul 1 2017, 11:26 AM · Plasma

Jun 28 2017

garg committed R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found (authored by garg).
[Scripting] Throw a error from the Containment when the widget is not found
Jun 28 2017, 9:04 PM
garg closed D6424: [Scripting] Throw a error from the Containment when the widget is not found by committing R120:94aa4152937f: [Scripting] Throw a error from the Containment when the widget is not found.
Jun 28 2017, 9:04 PM · Plasma
garg updated the diff for D6424: [Scripting] Throw a error from the Containment when the widget is not found.

Remove useless debug

Jun 28 2017, 8:50 PM · Plasma
garg updated the diff for D6424: [Scripting] Throw a error from the Containment when the widget is not found.

Remove accidentally commited file

Jun 28 2017, 8:49 PM · Plasma
garg updated the diff for D6424: [Scripting] Throw a error from the Containment when the widget is not found.

Update as per David's comments

Jun 28 2017, 8:47 PM · Plasma
garg updated the diff for D6424: [Scripting] Throw a error from the Containment when the widget is not found.

Mention the name of the widget too

Jun 28 2017, 7:31 PM · Plasma
garg added a reviewer for D6424: [Scripting] Throw a error from the Containment when the widget is not found: Plasma.
Jun 28 2017, 7:10 PM · Plasma
garg created D6424: [Scripting] Throw a error from the Containment when the widget is not found.
Jun 28 2017, 7:09 PM · Plasma

Jun 20 2017

garg added a comment to T6340: Aptly db_cleanup jenkins job.

@scarlettclark Sounds about right to me. The tricky part imo is probably how one restarts the job on the publisher.

Jun 20 2017, 10:44 AM · Neon
garg added a comment to T4427: [kwin] Use "buffer age" in QPainterDRMBackend.

Poke? Could someone point me in the right direction here? :)

Jun 20 2017, 10:43 AM · KWin, Plasma on Wayland

Jun 19 2017

garg added a comment to T6340: Aptly db_cleanup jenkins job.

Nope, needs to block all jobs on Jenkins somehow so that Jenkins doesn't try and publish while aptly is restarting.

Jun 19 2017, 3:21 PM · Neon

Jun 16 2017

garg added a comment to T6340: Aptly db_cleanup jenkins job.

Oh cool, perhaps you can simply restart aptly once in a while to trigger this?

Jun 16 2017, 3:15 PM · Neon

Jun 15 2017

garg added a comment to T4427: [kwin] Use "buffer age" in QPainterDRMBackend.

So I was thinking of somehow clipping the buffer that we present to the backend to only represent the damaged region. I'm not quite sure yet how to clip the QImage to the damaged QRegion we have, but does that sound sensible?

Jun 15 2017, 12:02 PM · KWin, Plasma on Wayland

Jun 13 2017

garg added a comment to T4427: [kwin] Use "buffer age" in QPainterDRMBackend.

Oh, after reading the code a bit more, would it be more sensible to simply skip presenting the buffer if it hasn't changed? Something like so ( I couldn't quite figure out how else to compare two DrmDumbBuffers ) :

Jun 13 2017, 9:10 PM · KWin, Plasma on Wayland
garg added a comment to T4427: [kwin] Use "buffer age" in QPainterDRMBackend.

Hey
I've been looking at this and wanted to make sure if I understood this correctly before writing a patch.

Jun 13 2017, 4:54 PM · KWin, Plasma on Wayland

May 18 2017

garg committed R108:21bd910706ef: [DRM plugin] Remove dead code (authored by garg).
[DRM plugin] Remove dead code
May 18 2017, 2:03 PM

May 11 2017

garg committed R257:e311eaad70cb: Build qtvirtualkeyboard too (authored by garg).
Build qtvirtualkeyboard too
May 11 2017, 11:10 AM

May 10 2017

garg added a comment to T6076: Scripts in /etc/profile.d/* don't get sourced.

Ideally SDDM should grow support for a wayland based greeter instead of a X11 greeter. This would involve looking at what XorgDisplayServer does and why the Greeter needs it.

May 10 2017, 3:25 PM · Plasma: Mobile
garg committed R108:3817eddfc666: m_clientSize is already connected in ShellClient::init (authored by garg).
m_clientSize is already connected in ShellClient::init
May 10 2017, 8:52 AM
garg closed D5787: m_clientSize is already connected in ShellClient::init by committing R108:3817eddfc666: m_clientSize is already connected in ShellClient::init.
May 10 2017, 8:52 AM · KWin

May 9 2017

garg added a reviewer for D5787: m_clientSize is already connected in ShellClient::init: KWin.
May 9 2017, 3:49 PM · KWin
garg created D5787: m_clientSize is already connected in ShellClient::init.
May 9 2017, 3:47 PM · KWin
garg reassigned T6076: Scripts in /etc/profile.d/* don't get sourced from garg to davidedmundson.
May 9 2017, 2:26 PM · Plasma: Mobile
garg added a comment to T6076: Scripts in /etc/profile.d/* don't get sourced.

/etc/profile.d gets evaluated by bash but not simplelogin. David needs to look into this to get it working.

May 9 2017, 2:25 PM · Plasma: Mobile

May 8 2017

garg committed R257:a36b52227e29: Drop QtWebengine (authored by garg).
Drop QtWebengine
May 8 2017, 1:48 PM

Mar 3 2017

garg added a comment to T5505: kitchen not cooking drax mounts.

Why not simply mount the device to the relevant folder instead of having another level of indirection ?

Mar 3 2017, 11:45 AM · Neon
garg added a comment to T5505: kitchen not cooking drax mounts.

You also changed it in the jenkins master cookbook, which might or might not be relevant for other jenkins masters

Mar 3 2017, 11:32 AM · Neon
garg added a comment to T5505: kitchen not cooking drax mounts.

This looks inconsistent, why is one a link and the other a folder?

Mar 3 2017, 11:19 AM · Neon

Feb 17 2017

garg added a comment to D4639: Make it possible to use Ruby 2.4.0.

Why not just define these requirements in the Gemfile?

Feb 17 2017, 12:14 AM

Feb 13 2017

garg added a comment to D4596: Figure out the GTK version instead of using a hardcoded one.

I would argue that breeze-gtk should already have had this change in order to not break on systems where GTK is >= 3.20 and that introducing a new build-dep is the only way of fixing thee issue.

Feb 13 2017, 4:23 PM · Plasma
garg committed R98:5328755bf3dc: No need for WITH_GTK3_VERSION anymore (authored by garg).
No need for WITH_GTK3_VERSION anymore
Feb 13 2017, 4:23 PM
garg committed R98:7d34b41573d6: Merge branch 'Plasma/5.9' (authored by garg).
Merge branch 'Plasma/5.9'
Feb 13 2017, 4:23 PM
garg committed R98:d25084c791d8: Figure out the GTK version instead of using a hardcoded one (authored by garg).
Figure out the GTK version instead of using a hardcoded one
Feb 13 2017, 4:23 PM
garg closed D4596: Figure out the GTK version instead of using a hardcoded one by committing R98:d25084c791d8: Figure out the GTK version instead of using a hardcoded one.
Feb 13 2017, 4:23 PM · Plasma
garg updated the diff for D4596: Figure out the GTK version instead of using a hardcoded one.

Simplify setting up the variable

Feb 13 2017, 4:10 PM · Plasma
garg updated the diff for D4596: Figure out the GTK version instead of using a hardcoded one.

Don't cache string, set a CMAKE_MODULE_PATH too

Feb 13 2017, 4:07 PM · Plasma
garg added a comment to D4596: Figure out the GTK version instead of using a hardcoded one.

FTR, the reason this was not done at CMake time was to avoid depending on a development package (and associated dependencies like a compiler) to install something that's architecture-dependent. My first. local patch I made at the time used pkg_config, but it was discarded for this reason.

Not that I have hard feelings about this, should this be changed, but I just wanted to outline the rationale for it at the time.

Feb 13 2017, 4:03 PM · Plasma
garg updated the diff for D4596: Figure out the GTK version instead of using a hardcoded one.

Make finding GTK required, move find_package calls together

Feb 13 2017, 4:00 PM · Plasma
garg added a comment to D4596: Figure out the GTK version instead of using a hardcoded one.

This should ideally also be backported for Plasma 5.9

Feb 13 2017, 1:14 PM · Plasma
garg retitled D4596: Figure out the GTK version instead of using a hardcoded one from to Figure out the GTK version instead of using a hardcoded one.
Feb 13 2017, 12:41 PM · Plasma

Nov 9 2016

garg added a comment to T4495: git semaphore on slaves.

Last I checked we explicitly agreed no git on slaves. So I'm not favor of this till I get more info about why we're changing this requirement.

Nov 9 2016, 1:16 PM · Neon

Oct 4 2016

garg committed R108:13991f85eabb: Fix the build (authored by garg).
Fix the build
Oct 4 2016, 3:22 PM
garg committed R108:6199631604f9: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11 (authored by garg).
Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11
Oct 4 2016, 2:49 PM
garg closed D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11 by committing R108:6199631604f9: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.
Oct 4 2016, 2:49 PM · KWin
garg added inline comments to D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.
Oct 4 2016, 2:20 PM · KWin
garg updated the diff for D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.

Update

Oct 4 2016, 2:19 PM · KWin
garg updated the diff for D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.

Update as per comments

Oct 4 2016, 2:16 PM · KWin
garg added inline comments to D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.
Oct 4 2016, 2:10 PM · KWin
garg retitled D2933: Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11 from to Check for EGL_KHR_platform_x11 in addition to EGL_EXT_platform_x11.
Oct 4 2016, 1:56 PM · KWin

Sep 10 2016

garg committed R108:4f295f84c5cc: explicitly compare latin1 strings in qassert (fixes build with debugfull) (authored by garg).
explicitly compare latin1 strings in qassert (fixes build with debugfull)
Sep 10 2016, 6:27 AM
garg committed R108:b590f0a5c2c0: Merge branch 'KDE/4.9' (authored by garg).
Merge branch 'KDE/4.9'
Sep 10 2016, 6:16 AM
garg committed R108:dc5ba407c7bd: Fix the kwin KCM to read cascaded configs (authored by garg).
Fix the kwin KCM to read cascaded configs
Sep 10 2016, 6:16 AM
garg committed R34:6f7e83077374: KF5 Porting : kDebug() is now qDebug() (authored by garg).
KF5 Porting : kDebug() is now qDebug()
Sep 10 2016, 4:02 AM
garg committed R34:3214bb2263e5: Port to KF5 (authored by garg).
Port to KF5
Sep 10 2016, 4:02 AM

Aug 12 2015

garg added a member for Plasma: Mobile: garg.
Aug 12 2015, 2:14 PM

Aug 11 2015

garg accepted D240: Remove the hack to get DNS.

Ah cool, missed that.

Aug 11 2015, 10:28 AM · Plasma: Mobile
garg added a comment to D240: Remove the hack to get DNS.

Perhaps mobster needs to be fixed before this change lands ?

Aug 11 2015, 10:15 AM · Plasma: Mobile

Aug 7 2015

garg committed R22:18718399e85a: Fix contour build (authored by garg).
Fix contour build
Aug 7 2015, 10:16 AM
garg committed R25:abd2bf07b733: Write to the file (authored by garg).
Write to the file
Aug 7 2015, 9:27 AM
garg committed R25:3a6158481cfc: Bump version (authored by garg).
Bump version
Aug 7 2015, 9:27 AM
garg committed R25:54f28f74a336: Arch all package for now (authored by garg).
Arch all package for now
Aug 7 2015, 9:27 AM
garg committed R25:ab473c94c4d8: Manually write nameserver for now (authored by garg).
Manually write nameserver for now
Aug 7 2015, 9:27 AM
garg committed R25:7bd490c6c7b0: Make a native package (authored by garg).
Make a native package
Aug 7 2015, 9:27 AM
garg committed R25:90128bdebb4f: Add debian packaging (authored by garg).
Add debian packaging
Aug 7 2015, 9:27 AM
garg committed R25:c6c2670944ca: Initial import (authored by garg).
Initial import
Aug 7 2015, 9:27 AM
garg committed R27:abd2bf07b733: Write to the file (authored by garg).
Write to the file
Aug 7 2015, 9:24 AM
garg committed R27:3a6158481cfc: Bump version (authored by garg).
Bump version
Aug 7 2015, 9:24 AM
garg committed R27:ab473c94c4d8: Manually write nameserver for now (authored by garg).
Manually write nameserver for now
Aug 7 2015, 9:24 AM
garg committed R27:7bd490c6c7b0: Make a native package (authored by garg).
Make a native package
Aug 7 2015, 9:24 AM
garg committed R27:54f28f74a336: Arch all package for now (authored by garg).
Arch all package for now
Aug 7 2015, 9:24 AM
garg committed R27:c6c2670944ca: Initial import (authored by garg).
Initial import
Aug 7 2015, 9:24 AM
garg committed R27:90128bdebb4f: Add debian packaging (authored by garg).
Add debian packaging
Aug 7 2015, 9:24 AM