Create Task
Maniphest T12263

Port SubtitleComposer away from Kross
Closed, ResolvedPublic
Actions

Description

A new application in incubator is ussing Kross.

https://invent.kde.org/kde/subtitlecomposer

Related Objects
Search...

StatusAssignedTask
 OpenNoneT11545 Remove Kross
 Resolvedmaxrd2T12263 Port SubtitleComposer away from Kross
ognarb created this task.Nov 25 2019, 9:31 PM
ognarb triaged this task as Normal priority.
thiagosueto added a subscriber: thiagosueto.Sep 8 2020, 11:54 AM
thiagosueto added a subscriber: maxrd2.

Pinging @maxrd2 to take a look at this

maxrd2 added a comment.EditedSep 8 2020, 2:13 PM

What's wrong with kross?
I assume it won't be ported to use QJSEngine?

cordlandwehr added a subscriber: cordlandwehr.Sep 8 2020, 8:49 PM

Kross is practically unmaintained since before the port to Qt5, which is quite a lot of years right now.
Even for KF5 it was only marked to be a porting aid.

alex added a subscriber: alex.Aug 19 2021, 4:09 PM

@maxrd2 Is there even any logic in subtitlecomposer which can not use QJSEngine?

From looking at the repo I only see the examples which contain scripts in the other languages. Is this used by third parties?

Besides that I can only agree with what @cordlandwehr said. Also QtScript caused serious regressions in Plasma/KWin, because of that it was ported away from.

alex moved this task from Backlog to In Discussion on the KF6 board.Aug 22 2021, 7:26 PM
maxrd2 added a comment.Aug 30 2021, 12:43 PM

@alex there isn't - will remove kross dependency for the next SC release.

alex moved this task from In Discussion to In Progress on the KF6 board.Aug 30 2021, 12:57 PM
alex assigned this task to maxrd2.

Very cool, thanks.

maxrd2 added a comment.Oct 8 2021, 10:27 AM

Initial work on replacing Kross with QJSEngine is completed in SubtitleComposer on branch here: https://invent.kde.org/multimedia/subtitlecomposer/-/tree/work/scripting.

JS scripts seem to be working fine. Will include these changes in next release.

I suppose this one could be closed now.

alex moved this task from In Progress to Done on the KF6 board.Oct 8 2021, 11:31 AM

Okay, moving it on the workboard.

Could you maybe reference this task and a bit of the rationale in the commit message?