blaze (Mikołaj Płomieński)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 13 2016, 11:22 AM (195 w, 1 d)
Availability
Available

Recent Activity

May 5 2020

blaze added a comment to D29017: WIP: Introduce three new methods that return all "entries" in a folder.

Check this commit message https://phabricator.kde.org/R32:f56cdda54b7f88b119f2c7cfb2f534b4fe74478f

May 5 2020, 8:47 PM · Frameworks

Jan 17 2020

blaze added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

I was debugging the code locally and here's what I found: simple wildcard like * is being replaced with cool stuff like \\A(?:[^/]*)\\z.
As you can see, this pattern excludes forward slashes, which may be a good thing for a file path, but it is exactly the source of the problem in this case.
So here's my debug code, which was tested by me and it works:

Jan 17 2020, 2:50 PM · Frameworks

Jan 16 2020

blaze added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

I still fail to see what's broken, I tested with the system kwallet (5.65 on tumbleweed) and I don't see any difference between it and a build from a git checkout; i.e. falkon doesn't show the saved passwords after restarting it. I've already submitted another diff to fix the doubly-anchored pattern issue.

Jan 16 2020, 5:20 PM · Frameworks

Jan 15 2020

blaze added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

otherwise, we could just revert this patch

Jan 15 2020, 8:38 PM · Frameworks
blaze added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.
QMap<QString, QByteArray> entries;
if (m_wallet->readEntryList("*", entries) != 0) {
    qWarning() << "KWalletPasswordBackend::initialize Cannot read entries!";
    return;
}
Jan 15 2020, 7:01 PM · Frameworks
blaze added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

A test case of what is broken would be appreciated, to try and fix/debug the issue.

Jan 15 2020, 4:32 PM · Frameworks
blaze added inline comments to D26205: KWallet: Port QRegExp to QRegularExpression.
Jan 15 2020, 3:49 PM · Frameworks
blaze added a comment to D26205: KWallet: Port QRegExp to QRegularExpression.

This changeset breaks the app, making it impossible to get the list of entries from outside. Tested against Falkon browser with KDE integration plugin. See my inline comments here

Jan 15 2020, 1:55 PM · Frameworks

Jan 3 2020

blaze added a comment to T12486: Email client for 20.04 LTS?.

Is this discussion relevant? Just to have a reference of what is wrong with KMail

Jan 3 2020, 1:26 PM · Kubuntu

Apr 27 2018

blaze added a comment to D12115: FFMpeg plugin cleanup.

What you could do, is to ask on the distributions@k.o list, to find out who ships what. FreeBSD, for instance, has /usr/local/lib/libavformat.so.57.83.100 so that looks like it would be ok. Debian stable, on the other hand ..

Apr 27 2018, 9:19 PM
blaze added a comment to D12115: FFMpeg plugin cleanup.

Before your changes, the code works for quite old versions of libavformat, after your change it requires libavformat > 56 (?), so you are changing the requirements.

Apr 27 2018, 4:05 PM
blaze added a comment to D12115: FFMpeg plugin cleanup.

Are you planning to do more cleanups? There is quite some more stuff, e.g. in https://phabricator.kde.org/source/k3b/browse/master/CMakeLists.txt

I think a proper version check for libavcodec/libavformat should be added to the toplevel CMakeLists.txt first, as you are relying on it here.

Apr 27 2018, 3:56 PM

Apr 26 2018

blaze added a reviewer for D12115: FFMpeg plugin cleanup: pino.
Apr 26 2018, 6:44 AM
blaze added a reviewer for D12174: FFMpeg plugin: port away from deprecated data structure: pino.
Apr 26 2018, 6:43 AM

Apr 13 2018

blaze requested review of D12174: FFMpeg plugin: port away from deprecated data structure.
Apr 13 2018, 3:23 PM
blaze added a dependent revision for D12115: FFMpeg plugin cleanup: D12174: FFMpeg plugin: port away from deprecated data structure.
Apr 13 2018, 3:23 PM

Apr 11 2018

blaze requested review of D12115: FFMpeg plugin cleanup.
Apr 11 2018, 2:48 PM

Apr 2 2018

blaze updated the diff for D11634: K3b FFMpeg Decoder Plugin Fix.

After my research on libswresample topic I started to think that it's not a good solution for this situation, quite the opposite even. It still requires format conversions which renders the code to a much more complex state. So no advantages here really.

Apr 2 2018, 3:42 PM

Mar 27 2018

blaze updated the diff for D11634: K3b FFMpeg Decoder Plugin Fix.

Final revision.
UPD: not really :D

Mar 27 2018, 12:40 PM
blaze updated the diff for D11634: K3b FFMpeg Decoder Plugin Fix.

Hello. I decided to rework the patch since some important changes happened:

Mar 27 2018, 7:42 AM

Mar 25 2018

blaze updated the diff for D11634: K3b FFMpeg Decoder Plugin Fix.

Check if it's safe to deallocate the buffer and to move the pointer

Mar 25 2018, 9:44 AM
blaze updated the diff for D11634: K3b FFMpeg Decoder Plugin Fix.

delete -> delete[]

Mar 25 2018, 6:57 AM

Mar 24 2018

blaze updated the diff for D11634: K3b FFMpeg Decoder Plugin Fix.

Rebased to the current master

Mar 24 2018, 1:18 PM
blaze added a comment to D11634: K3b FFMpeg Decoder Plugin Fix.

I'll probably need the commit access to commit these changes

Mar 24 2018, 7:18 AM
blaze requested review of D11634: K3b FFMpeg Decoder Plugin Fix.
Mar 24 2018, 7:17 AM

Nov 15 2017

blaze added a comment to T7452: Add kwalletcli to kubuntu-packaging.

pinentry-kwallet is not a replacement for pinentry-qt or pinentry-gtk binaries (that's what I was thinking). It just kind of works on top of them. Too bad this fact is not documented anywhere.

Nov 15 2017, 3:18 PM · Kubuntu
blaze added a comment to T7452: Add kwalletcli to kubuntu-packaging.

I realized that there's no need for these changes. Actually they can even break something. Also the project is not a part of KDE Apps https://www.mirbsd.org/kwalletcli.htm
Sorry for the noise

Nov 15 2017, 2:52 PM · Kubuntu

Oct 8 2017

blaze added a comment to D8202: Fix Qt 5.5 compatibility -- no constFirst/Last methods..

None of these are in performance-relevant code, so I don't believe it's worthwhile adding ifdefs; just revert this patch whenever 5.5 support is dropped.

Possible problems: the person bumping min qt version to > 5.5 will not remember about this. And the same for the next person "fixing" this non-const calls.

So while ifdef adds some another code variant which makes test coverage worse, it still help cleaning up the code on version bumps and prevents compat-breaking "fixing". So I would opt for ifdef.

Oct 8 2017, 7:10 PM