Remove legacy code. This code is targeting APIs that do not exist for years, making everything look cluttered, practically preventing further improvements to this plugin.
Details
Diff Detail
- Repository
- R467 K3b
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Are you planning to do more cleanups? There is quite some more stuff, e.g. in https://phabricator.kde.org/source/k3b/browse/master/CMakeLists.txt
I think a proper version check for libavcodec/libavformat should be added to the toplevel CMakeLists.txt first, as you are relying on it here.
I was planning to port the code to the current API and then reflect all those changes at once inside CMake files (one more patch).
But was it me who added libavformat dependency here? I don't think so.
Before your changes, the code works for quite old versions of libavformat, after your change it requires libavformat > 56 (?), so you are changing the requirements.
What you could do, is to ask on the distributions@k.o list, to find out who ships what. FreeBSD, for instance, has /usr/local/lib/libavformat.so.57.83.100 so that looks like it would be ok. Debian stable, on the other hand ..