Differential D12174

FFMpeg plugin: port away from deprecated data structure
Needs ReviewPublic
Actions

Authored by blaze on Apr 13 2018, 3:23 PM.

Details

Reviewers
lesliezhai
Summary

This patch depends on D12115 (FFMpeg plugin cleanup)

This patch removes a bunch of deprecation warnings, provides more clean and readable code. Also replaces numeric literals "0" with nullptr, where it's necessary, to prevent the confusion with the integer type.

Diff Detail

Repository
R467 K3b
Lint
Lint Skipped
Unit
Unit Tests Skipped
blaze requested review of this revision.Apr 13 2018, 3:23 PM
blaze created this revision.
blaze created this object with visibility "All Users".
blaze added a reviewer: pino.Apr 26 2018, 6:43 AM
blaze added subscribers: lesliezhai, pino.
pino removed a reviewer: pino.Apr 26 2018, 8:39 PM
ltoscano changed the visibility from "All Users" to "Public (No Login Required)".Apr 27 2018, 3:07 PM
pino removed a subscriber: pino.Apr 27 2018, 4:55 PM
adridg added a subscriber: adridg.Apr 27 2018, 7:39 PM
adridg added inline comments.
plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp
89

Is there a special reason you're moving this around? (I can imagine: sort by size, as recommended for structure packing)

134

That doesn't match the #definition of FFMPEG_CODEC that you removed? Or is that an API change in avformat?

167

Indent further to make it more obvious this is a continuation

Revision Contents
Changeset List

Diff 32066

View Options

plugins/decoder/ffmpeg/k3bffmpegwrapper.cpp

Loading...