Feed Advanced Search

Jan 20 2019

rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

I agree that reducing the size column width isn't as easy as I thought. I find it takes up more space than necessary when horizontal space is at a premium and I was hoping to get a more compact read-out that can still be interpreted ... and that would show itself in full in a tooltip.

Jan 20 2019, 9:56 AM · Frameworks

Jan 19 2019

rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).
If there's still enough room to show everything without a horizontal scrollbar, then we're still good.
Jan 19 2019, 10:12 PM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Jan 19 2019, 10:11 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

tentative fix for "very narrow views".

Jan 19 2019, 10:08 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

Maybe we can incorporate some more intelligence here

Jan 19 2019, 6:41 PM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Jan 19 2019, 11:47 AM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

Setting explicit sizes is best done in a mode that supports doing so... =/
Also, sections can be movable (again) now (I often like to see dates first, sizes 2nd).

Jan 19 2019, 11:47 AM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Jan 19 2019, 10:17 AM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

I realised the 1st version introduced a regression. This update restores automatic sizing when the dialog is resized.
The fix currently has the effect of undoing any column sizing the user may have done before resizing the entire dialog, but that doesn't seem entirely unjustified. It won't be hard to preserve the interactive resize mode for sections that have a custom size but AFAIAC we can put off implementing that until there's a clear demand for it.

Jan 19 2019, 10:17 AM · Frameworks
rjvbb requested review of D18380: KIO: make file dialog columns resizable again (and movable).
Jan 19 2019, 10:10 AM · Frameworks

Jan 17 2019

rjvbb set the repository for D15797: [kdev-clazy] : use canonical paths to R32 KDevelop.
Jan 17 2019, 3:10 PM · KDevelop
rjvbb updated the diff for D15797: [kdev-clazy] : use canonical paths.

Updated as requested.

Jan 17 2019, 3:09 PM · KDevelop
rjvbb added inline comments to D15797: [kdev-clazy] : use canonical paths.
Jan 17 2019, 3:09 PM · KDevelop

Jan 15 2019

rjvbb committed R32:c088890cefbd: CMake plugin: don't hardcode a default install prefix. (authored by rjvbb).
CMake plugin: don't hardcode a default install prefix.
Jan 15 2019, 7:28 PM
rjvbb closed D17255: KDevelop: support for installing into a non-standard parallel prefix.
Jan 15 2019, 7:28 PM · KDevelop

Jan 14 2019

rjvbb added a comment to D17308: Make CTags/Projects context menu more accessible.

Should I check if current master works as I intended, WITHOUT your patch, because it does not apply to current master.

Jan 14 2019, 11:02 AM · Kate

Jan 13 2019

rjvbb set the repository for D17255: KDevelop: support for installing into a non-standard parallel prefix to R32 KDevelop.
Jan 13 2019, 10:30 PM · KDevelop
rjvbb added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Jan 13 2019, 10:30 PM · KDevelop
rjvbb updated the diff for D17255: KDevelop: support for installing into a non-standard parallel prefix.

placeholder text + dropped manpageplugin hunk.

Jan 13 2019, 10:30 PM · KDevelop

Jan 12 2019

rjvbb added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Jan 12 2019, 3:04 PM · KDevelop
rjvbb set the repository for D17255: KDevelop: support for installing into a non-standard parallel prefix to R32 KDevelop.
Jan 12 2019, 3:03 PM · KDevelop
rjvbb updated the diff for D17255: KDevelop: support for installing into a non-standard parallel prefix.

Adds tooltip to the import dialog's "Installation Prefix" entrie widget.

Jan 12 2019, 3:03 PM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
Note that environment variables are per-process, not per-thread.
Jan 12 2019, 1:40 PM · KDevelop
rjvbb added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

Milian Wolff wrote on 20190112::12:35:11 re: "D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions"

Jan 12 2019, 1:30 PM · KDevelop

Jan 10 2019

rjvbb committed R32:41a0f0ce5197: clang: detect Clang builtin dirs at runtime on Unix (authored by rjvbb).
clang: detect Clang builtin dirs at runtime on Unix
Jan 10 2019, 9:52 PM
rjvbb closed D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Jan 10 2019, 9:52 PM · KDevelop
rjvbb set the repository for D17858: clang: Also detect Clang builtin dirs at runtime on Unix to R32 KDevelop.
Jan 10 2019, 4:23 PM · KDevelop
rjvbb updated the diff for D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

+++V

Jan 10 2019, 4:23 PM · KDevelop
rjvbb added inline comments to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Jan 10 2019, 3:04 PM · KDevelop
rjvbb set the repository for D17858: clang: Also detect Clang builtin dirs at runtime on Unix to R32 KDevelop.
Jan 10 2019, 11:20 AM · KDevelop
rjvbb updated the diff for D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

++V

Jan 10 2019, 11:20 AM · KDevelop

Jan 9 2019

rjvbb set the repository for D17858: clang: Also detect Clang builtin dirs at runtime on Unix to R32 KDevelop.
Jan 9 2019, 8:01 PM · KDevelop
rjvbb updated the diff for D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

V3

Jan 9 2019, 8:01 PM · KDevelop
rjvbb added a comment to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

Should I de-obfuscate and remove that lambda expression too while we're at it? Its body could be the body of clangBuiltinIncludePath() itself, AFAICT.

Jan 9 2019, 7:58 PM · KDevelop
rjvbb set the repository for D17858: clang: Also detect Clang builtin dirs at runtime on Unix to R32 KDevelop.
Jan 9 2019, 3:16 PM · KDevelop
rjvbb updated the diff for D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

Updated as discussed in my previous comment. I've also followed flherne's suggestion to move the check for the reference file file into ClangHelpers::clangBuiltinIncludePath(). This does require some changes elsewhere because it can now fail (return an empty string).

Jan 9 2019, 3:16 PM · KDevelop
rjvbb added a comment to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

Perhaps the check found in plugins/clang/clangsupport.cpp:185 should be moved into this function

Jan 9 2019, 3:03 PM · KDevelop

Jan 4 2019

rjvbb added a comment to D17278: Meson plugin: First working version.

arrowd accepted this revision.
arrowd added a comment.

Jan 4 2019, 4:20 PM · Documentation, KDevelop

Dec 29 2018

rjvbb added a comment to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Users shouldn't change the dependencies and expect things to work without a rebuild.
Dec 29 2018, 10:13 PM · KDevelop
rjvbb requested review of D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Dec 29 2018, 7:24 PM · KDevelop

Dec 27 2018

rjvbb added a comment to D17794: Pkg-config plugin.
Shouldn't these come from the project manager?
Dec 27 2018, 9:06 AM · KDevelop

Dec 26 2018

rjvbb added a comment to D17794: Pkg-config plugin.

Yes, I'm hoping that others will chime in here on this aspect too.

Dec 26 2018, 12:54 PM · KDevelop
rjvbb added a comment to D17794: Pkg-config plugin.

Again, I strongly doubt that you can build kdevelop and all of its dependencies without having pkgconfig installed. Someone using kdevelop for development with libraries that provide .pc files will almost certainly have pkgconfig installed too. So really, the platform argument is moot IMHO. But if you really want to push it: as a Mac user I can guarantee that we (as in developers working on Mac) will have pkgconfig installed through one of a handful of package managers which we'll also be using to install the libraries we need for our development. IOW, pkgconfig *will* be installed in a more-or-less standard location (certainly considered standard on the local set-up) and you can bet it's on the path. Having used cygwin extensively in the past I am certain pkgconfig will be on the path in that universe too, and in the end that's all that counts (if you cannot configure the location of the executable).

Dec 26 2018, 8:59 AM · KDevelop

Dec 25 2018

rjvbb added a comment to D17794: Pkg-config plugin.

Continuing from a few thoughts I launched on the original T10209, mainly aimed at keeping the project configuration dialog's left side-bar as unencumbered as possible. I think the current plugin could be merged into the customdefinesandincludes plugin because it provides a programmatic way to add include paths and/or defines.

Dec 25 2018, 4:45 PM · KDevelop
rjvbb added a comment to T10209: Pull request - pkg-config plugin.
This plugin may be useful for any c/c++ project. For example indexer for CMake project KDevelop (sources of ide) don't see all required includes for me.
Dec 25 2018, 2:37 PM · KDevelop
rjvbb added a comment to T10209: Pull request - pkg-config plugin.

That could be useful for project managers that lack proper build system integration (IOW, there shouldn't be much use for it with the CMake and QMake project managers?)

Dec 25 2018, 9:51 AM · KDevelop

Dec 14 2018

rjvbb committed R495:72ea330791f0: remove obsolete comment (authored by rjvbb).
remove obsolete comment
Dec 14 2018, 12:07 PM
rjvbb committed R32:dc6a95e9628c: 2 missing KTextEditorPluginIntegration::MainWindow slots (authored by rjvbb).
2 missing KTextEditorPluginIntegration::MainWindow slots
Dec 14 2018, 8:49 AM
rjvbb closed D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.
Dec 14 2018, 8:49 AM · KDevelop

Dec 11 2018

rjvbb added a comment to D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.

No objections?

Dec 11 2018, 3:33 PM · KDevelop

Dec 10 2018

rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

The current master is fontconfig only, since there is no way to leave the fontconfig specific parts out of QML.

Dec 10 2018, 8:49 PM · Plasma: KCM Redesign
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

It's not clear who wrote that about being fontconfig specific (or the IMHO incorrect suggestion that Freetype is implemented 3x).

Dec 10 2018, 7:31 PM · Plasma: KCM Redesign
rjvbb added a comment to M133: Fonts KCM simple vs advanced modes.

Why not make these separate KCMs? I don't know how usual it is to open just the fonts KCM (kcmshell5 fonts) or if the vast majority of users gets to that config page only via the systemsettings app. For those you don't need to implement a tab-like mode switch because systemsettings already provides that for different KCMs. And users who go through kcmshell5 can probably learn quite easily to modify their commandline.
This approach also means you don't have to worry about whether and how to implement mode persistence.

Dec 10 2018, 6:22 PM · Plasma: KCM Redesign
rjvbb closed D17314: Projects Plugin: Add ShellCheck analyzer.

Fixed in 66a84c9e0f94351b8f328f3c0af259983bfc1592

Dec 10 2018, 1:15 PM · Kate
rjvbb added a comment to D17314: Projects Plugin: Add ShellCheck analyzer.

I can commit if you want (if nobody else beats me to it).

Dec 10 2018, 12:29 PM · Kate
rjvbb reopened D17314: Projects Plugin: Add ShellCheck analyzer.

I'm not finding any information on a QStringLiteral header file in the official documentation; it certainly doesn't exist in Qt 5.9.7 yet. AFAIK the header to include is the one for QString.

Dec 10 2018, 12:10 PM · Kate
rjvbb committed R40:1b5396cedbbc: set icon and title on the CTags/Configure dialog (authored by rjvbb).
set icon and title on the CTags/Configure dialog
Dec 10 2018, 10:13 AM
rjvbb added a comment to D16779: kate-ctags plugin: support KDevelop (WIP).

Better late than never: I also figured out how to make the plugin's toolview display correctly in KDevelop: https://commits.kde.org/kate/3cd03f408eed2d66ae008fb8349f8b5af24260e9

Dec 10 2018, 9:43 AM · KDevelop, KTextEditor, Kate
rjvbb updated the test plan for D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.
Dec 10 2018, 9:40 AM · KDevelop
rjvbb committed R40:3cd03f408eed: CTags plugin : missed KDevelop integration aspects (authored by rjvbb).
CTags plugin : missed KDevelop integration aspects
Dec 10 2018, 9:29 AM

Dec 9 2018

rjvbb requested review of D17465: KDevelop/Shell : add 2 missing KTextEditorPluginIntegration::MainWindow slots.
Dec 9 2018, 10:06 PM · KDevelop
rjvbb committed R40:9af81dd535c7: CTags plugin: make usable in KDevelop (authored by rjvbb).
CTags plugin: make usable in KDevelop
Dec 9 2018, 7:39 PM
rjvbb closed D16779: kate-ctags plugin: support KDevelop (WIP).
Dec 9 2018, 7:39 PM · KDevelop, KTextEditor, Kate
rjvbb committed R32:a5ca3cd1b0a3: polish Purpose integration in the PatchReview plugin (authored by rjvbb).
polish Purpose integration in the PatchReview plugin
Dec 9 2018, 7:13 PM
rjvbb closed D17424: KDevelop/PatchReview: polish Purpose integration.
Dec 9 2018, 7:13 PM · KDevelop

Dec 8 2018

rjvbb requested review of D17424: KDevelop/PatchReview: polish Purpose integration.
Dec 8 2018, 9:10 AM · KDevelop

Dec 7 2018

rjvbb committed R495:8002a0259daf: add missing properties (authored by rjvbb).
add missing properties
Dec 7 2018, 9:20 PM
Restricted Application added a project to D1420: [OS X] build in a more "traditional" way (for distribution systems like MacPorts, Fink etc) (and a bit of code clean-up): KDE Edu.
Dec 7 2018, 7:10 PM · KDE Edu, Marble
rjvbb updated the diff for D1420: [OS X] build in a more "traditional" way (for distribution systems like MacPorts, Fink etc) (and a bit of code clean-up).

Refactored for current git/master.

Dec 7 2018, 6:45 PM · KDE Edu, Marble

Dec 6 2018

rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

This revision was not accepted when it landed; it landed in state "Needs Review".

Dec 6 2018, 10:03 AM · Plasma
rjvbb closed D4929: DrKonqi : lldb and Mac support.
Dec 6 2018, 9:57 AM · Plasma
rjvbb committed R871:13121f4a303b: lldb and Mac support (authored by rjvbb).
lldb and Mac support
Dec 6 2018, 9:57 AM

Dec 5 2018

rjvbb added a reverting change for R302:3af09cd83051: ksvg2icns: use QCoreApplication instead of QGuiApplication: R302:dde8ded03158: Revert "ksvg2icns: use QCoreApplication instead of QGuiApplication".
Dec 5 2018, 4:05 PM
rjvbb committed R302:dde8ded03158: Revert "ksvg2icns: use QCoreApplication instead of QGuiApplication" (authored by rjvbb).
Revert "ksvg2icns: use QCoreApplication instead of QGuiApplication"
Dec 5 2018, 4:05 PM
rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Dec 5 2018, 3:05 PM · KDevelop, KTextEditor, Kate
rjvbb updated the diff for D16779: kate-ctags plugin: support KDevelop (WIP).

Updated as requested.

Dec 5 2018, 3:04 PM · KDevelop, KTextEditor, Kate
rjvbb committed R302:4bb76d8882a9: ksvg2icns : use QStringLiteral() (authored by rjvbb).
ksvg2icns : use QStringLiteral()
Dec 5 2018, 11:47 AM
rjvbb committed R302:2e32fcb53175: ksvg2icns : use Qt 5.9+ QTemporaryDir API (authored by rjvbb).
ksvg2icns : use Qt 5.9+ QTemporaryDir API
Dec 5 2018, 11:47 AM
rjvbb committed R302:3af09cd83051: ksvg2icns: use QCoreApplication instead of QGuiApplication (authored by rjvbb).
ksvg2icns: use QCoreApplication instead of QGuiApplication
Dec 5 2018, 11:47 AM

Dec 4 2018

rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Dec 4 2018, 8:53 PM · KDevelop, KTextEditor, Kate
rjvbb updated the diff for D16779: kate-ctags plugin: support KDevelop (WIP).

undesirable qWarning() removed

Dec 4 2018, 8:52 PM · KDevelop, KTextEditor, Kate

Dec 3 2018

rjvbb set the repository for D17289: KDevelop/Shell: set dedicated TMPDIR to R32 KDevelop.
Dec 3 2018, 11:02 AM · KDevelop
rjvbb updated the diff for D17289: KDevelop/Shell: set dedicated TMPDIR.

FIxed and streamlined version.

Dec 3 2018, 11:01 AM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
Also, considering that "session" in `Core::initialize` is user-specified and defaults to an empty string, please do not use a 100% deterministic name,
Dec 3 2018, 10:21 AM · KDevelop
rjvbb added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

No, it went beyond that: the original underlying principle was "don't assume or hardcode /usr/local anywhere, use whatever install prefix the user specified".

Dec 3 2018, 9:02 AM · KDevelop

Dec 2 2018

rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Actually, issues with clang temp files is why I started to think about this kind of change but ultimately I realised it didn't seem such a bad idea at all to put all KDevelop-related temporary files in a dedicated location. I often clean out a bunch of KDevelop's own temp files that were left behind, e.g. after a crash. I just didn't mention them because they're negligible in size (and I purge before their numbers really start to grow).

Dec 2 2018, 9:26 PM · KDevelop
rjvbb added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.
On Linux quite possibly too, I think many packaging systems install into some temporary dir and then copy the deployment out of there for archiving.
Dec 2 2018, 9:13 PM · KDevelop

Dec 1 2018

rjvbb requested review of D17289: KDevelop/Shell: set dedicated TMPDIR.
Dec 1 2018, 7:56 PM · KDevelop
rjvbb set the repository for D17255: KDevelop: support for installing into a non-standard parallel prefix to R32 KDevelop.
Dec 1 2018, 11:04 AM · KDevelop
rjvbb updated the diff for D17255: KDevelop: support for installing into a non-standard parallel prefix.

The python script changes were committed to the master branch as requested (db05710cb6931a7b44d7fc70bfcfe75c7ccc9f4a).

Dec 1 2018, 11:04 AM · KDevelop
rjvbb committed R32:db05710cb693: QMLJS plugin: Use dynamic interpreter lookup in python scripts (authored by rjvbb).
QMLJS plugin: Use dynamic interpreter lookup in python scripts
Dec 1 2018, 10:15 AM
rjvbb committed R32:7898bb4174e3: fix version detection in test_cmakeserver (authored by rjvbb).
fix version detection in test_cmakeserver
Dec 1 2018, 9:46 AM

Nov 30 2018

rjvbb committed R495:f338282db51e: DiffListModel::refresh(): return at once when already active. (authored by rjvbb).
DiffListModel::refresh(): return at once when already active.
Nov 30 2018, 9:39 PM
rjvbb committed R495:36b17c15e01b: phabricator plugin: use Arcanist's diff.rev. order (authored by rjvbb).
phabricator plugin: use Arcanist's diff.rev. order
Nov 30 2018, 9:29 PM
rjvbb added a comment to D17255: KDevelop: support for installing into a non-standard parallel prefix.

The change doesn't change the default, but why would using '/usr' (instead of '/usr/local') be worse than using 'c:\Program Files' under MS Windows?

Nope. It *does* change the default if KDevelop's install prefix is not /usr/local.

Nov 30 2018, 2:57 PM · KDevelop
rjvbb added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 1:55 PM · KDevelop
rjvbb requested review of D17255: KDevelop: support for installing into a non-standard parallel prefix.
Nov 30 2018, 11:38 AM · KDevelop

Nov 27 2018

rjvbb added a comment to D4929: DrKonqi : lldb and Mac support.

David, it seems our posts crossed, or did you actually see the new version I just uploaded?

Nov 27 2018, 12:01 PM · Plasma
rjvbb set the repository for D4929: DrKonqi : lldb and Mac support to R871 DrKonqi.
Nov 27 2018, 12:00 PM · Plasma
rjvbb updated the diff for D4929: DrKonqi : lldb and Mac support.

Fixed the AppleTerminal oversight in the non-Apple lldbrc.

Nov 27 2018, 11:59 AM · Plasma