Make CTags/Projects context menu more accessible
Needs ReviewPublic

Authored by gregormi on Sun, Dec 2, 1:43 PM.

Details

Reviewers
None
Group Reviewers
Kate
Summary
  • CTags: Move the actions out of the submenus to the root level of the context menu
  • Projects: Move the Lookup action to root level of context menu

Both: Remove the code that inserts the text that is about to be searched to the action text.
Reasons:

  1. Those actions are super-useful
  2. Improves the discoverability of the Projects Code Index
  3. It simplifies the code by removing the dynamic item text logic (the user will see what is being searched as soon as the search is started anyway).

Screenshot:

Diff Detail

Repository
R40 Kate
Branch
arcpatch-D17308
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5829
Build 5847: arc lint + arc unit
gregormi created this revision.Sun, Dec 2, 1:43 PM
Restricted Application added a project: Kate. · View Herald TranscriptSun, Dec 2, 1:43 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
gregormi requested review of this revision.Sun, Dec 2, 1:43 PM
gregormi edited the summary of this revision. (Show Details)Sun, Dec 2, 1:45 PM
gregormi added a reviewer: Kate.
gregormi edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.Sun, Dec 2, 6:41 PM

Oh wow, this would be awesome. This is only visible if the CTags plugin is active, right?

With this change, it might make sense to remove the CTags: on the beginning of the labels.

addons/kate-ctags/kate_ctags_view.cpp
66

While you're touching this user-facing string, let's fix the grammar for all the places where it's currently wrong, because "lookup" is a noun, not a verb.

Lookup Selected Text -> Look Up Selected Text

sars added a subscriber: sars.Sun, Dec 2, 7:36 PM

What if you have Project, CTags and the new Zeal plugins active? You need to differentiate them somehow.

Optimally for Kate, we would get the go to definition/declaration/back to the project plugin and we would not need the CTags plugin any more. If we at some point would have both plugins with multiple actions, the menu could become quite long.

As it is right now for the project plugin, it is a bit strange to have a sub-menu for one action, but we could get more....

dhaumann added inline comments.
addons/kate-ctags/ui.rc
3

I think you have to increase the version number, otherwise caching of the ui files by KXMLGUI will lead to issues.

addons/project/ui.rc
3

Same here: version++

gregormi updated this revision to Diff 47133.Sat, Dec 8, 5:18 PM
gregormi edited the summary of this revision. (Show Details)
  • Fix texts and increase versions in .rc files
gregormi edited the summary of this revision. (Show Details)Sat, Dec 8, 5:19 PM