The current master is fontconfig only, since there is no way to leave the fontconfig specific parts out of QML.
It's not clear who wrote that about being fontconfig specific (or the IMHO incorrect suggestion that Freetype is implemented 3x).
Why not make these separate KCMs? I don't know how usual it is to open just the fonts KCM (kcmshell5 fonts) or if the vast majority of users gets to that config page only via the systemsettings app. For those you don't need to implement a tab-like mode switch because systemsettings already provides that for different KCMs. And users who go through kcmshell5 can probably learn quite easily to modify their commandline.
This approach also means you don't have to worry about whether and how to implement mode persistence.
I can commit if you want (if nobody else beats me to it).
I'm not finding any information on a QStringLiteral header file in the official documentation; it certainly doesn't exist in Qt 5.9.7 yet. AFAIK the header to include is the one for QString.
Better late than never: I also figured out how to make the plugin's toolview display correctly in KDevelop: https://commits.kde.org/kate/3cd03f408eed2d66ae008fb8349f8b5af24260e9
Sun, Dec 9
Sat, Dec 8
Fri, Dec 7
Refactored for current git/master.
Thu, Dec 6
This revision was not accepted when it landed; it landed in state "Needs Review".
Wed, Dec 5
Updated as requested.
Tue, Dec 4
undesirable qWarning() removed
Mon, Dec 3
FIxed and streamlined version.
Also, considering that "session" in `Core::initialize` is user-specified and defaults to an empty string, please do not use a 100% deterministic name,
No, it went beyond that: the original underlying principle was "don't assume or hardcode /usr/local anywhere, use whatever install prefix the user specified".
Sun, Dec 2
Actually, issues with clang temp files is why I started to think about this kind of change but ultimately I realised it didn't seem such a bad idea at all to put all KDevelop-related temporary files in a dedicated location. I often clean out a bunch of KDevelop's own temp files that were left behind, e.g. after a crash. I just didn't mention them because they're negligible in size (and I purge before their numbers really start to grow).
On Linux quite possibly too, I think many packaging systems install into some temporary dir and then copy the deployment out of there for archiving.
Sat, Dec 1
The python script changes were committed to the master branch as requested (db05710cb6931a7b44d7fc70bfcfe75c7ccc9f4a).
Fri, Nov 30
The change doesn't change the default, but why would using '/usr' (instead of '/usr/local') be worse than using 'c:\Program Files' under MS Windows?
Nope. It *does* change the default if KDevelop's install prefix is not /usr/local.
Tue, Nov 27
David, it seems our posts crossed, or did you actually see the new version I just uploaded?
Fixed the AppleTerminal oversight in the non-Apple lldbrc.
Mon, Nov 26
A more complete draft:
Sun, Nov 25
You will notice that I plan to maintain an option to disable the Apple-specific behaviour for anyone who depends on the current behaviour (that includes me, but your script would also continue to work). Cf. the APPLE_FORCE_X11 option
Allowing negative prios makes sense.
Sat, Nov 24
Fri, Nov 23
Can we set DATAROOTDIR=/Library/Application Support/KDE so that everything remains nicely bundled?
At that time hinting with freetype wasn't state of the art due to patent issues, but that has changed with the v40 engine in freetype 2.7.
The current KCM already has a control for that.
Found this by accident, and had only one immediate thought
That'll probably be when we move to Qt6.
Thu, Nov 22
includes the root cmake file changes.
a find_packge for `KF5::WindowSystem` is missing in the root CMakeLists file.
Can you rebase it over the last master branch ?
FWIW, anyone can request changes to a review, but also accept it. And while I would probably not take that as a green light to commit unless it comes from a known KDE dev it *does* go to show demand/need for a change. And hopefully, confirmation that it doesn't only work for the author.
Refactored for the standalone DrKonqi repo and disabled the integration testing on Mac.
Sorry, I had updating this on my list but it drifted to the bottom...
Wed, Nov 21
Actually, I realise this patch too is a somewhat stripped down version of a patch I've been using for a long time in my MacPorts packaging for Okular:
@rjvbb what do you say? makes sense?
This change does more than just enabling hidpi support in the plist.
Tue, Nov 20
Found back my ML post entitled
("compiledb-generator and the generic Makefile proj.manager"). Francis Herne replied
That must have been magic code then, quick, try to catch it, we all want that ;)
Not supported, since in your case KDevelop simply does not know a compile_commands.json exist,
Mon, Nov 19
Well, apparently the contextmenu CAN change during a session (at least on Mac and when I open it in different opened-at-session-load documents when the initial project load and parsing activity is still in progress).
This implements and uses my idea of an ecm_add_<lang>_compiler_flags_if_supported function set for C and C++. It uses compiler ID+version conditions to determine if flag(s) are supported when those conditions are known and reliable - otherwise and only then does it resort to querying the compiler.
E.g. I would have expected before looking at things that each view has their own separate context menu instance, possibly even created on the fly per display :)
Another fix: use the active MainWindow as the parent of the contextMenuData instance and do NOT delete it in the TextDocumentPrivate dtor.
Sun, Nov 18
Apologies, the tear-off bit shouldn't have been included of course.
updated as suggested:
- moves the context menu added stuff logic into a dedicated class (as an upbeat to possible future improvement)
- caches the QMenu* to which actions were last added, and removes them from that menu when the next context menu is shown. This should be equivalent to removing the items on contextMenuAboutToHide.
Sh@@t, sorry, I allowed some unrelated (and potential future) changes to pollute this version. Will fix tomorrow.
I would see the flaw also in that there is no specification in the KTextEditor API how the context menu is shared/reused.
Sat, Nov 17
I've made a few more usability changes, and renamed the new menu action to "Configure..." because it corresponds to what the action does.
In case anyone wonders why this has gone undetected: I think because of an undocumented feature, the fact aboutToShowContextMenu was called for all views. Indeed, with the KTextEditor fix in place the duplication issue occurs also without loading the CTags plugin (= with stock KDevelop code).