Feed Advanced Search

Yesterday

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
Sometimes it works, sometimes it doesn't. Often I have to mock-edit a file to force reparsing when some header has changed.
Fri, Feb 15, 8:47 AM · KDevelop

Thu, Feb 14

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
To some extent this resembles the classic latency/throughput discussion.
Thu, Feb 14, 9:24 AM · KDevelop

Wed, Feb 13

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Well, if among developers you cannot find a solution that covers all use cases a configurable setting (applying only to setting the preamble-on-first parse flag or not) could well be the only compromise. And this one doesn't have to be hard to understand, which doesn't mean it has to (probably means that it should not) indicate exactly what it does.

Wed, Feb 13, 8:49 AM · KDevelop

Tue, Feb 12

rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).
What's the minimum viable change here?
Tue, Feb 12, 9:55 AM · Frameworks
rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Or, you add a flag to one of the relevant settings panels. There are already a number of options that aren't exactly easy to understand for everyone, this one could be something like "Make code-completion results available faster (can require significant resources)".

Tue, Feb 12, 9:20 AM · KDevelop

Mon, Feb 11

rjvbb added a comment to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.

auto* action = new QAction(tr("Reparse the Entire Project"), this);

Mon, Feb 11, 7:37 PM · KDevelop
rjvbb added a project to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu: KDevelop.
Mon, Feb 11, 2:53 PM · KDevelop
rjvbb updated the diff for D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.

Updated as requested.

Mon, Feb 11, 2:52 PM · KDevelop
rjvbb added inline comments to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Mon, Feb 11, 2:19 PM · KDevelop
rjvbb committed R32:fba39d4a06a4: Don't call clear() on a shared pointer we don't own (authored by rjvbb).
Don't call clear() on a shared pointer we don't own
Mon, Feb 11, 10:45 AM
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

So this is just going to become a victim of the better-is-the-enemy-of-good principle?

Mon, Feb 11, 9:24 AM · Frameworks

Thu, Feb 7

rjvbb added a comment to D7930: Kdevelop CMake plugin : use canonical paths to build.dir.

Question to @apol: from what I can grasp CMakeTargetItem::m_builtUrl is cmake-internal cuisine so there shouldn't be any need to store it in canonical fashion but rather reason(s) to store it exactly as cmake knows it?

Thu, Feb 7, 9:38 AM · KDevelop

Tue, Feb 5

rjvbb added inline comments to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Tue, Feb 5, 11:01 AM · KDevelop
rjvbb added a comment to D18551: clang: Create preamble only on second parse.
Is the parser triggered again if the entire project has been parsed already?
Tue, Feb 5, 9:12 AM · KDevelop

Mon, Feb 4

rjvbb set the repository for D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu to R32 KDevelop.
Mon, Feb 4, 11:32 AM · KDevelop
rjvbb added inline comments to D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.
Mon, Feb 4, 11:31 AM · KDevelop
rjvbb updated the diff for D11934: KDevelop : "Reparse Entire Project" action in the project manager context menu.

Updated as requested (minus the potential change to iProjectController::reparseProject).

Mon, Feb 4, 11:31 AM · KDevelop
rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Mon, Feb 4, 10:07 AM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

Comment removed.

Mon, Feb 4, 10:07 AM · KDevelop
rjvbb added inline comments to D15530: kdev-clang : somewhat more complete ObjC(++) support.
Mon, Feb 4, 10:06 AM · KDevelop
rjvbb abandoned D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).
Mon, Feb 4, 9:32 AM · KDevelop

Sun, Feb 3

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Sun, Feb 3, 10:40 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Now tested more exhaustively and with unittest.

Sun, Feb 3, 10:39 PM · Frameworks, Build System
rjvbb added a comment to D18551: clang: Create preamble only on second parse.

No, sorry, I am a bit confused by your notation and the fact you seem to consider only files that are open when you start a session and then probably confused myself a bit more while answering.

Sun, Feb 3, 6:39 PM · KDevelop
rjvbb committed R626:25c45221b66c: move initFontTickData into Style (authored by rjvbb).
move initFontTickData into Style
Sun, Feb 3, 11:16 AM
rjvbb committed R626:293a822b2fc0: Fix the LibreOffice fix (authored by rjvbb).
Fix the LibreOffice fix
Sun, Feb 3, 10:43 AM

Sat, Feb 2

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
where (1) = entire project is parsed on import. Is that correct?
Sat, Feb 2, 8:03 PM · KDevelop
rjvbb committed R626:ef1e350efa49: work around a crash in LibreOffice (authored by rjvbb).
work around a crash in LibreOffice
Sat, Feb 2, 1:04 PM
rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Is Milian's suggestion different from mine of setting the flag only when projects are not parsed entirely on import (which may be easier to test for where the flag is set, I haven't checked)?

Sat, Feb 2, 8:47 AM · KDevelop

Fri, Feb 1

rjvbb added a comment to D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).
never seen this, please investigate and fix it
Fri, Feb 1, 7:54 PM · KDevelop
rjvbb added a comment to D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).

What I meant is that tooltips in the problem reporter appear when you hover the mouse over an entry, and disappear again when you move the mouse back to the text editor (and certainly when you need to scroll the editor window because the tooltip covers the area where you need to be). But for some reason I'm not getting any tooltips in that reporter at all at the moment.

Fri, Feb 1, 1:41 PM · KDevelop

Thu, Jan 31

rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
So according to you, this line is useful ? from my point of view, it's needless and just looks like a syntax error.
Thu, Jan 31, 7:15 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Forget that. The syntax is confusing, please remove this HASFLAG

Thu, Jan 31, 6:30 PM · Frameworks, Build System
rjvbb committed R8:2c601b660e88: QMainWindow::setUnifiedTitleAndToolBarOnMac should not be used anymore. (authored by rjvbb).
QMainWindow::setUnifiedTitleAndToolBarOnMac should not be used anymore.
Thu, Jan 31, 2:53 PM
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
There are tests for other ECM modules in the **tests** subdir.
Thu, Jan 31, 12:13 PM · Frameworks, Build System
rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Thu, Jan 31, 10:34 AM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Updated as requested.

Thu, Jan 31, 10:34 AM · Frameworks, Build System
rjvbb added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Thu, Jan 31, 10:30 AM · Frameworks, Build System

Wed, Jan 30

rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Right, but I was saying all this because I think IF_SUPPORTED (the keyword in the arguments) should be SUPPORTED_IF.
Wed, Jan 30, 12:39 PM · Frameworks, Build System
rjvbb added a comment to D18551: clang: Create preamble only on second parse.

So there should indeed be some real-world benchmarking data to do a cost/benefit analysis that includes the human-in-the-loop aspect and huge projects like the ones Aaron uses. We already have an estimated 10% gain for a full reparse of a small project after its initial import.

Wed, Jan 30, 9:06 AM · KDevelop
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
In that sentence, one can read "if supported" for the macro name, ...
Wed, Jan 30, 12:28 AM · Frameworks, Build System

Tue, Jan 29

rjvbb added a comment to D15797: [kdev-clazy] : use canonical paths.

To put it bluntly: you should have asked that 3 months ago ;)
I really can't remember if I had a specific reason or if this is just the result of a search/replace.

Tue, Jan 29, 3:56 PM · KDevelop
rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Aaron, don't your arguments apply to parsing an entire project on startup as well? I can easily imagine that opening and parsing entire projects of the size you mention must have a non-negligible cost regardless of all optimisation and caching that is currently implemented
There is a setting for this feature. A similar switch for the preamble thing will probably be difficult to label comprehensively but maybe a coupling can be made with the full-project-parse switch?

Tue, Jan 29, 9:26 AM · KDevelop

Mon, Jan 28

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Mon, Jan 28, 9:25 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

This follows David's suggestion, but using QUERY_IF instead of the suggested TRY_IF to make it clear that this parameter controls the querying of the compiler.
I haven't yet tested the new logic exhaustively but the as far as I can tell the macro behaves as intended as used in the two compiler settings modules.

Mon, Jan 28, 9:24 PM · Frameworks, Build System
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
we use CXTranslationUnit_CreatePreambleOnFirstParse to get code completion results fast. otherwise the first code completion request would create the preamble, which felt much worse
Mon, Jan 28, 10:52 AM · KDevelop
rjvbb added a comment to D18551: clang: Create preamble only on second parse.
On my test file, time spent in clang_codeCompleteAt goes down from ~700ms
Mon, Jan 28, 10:40 AM · KDevelop
rjvbb added a comment to D18551: clang: Create preamble only on second parse.

Replying to a remark by Milian on D17289 where this idea came up:

Mon, Jan 28, 9:54 AM · KDevelop
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Usually if you have a conditional behaviour the associated condition specifies when to trigger it, no?
You're right that the names don't suggest exactly how the condition is being evaluated (with extra checks or not), but that was also a bit the idea.
Don't bother the user with such details, just provide a macro that will add the flag(s) if they are supported, with an optional conditional expression that can make things faster.

Mon, Jan 28, 9:38 AM · Frameworks, Build System

Sun, Jan 27

rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Sun, Jan 27, 10:15 PM · Frameworks, Build System
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

Renamed macro and parameter names as announced in my last comment.

Sun, Jan 27, 10:14 PM · Frameworks, Build System
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

This makes sense to me. Just the name "SUPPORTED_IF" is strange, when reading that, one thinks "well, if we know the compiler flag is supported, why are we testing that it is?".

Sun, Jan 27, 10:13 PM · Frameworks, Build System
rjvbb added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

like René says, this is quite surprising

Hmmm, did I say exactly that? :)

Sun, Jan 27, 9:04 PM · Build System, Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

But still, isn't there another way? Now the header and view are locked together. One doesn't work without the other.

Sun, Jan 27, 5:22 PM · Frameworks
rjvbb accepted D18551: clang: Create preamble only on second parse.

In case someone thinks that creating the pch file when you open a file causes a noticeable lag during the opening process: if so this would also be the case when configuring KDevelop not to parse the entire project on import. I use that mode all the time and never noticed any such lag.

Sun, Jan 27, 2:16 PM · KDevelop
rjvbb committed R32:a7c053a39218: kdev-clazy: use canonical paths (authored by rjvbb).
kdev-clazy: use canonical paths
Sun, Jan 27, 10:32 AM
rjvbb closed D15797: [kdev-clazy] : use canonical paths.
Sun, Jan 27, 10:32 AM · KDevelop

Sat, Jan 26

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

It'd be interesting to have an estimate of how much faster this makes that initial parse.

Sat, Jan 26, 10:36 PM · KDevelop
rjvbb added a comment to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

This is in fact cmake's fault, or ECM's for not taking a cmake quirk into account.

Sat, Jan 26, 7:18 PM · Build System, Frameworks
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

There are mechanisms to ensure cleanup in any event by removing an open file on POSIX compatibles (close will then

Sat, Jan 26, 4:18 PM · KDevelop
rjvbb requested changes to D18547: Don't enable -Wzero-as-null-pointer-constant on apple clang.

See also https://phabricator.kde.org/D16894 which (initially) aimed to tackle this in a more general fashion.

Sat, Jan 26, 1:13 PM · Build System, Frameworks

Fri, Jan 25

rjvbb set the repository for D17289: KDevelop/Shell: set dedicated TMPDIR to R32 KDevelop.
Fri, Jan 25, 11:13 PM · KDevelop
rjvbb updated the diff for D17289: KDevelop/Shell: set dedicated TMPDIR.

This version saves the original TMPDIR value, and adds a wrapper around QProcessEnvironment::systemEnvironment() that restores that original value. To keep changes to a minimum I've added that wrapper to the Core class itself.

Fri, Jan 25, 11:12 PM · KDevelop
rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Fri, Jan 25, 1:58 PM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

Updated as discussed.

Fri, Jan 25, 1:57 PM · KDevelop
rjvbb added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

Where or how can I find what to put in the JSON comments?

Fri, Jan 25, 12:50 PM · KDevelop
rjvbb added inline comments to D15530: kdev-clang : somewhat more complete ObjC(++) support.
Fri, Jan 25, 12:41 PM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

I was referring to @mwolff's comment D17289#395163.

Fri, Jan 25, 6:16 AM · KDevelop

Thu, Jan 24

rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Thu, Jan 24, 6:49 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

Use qobject_cast.

Thu, Jan 24, 6:49 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).
As far as I know, using qobject_cast is faster than comparing class names, because it only compares metaclass pointers. Additionally, it allows subclasses.
Thu, Jan 24, 3:14 PM · Frameworks
rjvbb added inline comments to D18380: KIO: make file dialog columns resizable again (and movable).
Thu, Jan 24, 1:57 PM · Frameworks
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
If you don't use systemd, for example because you're not on Linux, there are certainly other tools for doing the same thing.

How does that systemd thing clean tmp dirs at runtime, IOW, how can it know it's safe to clean up a given file if the application that created it doesn't do something explicit to guarantee cleanup?

Thu, Jan 24, 8:34 AM · KDevelop
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

David, Andreas, any idea why the name column all of a sudden jumps to a larger width when the widget is used in a side-bar and you're making the view narrower and approach the minimum width? It works in our favour here because the end result is that the name column becomes about as wide as the view itself (and I ensure it won't change size again).
It just nags me a bit that I haven't been able to figure out why it happens...

Thu, Jan 24, 8:22 AM · Frameworks
rjvbb added reviewers for D18380: KIO: make file dialog columns resizable again (and movable): dfaure, ahartmetz.
Thu, Jan 24, 8:16 AM · Frameworks

Wed, Jan 23

rjvbb added a comment to D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).

I completely forgot about this one, for some reason the patch was moved out of my active set (possibly because of lineheight calculation issues).

Wed, Jan 23, 4:08 PM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
Wed, Jan 23, 3:46 PM · KDevelop
rjvbb added a reviewer for D18380: KIO: make file dialog columns resizable again (and movable): Frameworks.
Wed, Jan 23, 9:15 AM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

The behavior is better now, thanks.

Wed, Jan 23, 9:10 AM · Frameworks

Tue, Jan 22

rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Tue, Jan 22, 10:43 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

the change to the headerfile was now redundant.

Tue, Jan 22, 10:43 PM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Tue, Jan 22, 10:38 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

Well, that was "interesting".

Tue, Jan 22, 10:37 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

I'm still going to try to fix this

Tue, Jan 22, 1:34 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

Yikes, and I can reproduce that. Did you notice this with previous versions that used font stretch? (Probably not if stretch had no effect for the font(s) you tried it with...)

Tue, Jan 22, 9:22 AM · Frameworks

Mon, Jan 21

rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Mon, Jan 21, 10:55 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

This version uses letterspacing rather than font stretch, so works regardless of whether a stylename has been set on the font.

Mon, Jan 21, 10:55 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

The discussion in that bug kind of petered out, unfortunately.

Mon, Jan 21, 8:46 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

Oh sh@@t, I understand what's happening here.

Mon, Jan 21, 11:50 AM · Frameworks
rjvbb committed R626:ce666898125a: QStyleOptionFrameV2 is an obsolete synonym for QStyleOptionFrame (authored by rjvbb).
QStyleOptionFrameV2 is an obsolete synonym for QStyleOptionFrame
Mon, Jan 21, 10:52 AM

Sun, Jan 20

rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).
I don't see the squeezed text when using Breeze and Noto Sans. Am I missing something?
Sun, Jan 20, 10:55 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

My QtCurve-based theme, "narrow mode" just activated:


Idem, "narrow mode" just deactivated

Sun, Jan 20, 4:40 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

Final attempt at being a bit clever :)

Sun, Jan 20, 4:34 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

One thing we might be able to do is use QFont::setStretch() to make the text a bit more compact. I'll follow that thought for a bit.

Sun, Jan 20, 10:40 AM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

I agree that reducing the size column width isn't as easy as I thought. I find it takes up more space than necessary when horizontal space is at a premium and I was hoping to get a more compact read-out that can still be interpreted ... and that would show itself in full in a tooltip.

Sun, Jan 20, 9:56 AM · Frameworks

Sat, Jan 19

rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).
If there's still enough room to show everything without a horizontal scrollbar, then we're still good.
Sat, Jan 19, 10:12 PM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Sat, Jan 19, 10:11 PM · Frameworks
rjvbb updated the diff for D18380: KIO: make file dialog columns resizable again (and movable).

tentative fix for "very narrow views".

Sat, Jan 19, 10:08 PM · Frameworks
rjvbb added a comment to D18380: KIO: make file dialog columns resizable again (and movable).

Maybe we can incorporate some more intelligence here

Sat, Jan 19, 6:41 PM · Frameworks
rjvbb set the repository for D18380: KIO: make file dialog columns resizable again (and movable) to R241 KIO.
Sat, Jan 19, 11:47 AM · Frameworks