Differential D17424

KDevelop/PatchReview: polish Purpose integration
ClosedPublic
Actions

Authored by rjvbb on Dec 8 2018, 9:10 AM.

Details

Reviewers
apol
Commits
R32:a5ca3cd1b0a3: polish Purpose integration in the PatchReview plugin
Summary

This makes 2 minor changes to the integration with the Purpose framework:

  • sets appropriate initial values to the "Export" model parameters urls and mimeType to avoid startup warnings Cannot initialize model with data QJsonObject() . missing: QJsonValue(string, "urls")
  • sets the updateComment of the Phabricator plugin so that the default upgrade summary is a little more personal.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rjvbb requested review of this revision.Dec 8 2018, 9:10 AM
rjvbb created this revision.
apol accepted this revision.Dec 9 2018, 3:05 AM
apol added inline comments.
plugins/patchreview/patchreviewtoolview.cpp
142

i18n?

This revision is now accepted and ready to land.Dec 9 2018, 3:05 AM
Closed by commit R32:a5ca3cd1b0a3: polish Purpose integration in the PatchReview plugin (authored by rjvbb). · Explain WhyDec 9 2018, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47206

View Options

plugins/patchreview/patchreviewtoolview.cpp

Loading...