- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Aug 13 2018
Shows as "Accepted" here, so lot's see :)
Compare canonical paths.
Proper fix in 45329c939edfcb3d57d6a53b83ca435da5aa04d8
Aug 11 2018
ping :)
ping :)
If there's no objections, I'm gonna merge this on Monday together with D13580
Aug 2 2018
Less spaghetti in the lexer.
Jul 30 2018
I rebased this against master and found it has the same problem as D13547, i.e. it introduces 10 first/follow conflicts :/
Not sure it's worth trying to solve it here either.
Jul 28 2018
Jul 15 2018
Jul 14 2018
Jun 17 2018
Jun 14 2018
Jun 13 2018
Jun 7 2018
Renamed isObjectTypehint => isClassTypehint to avoid confusion when
'object' typehint support is implemented.
Jun 3 2018
Feb 24 2018
Jan 27 2018
Jan 6 2018
Not really a cmake expert. Changes look sound, but can't really judge whether they are correct. Generally looks fine to me, apart from installing the php.g grammar file.
Dec 28 2017
Sure, but it's a rather large diff and I didn't want it to clutter up this review. I'll push it as a follow-up commit
Dec 26 2017
Dec 18 2017
Dec 17 2017
__DIR__ is a constant holding the current directory of the file the constant is used in
__TRAIT__ is a constant holding the current name of the trait the constant is used in
Add more test cases in the completion test
Dec 16 2017
Sep 17 2017
Coding adjustments and added comments.
Aug 8 2017
Jun 27 2017
The changes look good, although I think it would be preferable to have the basic types in a separate commit from the more complicated ones like iterable, self, object, etc.
Jun 22 2017
Jun 19 2017
Fair enough, was just playing it safe :)
Jun 18 2017
Fixed showing correct structure type for variadic arguments.
Jun 7 2017
May 24 2017
May 18 2017
Correct base branch, try 2
Correct base branch