Details
- Reviewers
brauch - Commits
- R52:3afa3af595b9: Add support for __DIR__ and __TRAIT__.
Diff Detail
- Repository
- R52 KDevelop: PHP Support
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I'm not up-to-date with the PHP standard, but guessing what the language feature does, code-wise this looks fine to me.
__DIR__ is a constant holding the current directory of the file the constant is used in
__TRAIT__ is a constant holding the current name of the trait the constant is used in
Any opinions on where I should merge this? Is it a small enough change to go into 5.2? Risk-wise it should be pretty low, but there is a string change
String change is probably ok if there is enough time before the next release (a few weeks) AFAIU. My two cents about where to merge it would be, put it in 5.2 only if you consider it a bug fix -- i.e. if there are projects which do not parse properly because this feature is missing go for it, otherwise put it in master. There's nothing worse than adding regression bugs in patch releases because of minor features like this.