Implement syntax support for function argument unpacking.

Authored by pprkut on May 18 2017, 8:13 AM.

Diff Detail

R52 KDevelop: PHP Support
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
pprkut created this revision.May 18 2017, 8:13 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 18 2017, 8:13 AM
pprkut updated this revision to Diff 14657.May 18 2017, 8:20 AM

Correct base branch

pprkut updated this revision to Diff 14659.May 18 2017, 8:35 AM

Correct base branch, try 2

mwolff added a subscriber: mwolff.May 24 2017, 1:08 PM

sorry Heinz, but I think the base for this patch is still wrong. Depending on what you did, here are some ideas on what you could try to resolve this situation:

# update remote
git fetch
# create a new branch tracking master
git checkout -b wip/function-argument-unpacking -t origin/master
# cherry-pick the patch(es) that implement the feature
git cherry-pick ... # use git log <name of old branch> to find hashes
# once done, use arc to resubmit

hope that helps

mwolff accepted this revision.May 24 2017, 1:32 PM

lgtm otherwise


= nullptr;

it's otherwise potentially uninitialized

This revision is now accepted and ready to land.May 24 2017, 1:32 PM
pprkut added inline comments.May 24 2017, 2:09 PM

Should I add that to the one before as well? (m_functionDeclarationPreviousArgument)

mwolff added inline comments.May 24 2017, 2:52 PM

sure, or check whether it's inited in a ctor - if not, add it here (but preferrably do that in a separate patch)

This revision was automatically updated to reflect the committed changes.