Differential D5817

Fix duchain unit tests.
ClosedPublic
Actions

Authored by pprkut on May 11 2017, 8:20 PM.

Details

Reviewers
kfunk
Commits
R52:435e829d408f: Fix whitespace errors in declarationbuilder.
R52:fd433b23319a: Fix duchain unit tests.
Summary

Fix tests broken in the duchain unit test because of a missing Lock.
Most likely introduced in D4776

Diff Detail

Repository
R52 KDevelop: PHP Support
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pprkut created this revision.May 11 2017, 8:20 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 11 2017, 8:20 PM
kfunk accepted this revision.May 12 2017, 9:34 AM
kfunk added a subscriber: kfunk.

Should this go into 5.1 branch?

This revision is now accepted and ready to land.May 12 2017, 9:34 AM
pprkut added a comment.May 12 2017, 10:42 AM

The changes are currently based on the 5.1 branch, but I couldn't verify them locally. Almost none of the tests pass for me :(
I tested the changes on master and there everything is fine.

Closed by commit R52:435e829d408f: Fix whitespace errors in declarationbuilder. (authored by pprkut). · Explain WhyMay 12 2017, 6:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 14443

View Options

duchain/builders/declarationbuilder.cpp

Loading...