Feed Advanced Search

Apr 14 2021

dfaure commandeered D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage.
Apr 14 2021, 9:04 AM · Frameworks
dfaure added a comment to T12150: KCModule => move to KCMUtils.

Actually, if KCMUtils is trimmed down, maybe its own dependencies (and tier?) can be trimmed down? Then it would be even less of a problem for KIO to depend on it...

Apr 14 2021, 9:01 AM · KF6
dfaure added a comment to T12150: KCModule => move to KCMUtils.

What would be the issue? A tier3 framework can depend on another tier3 framework.
And KCMUtils doesn't depend on KIO, so KIO can depend on KCMUtils.
It's however a bit "sad" to add more dependencies to KIO, people tend to find it has too many already.....

Apr 14 2021, 8:41 AM · KF6
dfaure added a comment to T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob.

It's probably time to remove support for Type=Device desktop files. People just don't mount devices that way anymore.
In the very old days, this was the way to mount a CDROM or floppy. But those got replaced with USB devices, which magically show up in plasma.
And then this means removing KDevicePropsPlugin indeed.

Apr 14 2021, 8:26 AM · KF6

Apr 11 2021

dfaure added a comment to T14329: Create KTerminalLauncherJob.

I'll call it KTerminalLauncherJob so it can move out of KIO without further renaming.

Apr 11 2021, 10:48 AM · KF6
dfaure moved T14329: Create KTerminalLauncherJob from Backlog to In Progress on the KF6 board.
Apr 11 2021, 10:44 AM · KF6
dfaure claimed T14329: Create KTerminalLauncherJob.
Apr 11 2021, 10:41 AM · KF6

Apr 10 2021

dfaure moved T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors from In Progress to In Discussion on the KF6 board.
Apr 10 2021, 8:15 PM · KF6
dfaure moved T12340: Install all parts into plugins/kf5/parts, and add JSON metadata to them from In Progress to Waiting on KF6 Branching on the KF6 board.
Apr 10 2021, 8:15 PM · KF6

Apr 8 2021

dfaure added a comment to T12340: Install all parts into plugins/kf5/parts, and add JSON metadata to them.

kdesvn: https://invent.kde.org/sdk/kdesvn/-/merge_requests/1
arkpart: https://invent.kde.org/utilities/ark/-/merge_requests/40
kfontviewpart: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/771
kigpart.so: https://invent.kde.org/education/kig/-/merge_requests/3
kmplotpart.so: https://invent.kde.org/education/kmplot/-/merge_requests/3
libcantorpart.so: https://invent.kde.org/education/cantor/-/merge_requests/30

Apr 8 2021, 9:57 AM · KF6
dfaure added a comment to T13806: KParts plugin cleanup.

One solution is to just move the kpartsplugins/ loading code to Konqueror.
The other is to implement a whole new plugin mechanism.
Unless someone is interested in redesigning the whole mechanism, I'd say we should go with "moving" the code (copying and deprecating).
Opinions?

Apr 8 2021, 9:53 AM · KF6

Apr 6 2021

dfaure added a comment to T14233: Support multiple major Qt versions in ECM.

Ah, co-installability, good point. Then we're back to: ECM can't know what the app wants, the app needs to ask for it, or (for the transitional period) the developer could ask for it, to test things. => KDEInstallDirs5, KDEInstallDirs6, and a KDEInstallDirs that forwards to KDEInstallDirs5 by default, and to KDEInstallDirs6 if a cmake option is set.

Apr 6 2021, 6:17 PM · KF6
dfaure added a comment to T14233: Support multiple major Qt versions in ECM.

Ah, I see. I was thinking of ECM as a completely independent module, but you're right, as part of frameworks it will get a KF6 branch.

Apr 6 2021, 4:56 PM · KF6
dfaure renamed T12340: Install all parts into plugins/kf5/parts, and add JSON metadata to them from Install all parts into plugins/kf5/parts to Install all parts into plugins/kf5/parts, and add JSON metadata to them.
Apr 6 2021, 1:25 PM · KF6
dfaure moved T14306: Core/Gui split for KUriFilterPlugin from In Progress to Waiting on KF6 Branching on the KF6 board.

kio !396 is in, the final cleanup and move is for after KF6 branching

Apr 6 2021, 1:24 PM · KF6
dfaure added a comment to T12340: Install all parts into plugins/kf5/parts, and add JSON metadata to them.

The kdepim parts are loaded by name from KontactInterface::Core::createPart, which does e.g. KPluginLoader("kmailpart"), which resolves to PREFIX/lib64/plugins/kmailpart.so. I think that means it's all fine, they can keep living there. Nothing needs to iterate over kdepim parts, so no need to move them to a subdir.

Apr 6 2021, 12:48 PM · KF6
dfaure added a comment to T12185: KService: deprecate/slim down KToolInvocation.

Interesting about desktopexecparser. I always assumed it would just move along with CommandLauncherJob/ApplicationLauncherJob/kprocessrunner.

Apr 6 2021, 11:53 AM · KF6
dfaure moved T14343: Remove "X-KDE-Default-UserAgent" from two desktop files from Backlog to Waiting on KF6 Branching on the KF6 board.
Apr 6 2021, 8:08 AM · Konqueror
dfaure created T14343: Remove "X-KDE-Default-UserAgent" from two desktop files.
Apr 6 2021, 8:08 AM · Konqueror
dfaure moved T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML from In Progress to Done on the KF6 board.
Apr 6 2021, 8:06 AM · KF6

Apr 5 2021

dfaure moved T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML from Backlog to In Progress on the KF6 board.
Apr 5 2021, 6:25 PM · KF6
dfaure claimed T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML.
Apr 5 2021, 6:25 PM · KF6
dfaure added a comment to T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML.

Actually, this doesn't really make sense, given that WebEnginePart doesn't use KIO.

Apr 5 2021, 6:06 PM · KF6
dfaure added a comment to T12177: KService: deprecate KMimeTypeTrader.

My thoughts on that code are the following: T14307. But actually I just realized something.... I'll add a comment there.

Apr 5 2021, 6:04 PM · KF6
dfaure added a comment to T14306: Core/Gui split for KUriFilterPlugin.

I think it will have to move all to KIOGui because of the KIconLoader usage.

Apr 5 2021, 11:02 AM · KF6
dfaure added a comment to T14306: Core/Gui split for KUriFilterPlugin.

https://invent.kde.org/frameworks/kio/-/merge_requests/396

Apr 5 2021, 9:35 AM · KF6
dfaure moved T14306: Core/Gui split for KUriFilterPlugin from Backlog to In Progress on the KF6 board.
Apr 5 2021, 9:03 AM · KF6
dfaure claimed T14306: Core/Gui split for KUriFilterPlugin.
Apr 5 2021, 9:03 AM · KF6

Apr 4 2021

dfaure moved T11821: Move KDirModel to KioGui from In Progress to Waiting on KF6 Branching on the KF6 board.
Apr 4 2021, 5:20 PM · KF6
dfaure added a comment to T12214: Move KIOWorkers into a thread of the calling application instead of separate process.

Indeed.

Apr 4 2021, 5:19 PM · KF6
dfaure added a comment to T14337: Port KFileMetaData away from QMap::insertMulti.

Sounds reasonable. Are you volunteering to write that API? My interest in all this stops at "making it build with Qt 5.15" :)

Apr 4 2021, 3:03 PM · KF6
dfaure added a parent task for T14337: Port KFileMetaData away from QMap::insertMulti: T11553: Port KDE Frameworks away from deprecated methods in Qt.
Apr 4 2021, 1:03 PM · KF6
dfaure added a subtask for T11553: Port KDE Frameworks away from deprecated methods in Qt: T14337: Port KFileMetaData away from QMap::insertMulti.
Apr 4 2021, 1:03 PM · Frameworks, KF6
dfaure created T14337: Port KFileMetaData away from QMap::insertMulti.
Apr 4 2021, 1:03 PM · KF6

Apr 3 2021

dfaure added a comment to T11549: KIO: remove unneeded QWidget dependencies to set parent windows or display errors.

KRun is fully done.
KDirModel (with KDirLister and FileUndoManager) is on-going in T11821.
Core/Gui split for KUriFilterPlugin is handled in T14306.

Apr 3 2021, 9:24 PM · KF6
dfaure added a comment to T14164: Create version-less KF cmake targets.

@skelly From what I understand, the problem with versionless targets is when they "leak" into generated FooConfig.cmake files, and then users can end up with bad mix-and-match.

Apr 3 2021, 9:11 PM · KF6
dfaure added a comment to T14233: Support multiple major Qt versions in ECM.

My thoughts during the meeting: extracting the qt-specific install dirs from KDEInstallDirs. Then apps would be able to choose between include(QtInstallDirs5) and include(QtInstallDirs6).

Apr 3 2021, 2:11 PM · KF6
dfaure moved T14154: Adapt to QTextCodec changes from Needs Input to Waiting on Qt Changes on the KF6 board.
Apr 3 2021, 1:59 PM · KF6
dfaure moved T13806: KParts plugin cleanup from Needs Input to Backlog on the KF6 board.
Apr 3 2021, 1:53 PM · KF6
dfaure moved T12096: Trim down KIO (API and dependencies) from Needs Splitting to Metatasks on the KF6 board.
Apr 3 2021, 12:44 PM · KF6
dfaure added a comment to T12185: KService: deprecate/slim down KToolInvocation.

I volunteer to write these jobs, but I'm having second thoughts about providing a replacement in KIOGui for API in KService. It *raises* the amount of needed dependencies.

Apr 3 2021, 12:42 PM · KF6
dfaure added a comment to T11821: Move KDirModel to KioGui.

I locally attempted the move to kiogui, to see what would create problems.

Apr 3 2021, 11:58 AM · KF6
dfaure added a comment to T11821: Move KDirModel to KioGui.

https://invent.kde.org/frameworks/kio/-/merge_requests/387

Apr 3 2021, 9:13 AM · KF6
dfaure added a comment to T13806: KParts plugin cleanup.

It seems clear to me that only konqueror uses the KParts Plugins feature:

Apr 3 2021, 8:41 AM · KF6

Mar 29 2021

dfaure added a comment to T12140: Killing KInit With Fire.

Yes that would make sense, as a first step before I toggle it for good in KIO.
In theory it should all be fine :)

Mar 29 2021, 8:32 AM · KF6

Mar 28 2021

dfaure added a comment to T11821: Move KDirModel to KioGui.

Better plan, let KCoreDirLister emit error(KJob*) and handle that in apps and in KDirModel.

Mar 28 2021, 11:00 PM · KF6
dfaure added a comment to T14233: Support multiple major Qt versions in ECM.

It would appear that I grepped wrongly, sorry about that.

Mar 28 2021, 3:52 PM · KF6
dfaure added a comment to T12533: Make kconf_update more robust.

Notes from the KF6 sprint (2021-03-28)

Mar 28 2021, 3:12 PM · KF6
dfaure added a comment to T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob.

kio_trash can probably just exec() the job, a blocking call is fine there.

Mar 28 2021, 2:39 PM · KF6
dfaure created T14316: Port KDE Frameworks from KWallet to QtKeyChain.
Mar 28 2021, 2:35 PM · KF6
dfaure added a comment to T14302: Port from KPluginLoader::pluginVersion to KPluginMetaData::version.

After filtering out the unrelated results from lxr, I see only these:

Mar 28 2021, 12:25 PM · KF6
dfaure moved T14310: KIOCore: Remove KDBusAddons dependency once kdeinit is removed, it was only used for KDEInitInterface from Backlog to Waiting on KF6 Branching on the KF6 board.
Mar 28 2021, 10:11 AM · KF6
dfaure added a parent task for T14310: KIOCore: Remove KDBusAddons dependency once kdeinit is removed, it was only used for KDEInitInterface: T12096: Trim down KIO (API and dependencies).
Mar 28 2021, 10:10 AM · KF6
dfaure added a subtask for T12096: Trim down KIO (API and dependencies): T14310: KIOCore: Remove KDBusAddons dependency once kdeinit is removed, it was only used for KDEInitInterface.
Mar 28 2021, 10:10 AM · KF6
dfaure created T14310: KIOCore: Remove KDBusAddons dependency once kdeinit is removed, it was only used for KDEInitInterface.
Mar 28 2021, 10:10 AM · KF6
dfaure added a parent task for T14306: Core/Gui split for KUriFilterPlugin: T12096: Trim down KIO (API and dependencies).
Mar 28 2021, 10:10 AM · KF6
dfaure added a subtask for T12096: Trim down KIO (API and dependencies): T14306: Core/Gui split for KUriFilterPlugin.
Mar 28 2021, 10:10 AM · KF6
dfaure added a parent task for T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML: T12096: Trim down KIO (API and dependencies).
Mar 28 2021, 10:09 AM · KF6
dfaure added a subtask for T12096: Trim down KIO (API and dependencies): T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML.
Mar 28 2021, 10:09 AM · KF6
dfaure moved T14309: Move DesktopExecParser up to KIOGui to remove the dependency on KService from Backlog to Waiting on KF6 Branching on the KF6 board.
Mar 28 2021, 10:09 AM · KF6
dfaure added a parent task for T14309: Move DesktopExecParser up to KIOGui to remove the dependency on KService: T12096: Trim down KIO (API and dependencies).
Mar 28 2021, 10:09 AM · KF6
dfaure added a subtask for T12096: Trim down KIO (API and dependencies): T14309: Move DesktopExecParser up to KIOGui to remove the dependency on KService.
Mar 28 2021, 10:09 AM · KF6
dfaure created T14309: Move DesktopExecParser up to KIOGui to remove the dependency on KService.
Mar 28 2021, 10:08 AM · KF6
dfaure created T14307: Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEngine instead of KHTML.
Mar 28 2021, 10:06 AM · KF6
dfaure created T14306: Core/Gui split for KUriFilterPlugin.
Mar 28 2021, 10:05 AM · KF6
dfaure added a parent task for T14305: kcms/kio/kproxydlg.*: port from KLineEdit to QLineEdit, remove dependency on KCompletion: T12096: Trim down KIO (API and dependencies).
Mar 28 2021, 10:04 AM · KF6
dfaure added a subtask for T12096: Trim down KIO (API and dependencies): T14305: kcms/kio/kproxydlg.*: port from KLineEdit to QLineEdit, remove dependency on KCompletion.
Mar 28 2021, 10:04 AM · KF6
dfaure created T14305: kcms/kio/kproxydlg.*: port from KLineEdit to QLineEdit, remove dependency on KCompletion.
Mar 28 2021, 10:04 AM · KF6
dfaure added a parent task for T14304: Port ktelnetservice away from KToolInvocation::kdeinitExec, remove dependency on KService.: T12096: Trim down KIO (API and dependencies).
Mar 28 2021, 10:03 AM · KF6
dfaure added a subtask for T12096: Trim down KIO (API and dependencies): T14304: Port ktelnetservice away from KToolInvocation::kdeinitExec, remove dependency on KService..
Mar 28 2021, 10:03 AM · KF6
dfaure created T14304: Port ktelnetservice away from KToolInvocation::kdeinitExec, remove dependency on KService..
Mar 28 2021, 10:02 AM · KF6
dfaure added a comment to T12096: Trim down KIO (API and dependencies).

KIOCore dependencies:

  • Remove KDBusAddons once kdeinit is removed, it was only used for KDEInitInterface. T14310
  • Move DesktopExecParser up to KIOGui to remove the dependency on KService. T14309
  • Remove KProtocolManager::defaultUserAgentFromPreferredService and hardcode WebEnginePart instead of KHTML. T14307
Mar 28 2021, 9:32 AM · KF6
dfaure added a parent task for T14303: KPluginLoader: move static methods to KPluginMetaData: T13952: KPluginLoader.
Mar 28 2021, 9:11 AM · KF6
dfaure added a subtask for T13952: KPluginLoader: T14303: KPluginLoader: move static methods to KPluginMetaData.
Mar 28 2021, 9:11 AM · KF6
dfaure created T14303: KPluginLoader: move static methods to KPluginMetaData.
Mar 28 2021, 9:11 AM · KF6
dfaure added a parent task for T14302: Port from KPluginLoader::pluginVersion to KPluginMetaData::version: T13952: KPluginLoader.
Mar 28 2021, 8:56 AM · KF6
dfaure added a subtask for T13952: KPluginLoader: T14302: Port from KPluginLoader::pluginVersion to KPluginMetaData::version.
Mar 28 2021, 8:56 AM · KF6
dfaure created T14302: Port from KPluginLoader::pluginVersion to KPluginMetaData::version.
Mar 28 2021, 8:55 AM · KF6
dfaure added a comment to T11821: Move KDirModel to KioGui.

Next issue: KDirModel uses KDirLister (which extends KCoreDirLister with QWidget* and KMessageBox for errors).
Idea: take a JobUiDelegate in KCoreDirLister, remove KDirLister, rename KCoreDirLister to KDirLister.
And set the ui delegate from the factory automatically like in KIO jobs.

Mar 28 2021, 8:26 AM · KF6

Mar 27 2021

dfaure added a comment to T14233: Support multiple major Qt versions in ECM.

I'm confused. ECM does not call find_package(Qt<n>) at all right now. So no change there. For KF6 all we need is search/replace on the REQUIRED_QT_VERSION variable.

Mar 27 2021, 10:30 PM · KF6
dfaure added a comment to T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob.

I'd say the first step is to port KIO away from it

Mar 27 2021, 8:26 PM · KF6
dfaure renamed T12096: Trim down KIO (API and dependencies) from Split up KIO to Trim down KIO (API and dependencies).
Mar 27 2021, 5:10 PM · KF6
dfaure added a parent task for T14236: KRecentDocument needs to move down from KIO: T12089: KIO for KF6.
Mar 27 2021, 5:05 PM · KF6
dfaure added a subtask for T12089: KIO for KF6: T14236: KRecentDocument needs to move down from KIO.
Mar 27 2021, 5:05 PM · KF6
dfaure added a parent task for T14298: Finish porting away from kf5_add_kdeinit_executable: T12140: Killing KInit With Fire.
Mar 27 2021, 4:59 PM · KF6
dfaure added a subtask for T12140: Killing KInit With Fire: T14298: Finish porting away from kf5_add_kdeinit_executable.
Mar 27 2021, 4:59 PM · KF6
dfaure created T14298: Finish porting away from kf5_add_kdeinit_executable.
Mar 27 2021, 4:58 PM · KF6
dfaure added a parent task for T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob: T12089: KIO for KF6.
Mar 27 2021, 4:46 PM · KF6
dfaure added a subtask for T12089: KIO for KF6: T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob.
Mar 27 2021, 4:46 PM · KF6
dfaure added a comment to T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob.

Using the job is preferred (where the KIO dependency can be kept) because it won't block.

Mar 27 2021, 4:40 PM · KF6
dfaure created T14295: KIO: deprecate KDiskFreeSpaceInfo in favour of FileSystemFreeSpaceJob.
Mar 27 2021, 4:12 PM · KF6
dfaure added a comment to T12185: KService: deprecate/slim down KToolInvocation.

KF6 meeting notes:

Mar 27 2021, 3:54 PM · KF6
dfaure added a comment to T12140: Killing KInit With Fire.

Meeting notes from the KF6 sprint:

Mar 27 2021, 3:45 PM · KF6
dfaure added a comment to T12140: Killing KInit With Fire.

Cleanups needed: removing the last uses of kf5_add_kdeinit_executable ==> T14298

Mar 27 2021, 2:59 PM · KF6
dfaure added a comment to T12340: Install all parts into plugins/kf5/parts, and add JSON metadata to them.

In the KF6 sprint today it was said that I took care of kdepim, but that's not the case. That was for kontact plugins (e.g. D28608), not for the KParts.

Mar 27 2021, 2:29 PM · KF6
dfaure updated the task description for T14236: KRecentDocument needs to move down from KIO.
Mar 27 2021, 2:12 PM · KF6
dfaure added a comment to T12246: Move KRecentFileAction down in tierness.

Created a separate task for KRecentDocuments: T14236

Mar 27 2021, 2:11 PM · KF6
dfaure created T14236: KRecentDocument needs to move down from KIO.
Mar 27 2021, 2:09 PM · KF6
dfaure updated subscribers of T13806: KParts plugin cleanup.

@stefanocrocco @marten Any input on which of the two proposals sounds best to you?

Mar 27 2021, 1:59 PM · KF6
dfaure added a comment to T12246: Move KRecentFileAction down in tierness.

Should KRecentFileAction be based on a core-only class like KRecentDocuments?

Mar 27 2021, 1:58 PM · KF6