Feed Advanced Search

Apr 3 2019

vonreth committed R877:113cf475d6a8: Build vsd static (authored by vonreth).
Build vsd static
Apr 3 2019, 8:39 AM

Apr 2 2019

vonreth updated subscribers of D19740: Add custom KEXI nsis installer.

BTW is it possible to get KDE certificate for the installer?

I've found only this older thread: https://www.mail-archive.com/kde-community@kde.org/msg03833.html

Apr 2 2019, 11:25 AM · KEXI
vonreth added inline comments to D19740: Add custom KEXI nsis installer.
Apr 2 2019, 9:42 AM · KEXI
vonreth added inline comments to D19740: Add custom KEXI nsis installer.
Apr 2 2019, 9:38 AM · KEXI

Apr 1 2019

vonreth committed R138:b1fd4aa0da53: Make sure we have 7z installed (authored by vonreth).
Make sure we have 7z installed
Apr 1 2019, 11:17 AM
vonreth committed R138:c19e61f1ccd2: Include version in git targets (authored by vonreth).
Include version in git targets
Apr 1 2019, 9:47 AM
vonreth committed R138:13e4b9ae2ae1: Include timestamp in git artifacts (authored by vonreth).
Include timestamp in git artifacts
Apr 1 2019, 9:47 AM
vonreth committed R138:b8870a845475: Improve instructions to install nsis (authored by vonreth).
Improve instructions to install nsis
Apr 1 2019, 8:56 AM

Mar 31 2019

vonreth committed R138:988163bebfe9: Fix warning (authored by vonreth).
Fix warning
Mar 31 2019, 11:28 AM

Mar 29 2019

vonreth committed R138:341bf023c6d3: Fix tests (authored by vonreth).
Fix tests
Mar 29 2019, 11:54 PM
vonreth committed R877:240faf52384d: there is no kde/plasma/plasma-workspace (authored by vonreth).
there is no kde/plasma/plasma-workspace
Mar 29 2019, 11:53 PM
vonreth committed R877:0364c7cd7389: Remove originally accidental committed file (authored by vonreth).
Remove originally accidental committed file
Mar 29 2019, 11:53 PM
vonreth committed R138:cb45fff25fef: Fix condition (authored by vonreth).
Fix condition
Mar 29 2019, 11:48 PM
vonreth committed R138:b85f9f3ca6f8: Warn if Windows dev mode is not active (authored by vonreth).
Warn if Windows dev mode is not active
Mar 29 2019, 11:48 PM
vonreth added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

Sorry, forgot about it.
Which package is actually broken? python?
When was your craft install?

Mar 29 2019, 11:30 PM
vonreth added inline comments to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Mar 29 2019, 11:09 PM · Craft

Mar 26 2019

vonreth added a comment to D19740: Add custom KEXI nsis installer.
  • KEXI: ignore hunspell and qtlocation/sensors/qqcontrols2
  • Simplify blacklist for KEXI, ignore more files
  • NSIS Installer for KEXI: Improve start menu and install dir removal (remove parent KEXI folder if makse sense), fix folder names
Mar 26 2019, 8:16 AM · KEXI

Mar 25 2019

vonreth added a comment to D19903: Fix build with msvc.

So then the workaround is correct, I haven't tried whether the original code compiles with CMAKE_CXX_STANDARD=17

Mar 25 2019, 2:06 PM · Frameworks
vonreth added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

To manage this review you can use arcanist (craft arcanist).
https://secure.phabricator.com/book/phabricator/article/arcanist_diff/

Mar 25 2019, 2:03 PM · Craft
vonreth committed R834:3bec157ae267: Clang format https://github.com/qt/qt5/blob/dev/_clang-format (authored by vonreth).
Clang format https://github.com/qt/qt5/blob/dev/_clang-format
Mar 25 2019, 9:37 AM
vonreth added a comment to D19982: Make akonadi applications non bundle for macOS.

The main difference for a Qt application not marked as gui/WIN32 is that a console Windows will pop up when the application is executed.

Mar 25 2019, 9:09 AM · KDE PIM

Mar 21 2019

vonreth committed R993:f58090115f82: Add vsd (authored by vonreth).
Add vsd
Mar 21 2019, 1:41 PM
vonreth committed R993:856825f017f1: Fix (authored by vonreth).
Fix
Mar 21 2019, 12:32 PM
vonreth committed R993:5da4f0e7616a: Use default cache (authored by vonreth).
Use default cache
Mar 21 2019, 12:30 PM
vonreth committed R138:738d01f31423: Use new chache (authored by vonreth).
Use new chache
Mar 21 2019, 12:30 PM
vonreth committed R877:713c9849c39c: Use Qt 5.12.2 (authored by vonreth).
Use Qt 5.12.2
Mar 21 2019, 12:28 PM
vonreth committed R877:4675900d1448: Don't disable kate deps (authored by vonreth).
Don't disable kate deps
Mar 21 2019, 12:28 PM
vonreth added inline comments to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Mar 21 2019, 8:27 AM · Craft
vonreth requested changes to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..

Thx!

Mar 21 2019, 8:25 AM · Craft

Mar 20 2019

vonreth added a comment to D19903: Fix build with msvc.

Msvc2017.
I think frameworks is still c++11?

Mar 20 2019, 10:09 PM · Frameworks
vonreth committed R877:e0c08b267716: Fix kactivities-stats (authored by vonreth).
Fix kactivities-stats
Mar 20 2019, 9:36 AM
vonreth added a comment to D19903: Fix build with msvc.

aren't valid file names on windows, and look strange for unix too

Mar 20 2019, 7:54 AM · Frameworks
vonreth added reviewers for D19903: Fix build with msvc: mlaurent, davidedmundson, aacid.
Mar 20 2019, 7:53 AM · Frameworks
vonreth requested review of D19903: Fix build with msvc.
Mar 20 2019, 7:51 AM · Frameworks
vonreth abandoned D19902: Remove illegal file names.
Mar 20 2019, 7:51 AM · Frameworks
vonreth updated the diff for D19902: Remove illegal file names.
  • Fix build with msvc
Mar 20 2019, 7:50 AM · Frameworks
vonreth requested review of D19902: Remove illegal file names.
Mar 20 2019, 7:50 AM · Frameworks

Mar 19 2019

vonreth committed R138:a20baba4e4a3: Fix unescped backspace (authored by vonreth).
Fix unescped backspace
Mar 19 2019, 9:47 PM
vonreth committed R877:da206726003f: Align perls, inix config with the windows config (authored by vonreth).
Align perls, inix config with the windows config
Mar 19 2019, 3:36 PM
vonreth accepted D18832: runtime: Add error message about env variables.
Mar 19 2019, 3:12 PM
vonreth committed R877:71b334a4e86d: Merge branch '2018.12' (authored by vonreth).
Merge branch '2018.12'
Mar 19 2019, 1:41 PM
vonreth committed R877:14086a9c3771: Update putty (authored by vonreth).
Update putty
Mar 19 2019, 1:41 PM
vonreth committed R993:2311edd572ba: Add lokalize stable (authored by vonreth).
Add lokalize stable
Mar 19 2019, 10:45 AM
vonreth committed R993:312edc769e8c: Add a sable configuration and use it (authored by vonreth).
Add a sable configuration and use it
Mar 19 2019, 10:42 AM

Mar 18 2019

vonreth committed R877:f27dbf7c9f0a: Fix lib name on mac (authored by vonreth).
Fix lib name on mac
Mar 18 2019, 3:59 PM
vonreth committed R877:6bb64e6db739: Rebuild ghostscript (authored by vonreth).
Rebuild ghostscript
Mar 18 2019, 3:40 PM
vonreth committed R993:395df876b0ba: Build a Qt 5.12.2 cache (authored by vonreth).
Build a Qt 5.12.2 cache
Mar 18 2019, 7:35 AM
vonreth committed R877:eef261d46c41: add qt 5.12.2 (authored by vonreth).
add qt 5.12.2
Mar 18 2019, 7:34 AM

Mar 17 2019

vonreth added inline comments to D19740: Add custom KEXI nsis installer.
Mar 17 2019, 7:01 PM · KEXI

Mar 14 2019

vonreth added a comment to D19740: Add custom KEXI nsis installer.

first wave

Mar 14 2019, 8:05 AM · KEXI

Mar 13 2019

vonreth committed R877:680cb10cd082: Fix build from git (authored by vonreth).
Fix build from git
Mar 13 2019, 2:13 PM
vonreth committed R834:645b702267d6: Refactoring (authored by vonreth).
Refactoring
Mar 13 2019, 10:45 AM
vonreth committed R877:04182a6a2e82: add current branches (authored by vonreth).
add current branches
Mar 13 2019, 8:18 AM

Mar 12 2019

vonreth committed R138:446d31740c58: Keep path seperator (authored by vonreth).
Keep path seperator
Mar 12 2019, 2:01 PM
vonreth committed R877:393199344803: Apply libkexiv2 patch on all 18.12 releases (authored by vonreth).
Apply libkexiv2 patch on all 18.12 releases
Mar 12 2019, 1:25 PM
vonreth committed R138:ee10d2bb454c: Allow fuzzy version comparison (authored by vonreth).
Allow fuzzy version comparison
Mar 12 2019, 1:25 PM

Mar 11 2019

vonreth committed R834:ecb4e19bd8e8: Start a callback application if the pipe does not exist (authored by vonreth).
Start a callback application if the pipe does not exist
Mar 11 2019, 5:02 PM
vonreth committed R834:d3cdc13ce757: Cleanup (authored by vonreth).
Cleanup
Mar 11 2019, 3:40 PM
vonreth committed R993:7314e7543050: Build snoretoast (authored by vonreth).
Build snoretoast
Mar 11 2019, 3:29 PM
vonreth committed R834:0c8c2cd4fd64: Cleanup (authored by vonreth).
Cleanup
Mar 11 2019, 3:25 PM
vonreth committed R834:1bdcbc2804c6: Print xml (authored by vonreth).
Print xml
Mar 11 2019, 3:12 PM
vonreth committed R834:44d7e693e95c: Fix path (authored by vonreth).
Fix path
Mar 11 2019, 3:12 PM
vonreth committed R834:59aed16506be: Use std::filesystem (authored by vonreth).
Use std::filesystem
Mar 11 2019, 2:51 PM
vonreth committed R834:8b8703c51605: Use std::filesystem (authored by vonreth).
Use std::filesystem
Mar 11 2019, 11:25 AM
vonreth committed R834:c42e79587227: Make the example use its own app id (authored by vonreth).
Make the example use its own app id
Mar 11 2019, 10:36 AM
vonreth committed R834:bbc71c13de3c: license (authored by vonreth).
license
Mar 11 2019, 10:23 AM
vonreth committed R834:1b0abf0233de: Add example (authored by vonreth).
Add example
Mar 11 2019, 10:22 AM
vonreth committed R834:2b4fbbde9ee8: Report everything to a pipe (authored by vonreth).
Report everything to a pipe
Mar 11 2019, 10:22 AM

Mar 8 2019

vonreth committed R834:6f3142a135fa: Don't crash when we use another appid (authored by vonreth).
Don't crash when we use another appid
Mar 8 2019, 2:23 PM
vonreth committed R877:b5d003e17f73: build snoretoast from src on msvc (authored by vonreth).
build snoretoast from src on msvc
Mar 8 2019, 10:49 AM
vonreth committed R138:cbca63fcd3f4: Move snoretoast to craft-blueprints-kde (authored by vonreth).
Move snoretoast to craft-blueprints-kde
Mar 8 2019, 10:43 AM
vonreth committed R834:a51d095ca402: Make sure we get the response for the correct notification (authored by vonreth).
Make sure we get the response for the correct notification
Mar 8 2019, 10:36 AM
vonreth committed R834:d5ce553f9c0f: Add license (authored by vonreth).
Add license
Mar 8 2019, 10:36 AM
vonreth committed R834:5b3050ff19be: Only print button text (authored by vonreth).
Only print button text
Mar 8 2019, 10:29 AM
vonreth committed R834:1d5997dec7b3: Write action center events to a named pipe passed to the application (authored by vonreth).
Write action center events to a named pipe passed to the application
Mar 8 2019, 10:26 AM

Mar 7 2019

vonreth added a comment to D19584: Put python3 from the system before python3 from dev-utils/bin in the PATH.

I had it too.
Your issue is on Windows? Actually craft should use the one from the settings directly and not python from the path.

Mar 7 2019, 1:23 PM

Mar 6 2019

vonreth committed R877:b447ed3b494c: Fix kdeconnect-kde source link (authored by brute4s99).
Fix kdeconnect-kde source link
Mar 6 2019, 4:10 PM
vonreth closed D19568: Fix kdeconnect-kde source link.
Mar 6 2019, 4:10 PM
vonreth committed R877:50708fa274dd: Patch was upstreamed (authored by vonreth).
Patch was upstreamed
Mar 6 2019, 4:09 PM
vonreth added a comment to T10558: Windows build of Skrooge fails.

The problem is that QWebengine is msvc2017 only and most Skrooge deps are mingw only.

Mar 6 2019, 9:02 AM · Windows

Mar 5 2019

vonreth added a comment to T10558: Windows build of Skrooge fails.

I tried to fix the webkit build with mingw once but I don't have the time to go after it.
A good source for patches is https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-qtwebkit

Mar 5 2019, 7:28 AM · Windows

Mar 4 2019

vonreth committed R834:960c599c0905: Update help text (authored by vonreth).
Update help text
Mar 4 2019, 3:01 PM
vonreth committed R344:f58970389eea: Fix taglib detection on Windows (authored by vonreth).
Fix taglib detection on Windows
Mar 4 2019, 11:40 AM
vonreth closed D17913: Require CMake 3.4 and use the OpenSSL imported libs.
Mar 4 2019, 11:17 AM
vonreth committed R486:1137ed5f07d1: Require CMake 3.4 and use the OpenSSL imported libs (authored by vonreth).
Require CMake 3.4 and use the OpenSSL imported libs
Mar 4 2019, 11:17 AM
vonreth closed D16525: Fix taglib detection on Windows.

Merged
https://invent.kde.org/kde/juk/commit/f58970389eea48cca189abead796440aae127d54

Mar 4 2019, 11:15 AM
vonreth committed R834:43d658591033: Update copyright year (authored by vonreth).
Update copyright year
Mar 4 2019, 11:06 AM
vonreth committed R834:c9b324f2c61b: Add ExitCode for button pressed and text entered (authored by vonreth).
Add ExitCode for button pressed and text entered
Mar 4 2019, 11:02 AM
vonreth committed R834:f8335d31e1ba: Add comment (authored by vonreth).
Add comment
Mar 4 2019, 10:51 AM
vonreth committed R834:6cd5d1feedc9: Only print interesting stuff to stdout the rest to stderr (authored by vonreth).
Only print interesting stuff to stdout the rest to stderr
Mar 4 2019, 10:50 AM

Mar 2 2019

vonreth committed R877:f13f866663de: Qt Creator 4.8.2 (authored by vonreth).
Qt Creator 4.8.2
Mar 2 2019, 1:08 PM

Mar 1 2019

vonreth added a comment to D16869: Fixed internal includ windows.h cause min/max conflicts if NOMINMAX.

I should go to phabricator more often....

Mar 1 2019, 8:17 AM
vonreth added a comment to D18832: runtime: Add error message about env variables.

Hi I forgot about this sry.

Mar 1 2019, 8:15 AM

Feb 28 2019

vonreth committed R138:b9a7aab51dcd: Rebuild kshim (authored by vonreth).
Rebuild kshim
Feb 28 2019, 3:23 PM

Feb 27 2019

vonreth committed R877:2bd6ffbba9b7: Downgrade to 0.68.0 on msvc 2015 (authored by vonreth).
Downgrade to 0.68.0 on msvc 2015
Feb 27 2019, 8:37 AM

Feb 26 2019

vonreth committed R138:6dcd5bf818f3: Fix (authored by vonreth).
Fix
Feb 26 2019, 11:03 AM

Feb 24 2019

vonreth committed R877:9cce76d41a2e: Only set linux options on linux (authored by vonreth).
Only set linux options on linux
Feb 24 2019, 4:13 PM
vonreth committed R877:d91961204659: libspectre 0.2.8 (authored by vonreth).
libspectre 0.2.8
Feb 24 2019, 3:52 PM
vonreth committed R877:48218e28da1a: Ghost script 9.26, including linux support (authored by vonreth).
Ghost script 9.26, including linux support
Feb 24 2019, 3:52 PM
vonreth committed R867:62a5a1264d3e: The config was moved to binary-factory-tooling (authored by vonreth).
The config was moved to binary-factory-tooling
Feb 24 2019, 11:43 AM