In D8332#158392, @ngraham wrote:

@dvratil, any remaining objections? This looks great to me.

@renatoo, once this is in, can we remove the now-duplicated code from Dolphin?

In D8243#157336, @markg wrote:

We have such a nice modular design with panels yet we keep cramming everything in the places panel... Why?
It's not just here, I've seen patches like this for Dolphin as well.

Imho, the places panel should only contain the top places - favorites if you will - that you might want to access quickly. Nothing else and should stay small.
Baloo -> new panel
Devices -> new panel
Remote devices -> Either in Devices or a new panel as well
etc..

Having more panels will give a whole different issues. Scrolling. Since each panel would be relatively small if you add many you will get scrollbars within the panels. Well, lets just get rid of the per panel scrollbar and merely have one for the whole "panel container" (like in macOS finder).

Just my 5 cents...

Fixed unit test

Fixed code style

Could add "Depends on D8243" into the summary.

Update parent branch

Updated parent branch

Fixed places item size calculation

Updated parent branch

Updated parent branch

Fixed typo and code style

In D8348#156659, @ngraham wrote:

Can you put the screenshot in the Summary section above, and list the dependencies there too? Also put dependency information there, in the following form:

Depends on D8243
Depends on D8332

This special syntax marks them as dependencies.

In D8348#156653, @ngraham wrote:

Is there a bugzilla ticket tracking this? And can you include a screenshot showing what it looks like now?

Typo fixed

Fixed typos
Use QStringLiteral when possible

Fixed typos

Does not load baloo urls if file index is disabled

Removed baloo dependency

Remove baloon dependency using KConfig API to query if it is enable, and hard-code search url with a fixed string.

Updated unit test

updated comit summary
renamed m_dragModeCount to m_dragStart
refactory 'KFilePlacesItem::data' function

Use QApplication::font() to determine the section header font size

Optimize sectionsCount to not use a QSet
Use static_cast when possible

Fixed code style

All problems fixed.

Fix code syntax
Disable drag from item header
Does not show item header on floating preview during the drag

Does not use KCategorizedView