- Simplfy the layout by removing the splitter, the goal was to allow resizing the font preview text edit, which seems like an unused feature (I didn't even know that was a splitter until I read the code)
- Remove redundant tooltips and whatisthis, IMHO it's self-explanatory
- Move most code out of ctor to an init() method, less d-pointer redirection (and slightly more q pointer redirection)
- Change the maximum font size from 999 to 512, which is what QFontDialog uses, personally I think neither value is realistic, but I am keeping an open mind (8K monitors?)
Details
Details
- Reviewers
dfaure cfeck apol bport - Group Reviewers
Frameworks - Commits
- R236:11589f5e4166: [KFontChooser] More code cleanup
kfontchooerdialogtest still works
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Simplify connect() calls
- Move the connect() calls of the various checkboxes, in ShowDifferences mode, after the widgets they enable/disable have been created
Comment Actions
- Move family checkbox and listview code next to each other
- Move connect calls of each checkbox next to the relevant bit of code