[KFontChooser] More code cleanup
Needs ReviewPublic

Authored by ahmadsamir on Wed, Mar 25, 8:57 AM.

Details

Reviewers
dfaure
cfeck
apol
bport
Group Reviewers
Frameworks
Summary
  • Simplfy the layout by removing the splitter, the goal was to allow resizing the font preview text edit, which seems like an unused feature (I didn't even know that was a splitter until I read the code)
  • Remove redundant tooltips and whatisthis, IMHO it's self-explanatory
  • Move most code out of ctor to an init() method, less d-pointer redirection (and slightly more q pointer redirection)
  • Change the maximum font size from 999 to 512, which is what QFontDialog uses, personally I think neither value is realistic, but I am keeping an open mind (8K monitors?)
Test Plan

kfontchooerdialogtest still works

Diff Detail

Repository
R236 KWidgetsAddons
Branch
l-kfontchooser-3 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24199
Build 24217: arc lint + arc unit