[KFontChooser] More code cleanup

Authored by ahmadsamir on Apr 11 2020, 9:29 AM.

Description

[KFontChooser] More code cleanup

Summary:

  • Simplfy the layout by removing the splitter, the goal was to allow resizing the font preview text edit, which seems like an unused feature (I didn't even know that was a splitter until I read the code)
  • Remove redundant tooltips and whatisthis, IMHO it's self-explanatory
  • Move most code out of ctor to an init() method, less d-pointer redirection (and slightly more q pointer redirection)
  • Change the maximum font size from 999 to 512, which is what QFontDialog uses, personally I think neither value is realistic, but I am keeping an open mind (8K monitors?)

Test Plan: kfontchooerdialogtest still works

Reviewers: Frameworks, dfaure, cfeck, apol, bport

Reviewed By: dfaure

Subscribers: kde-frameworks-devel

Tags: Frameworks

Differential Revision: https://phabricator.kde.org/D28271

Details

Committed
ahmadsamirApr 11 2020, 9:30 AM
Reviewer
dfaure
Differential Revision
D28271: [KFontChooser] More code cleanup
Parents
R236:6192f295fa21: GIT_SILENT Upgrade KF5 version to 5.70.0.
Branches
Unknown
Tags
Unknown