Details

Reviewers

ngraham
nicolasfella

Group Reviewers

VDG
Plasma

Maniphest Tasks

T10611: Set options for GTK apps in the respective KCMs

Commits

R99:e3274dba5fb2: Remove unneeded options in GTK KCM

Summary

Since font, icons, cursor theme, toolbar style, icons in menus and buttons settings are now in sync with corresponding plasma settings, they shouldn't be in GTK KCM anymore.

Depends on D24743

BUG: 406740

BUG: 401008

BUG: 401123

FIXED-IN: 5.18.0

Test Plan

Check if nothing breaks in GTK KCM functionality, that is left.

Diff Detail

Repository

R99 KDE Gtk Configuration Tool

Branch

gtk-kcm-remove-unneeded-options

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17891
Build 17909: arc lint + arc unit

gikari created this revision.Oct 17 2019, 6:39 PM

Restricted Application added a project: Plasma. · View Herald TranscriptOct 17 2019, 6:39 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

gikari requested review of this revision.Oct 17 2019, 6:39 PM

Harbormaster completed remote builds in B17831: Diff 68189.Oct 17 2019, 6:39 PM

gikari edited the summary of this revision. (Show Details)Oct 17 2019, 6:40 PM

gikari added a dependency: D24743: Update GTK settings according to Plasma settings.

gikari edited the test plan for this revision. (Show Details)

gikari added a reviewer: VDG.

gikari mentioned this in D23414: Remove font configuration from GTK KCM.Oct 17 2019, 6:45 PM

Wow, it's so empty now! Great job!

GB_2 added a reviewer: Plasma.Oct 17 2019, 7:52 PM

GB_2 added a project: VDG.

So much nicer, awesome work. +1 for the visuals of the rehauled kcm.

filipf awarded a token.Oct 17 2019, 8:26 PM

In D24744#549444, @filipf wrote:

So much nicer, awesome work. +1 for the visuals of the rehauled kcm.

Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

In D24744#549450, @GB_2 wrote

Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

Where would gtk theme installation buttons go?

In D24744#549486, @gikari wrote:

In D24744#549450, @GB_2 wrote

Well, it'll be gone completely soon and the GTK theme comboboxes will be in the Application Style KCM.

Where would gtk theme installation buttons go?

Could be for example a button next to the combobox or just the "Get New" button.

Ideally, we'd also sync SH_ScrollBar_LeftClickAbsolutePosition to GTK and drop the cursor to position radios

gikari mentioned this in D24743: Update GTK settings according to Plasma settings.Oct 18 2019, 12:40 PM

Rebase on top of modified D24743

Harbormaster completed remote builds in B17891: Diff 68285.Oct 19 2019, 10:32 AM

Remove unneeded find_package of deprecated library

Harbormaster completed remote builds in B17892: Diff 68286.Oct 19 2019, 10:35 AM

In D24744#549568, @broulik wrote:

Ideally, we'd also sync SH_ScrollBar_LeftClickAbsolutePosition to GTK and drop the cursor to position radios

Yeah I'm working on exposing that for QWidgets apps in the General Behavior KCM.

gikari edited the summary of this revision. (Show Details)Oct 30 2019, 8:33 AM

gikari edited the test plan for this revision. (Show Details)

In D24744#550210, @ngraham wrote:

In D24744#549568, @broulik wrote:

Ideally, we'd also sync SH_ScrollBar_LeftClickAbsolutePosition to GTK and drop the cursor to position radios

Yeah I'm working on exposing that for QWidgets apps in the General Behavior KCM.

Is that configuration even needed? Most of non-qt and non-gtk apps are using default behavior - scroll to one "page" up or down. On gnome scroll behavior is the same by default (and I haven't found any way to configure it with dconf or gnome-tweaks, may be I'm missing something). Even more, there is a bug report, that this option does not work with Chromium-based browsers: https://bugs.kde.org/show_bug.cgi?id=411762. May be we should forget about that option, remove it from the view and always set it to "one page per click"?

GB_2 added a comment.Oct 30 2019, 10:43 AM

This comment was removed by GB_2.

remove it from the view and always set it to "one page per click"?

Absolutely not.

"Absolutely not" is right. We can't remove this option entirely; that would be a big regression. If not all apps respect it, we need to fix those apps.

gikari edited the summary of this revision. (Show Details)Nov 4 2019, 8:02 PM

Ok, then we should keep it in the GTK KCM until we have the option for Qt applications in the Application Style KCM.

gikari edited the summary of this revision. (Show Details)Nov 12 2019, 10:02 PM

Can you rebase this?

In D24744#562640, @ngraham wrote:

Can you rebase this?

Sure

Rebase on new master

Harbormaster completed remote builds in B18810: Diff 69779.Nov 15 2019, 4:53 AM

@apol, are you good with this?

This revision is now accepted and ready to land.Nov 15 2019, 5:02 AM

nicolasfella accepted this revision.Dec 1 2019, 11:24 PM

Closed by commit R99:e3274dba5fb2: Remove unneeded options in GTK KCM (authored by gikari, committed by ngraham). · Explain WhyDec 2 2019, 3:07 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (5 lines)
M		src/abstractappearance.h (14 lines)
M		src/abstractappearance.cpp (14 lines)
M		src/appearancegtk2.cpp (23 lines)
M		src/appearancegtk3.cpp (33 lines)
M		src/appearencegtk.cpp (7 lines)
D	M	src/cursorthemesmodel.h (41 lines)
D	M	src/cursorthemesmodel.cpp (87 lines)
M		src/dialog_installer.h (14 lines)
M		src/dialog_installer.cpp (79 lines)
M		src/dialog_uninstaller.h (2 lines)
M		src/dialog_uninstaller.cpp (40 lines)
D	M	src/fontshelpers.h (30 lines)
D	M	src/fontshelpers.cpp (60 lines)
M		src/gtkconfigkcmodule.h (8 lines)
M		src/gtkconfigkcmodule.cpp (154 lines)
D	M	src/iconthemesmodel.h (45 lines)
D	M	src/iconthemesmodel.cpp (131 lines)
M		src/installer.h (7 lines)
M		src/installer.cpp (12 lines)
M		src/thread.cpp (3 lines)
M		src/ui/dialog_installer.ui (374 lines)
M		src/ui/dialog_uninstaller.ui (53 lines)
M		src/ui/gui.ui (540 lines)
M		tests/configsavetest.cpp (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68189	55dca45		Oct 17 2019, 6:39 PM	★	★
Diff 2	68285	500987c	Rebase on top of modified D24743	Oct 19 2019, 10:32 AM	★	★
Diff 3	68286	500987c	- Remove unneeded find_package of deprecated library	Oct 19 2019, 10:35 AM	★	★
Diff 4	69779	94732eb	Rebase on new master	Nov 15 2019, 4:53 AM	★	★
Diff 5	70714	8808df3	R99:e3274dba5fb2739b226d753df532b78ab123cf81	Dec 2 2019, 3:07 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
617a1a573d39	364950c7ad85	430993f46111	Mikhail Zolotukhin	Remove unneeded options in GTK KCM (Show More…)	Oct 17 2019, 5:56 PM
430993f46111	52690842c3d0	500987c34438	Mikhail Zolotukhin	Update GTK settings according to Plasma settings	Oct 17 2019, 3:01 PM

Remove unneeded options in GTK KCM
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 68285

CMakeLists.txt

src/abstractappearance.h

src/abstractappearance.cpp

src/appearancegtk2.cpp

src/appearancegtk3.cpp

src/appearencegtk.cpp

src/cursorthemesmodel.h

src/cursorthemesmodel.cpp

src/dialog_installer.h

src/dialog_installer.cpp

src/dialog_uninstaller.h

src/dialog_uninstaller.cpp

src/fontshelpers.h

src/fontshelpers.cpp

src/gtkconfigkcmodule.h

src/gtkconfigkcmodule.cpp

src/iconthemesmodel.h

src/iconthemesmodel.cpp

src/installer.h

src/installer.cpp

src/thread.cpp

src/ui/dialog_installer.ui

src/ui/dialog_uninstaller.ui

src/ui/gui.ui

tests/configsavetest.cpp

Remove unneeded options in GTK KCMClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 68285

CMakeLists.txt

src/abstractappearance.h

src/abstractappearance.cpp

src/appearancegtk2.cpp

src/appearancegtk3.cpp

src/appearencegtk.cpp

src/cursorthemesmodel.h

src/cursorthemesmodel.cpp

src/dialog_installer.h

src/dialog_installer.cpp

src/dialog_uninstaller.h

src/dialog_uninstaller.cpp

src/fontshelpers.h

src/fontshelpers.cpp

src/gtkconfigkcmodule.h

src/gtkconfigkcmodule.cpp

src/iconthemesmodel.h

src/iconthemesmodel.cpp

src/installer.h

src/installer.cpp

src/thread.cpp

src/ui/dialog_installer.ui

src/ui/dialog_uninstaller.ui

src/ui/gui.ui

tests/configsavetest.cpp

Remove unneeded options in GTK KCM
ClosedPublic
Actions

Revision Contents
Changeset List