Details

Reviewers

astippich
januz
ngraham

Maniphest Tasks

T9896: Add support for music indexing on Android

Commits

R255:f98a5f3137f7: initial support for android music indexer and a very small kirigami2 UI

Summary

initial support for android music indexer and a very small kirigami2 UI

still very much a work in progress

I need something like 20 seconds to import all the music in the database.
This is not good from a performance point of view.

Test Plan

builds fine and display the list of my albums

Diff Detail

Repository

R255 Elisa

Branch

androidSupport

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4032
Build 4050: arc lint + arc unit

mgallien requested review of this revision.Aug 23 2018, 6:17 AM

mgallien created this revision.

Harbormaster completed remote builds in B2143: Diff 40275.Aug 23 2018, 6:17 AM

mgallien added a dependency: D14873: makes KIO and KFileMetaData be optional dependencies.Aug 23 2018, 3:38 PM

rebase on top of master

Harbormaster completed remote builds in B2159: Diff 40309.Aug 23 2018, 3:44 PM

rebase on top of master

Harbormaster completed remote builds in B2320: Diff 40617.Aug 29 2018, 6:14 AM

I can't test on Android right now, so I'm just looking if it breaks on linux...
Do you plan to add an entirely new interface for android?

src/CMakeLists.txt
430	This causes cmake to fail on linux

In D15015#318672, @astippich wrote:

I can't test on Android right now, so I'm just looking if it breaks on linux...
Do you plan to add an entirely new interface for android?

I do not know. I plan to add components from Kirigami2 as time permits. I also plan to fix the current interface to be usable on tablet form factor.

It all depends on available time to work on it.

src/CMakeLists.txt
430	Are you sure that it fails ? I fail to understand how this could fail.

rebase

Harbormaster completed remote builds in B3919: Diff 43689.Oct 15 2018, 8:28 PM

hmm, maybe it was a cmake configuration issue, since I didn't have the kirigami libraries installed before. Anyways, this is working now.
But are the kirigami libraries actually required for desktop targets right now? I think they should be optional

mgallien added a task: T9896: Add support for music indexing on Android.Oct 18 2018, 4:40 PM

mgallien added a project: Elisa.

let kirigami be required only on Android

Harbormaster completed remote builds in B4032: Diff 43882.Oct 18 2018, 4:50 PM

Thanks. I have two more comments inline.

data/AndroidManifest.xml
2	Is android:versionName the version of Elisa? If so, this should be adjusted.
src/android/ElisaMainWindow.qml
19	qqc 2.4 is Qt 5.11 only. so either a Qt version bump is required or this must be lowered to 2.3.

astippich mentioned this in D16961: Move persistent setting of repeat and shuffle to media playlist.Nov 17 2018, 5:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 20 2018, 8:40 PM

Closed by commit R255:f98a5f3137f7: initial support for android music indexer and a very small kirigami2 UI (authored by mgallien). · Explain Why

This revision was automatically updated to reflect the committed changes.

		Path
M		CMakeLists.txt (15 lines)
M		data/AndroidManifest.xml (8 lines)
A	M	data/src/org/kde/elisa/ElisaAndroidMusicScanner.java (87 lines)
M		data/src/org/kde/elisa/ElisaService.java (9 lines)
M		src/CMakeLists.txt (138 lines)
M		src/android/ElisaMainWindow.qml (563 lines)
A	M	src/android/androidmusiclistener.h (113 lines)
A	M	src/android/androidmusiclistener.cpp (222 lines)
M		src/databaseinterface.cpp (6 lines)
M		src/main.cpp (35 lines)
M		src/musiclistenersmanager.cpp (28 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	40275	f1aa933		Aug 23 2018, 6:17 AM	★	★
Diff 2	40309	2000e6d	rebase on top of master	Aug 23 2018, 3:44 PM	★	★
Diff 3	40617	b521c8f	rebase on top of master	Aug 29 2018, 6:14 AM	★	★
Diff 4	43689	5293fb5	rebase	Oct 15 2018, 8:28 PM	★	★
Diff 5	43882	2d812af	- let kirigami be required only on Android	Oct 18 2018, 4:49 PM	★	★
Diff 6	47911	93cee90	R255:f98a5f3137f713f5c0ed1a13b2645e0ccbf82349	Dec 20 2018, 8:23 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b5c246e4fe27	9376fde8a102	e0c2b266784c	Matthieu Gallien	let kirigami be required only on Android	Oct 18 2018, 4:46 PM
e0c2b266784c	f59373b75de6	2d812af35e77	Matthieu Gallien	initial support for android music indexer and a very small kirigami2 UI (Show More…)	Aug 21 2018, 8:41 PM

initial support for android music indexer and a very small kirigami2 UI
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 43882

CMakeLists.txt

data/AndroidManifest.xml

data/src/org/kde/elisa/ElisaAndroidMusicScanner.java

data/src/org/kde/elisa/ElisaService.java

src/CMakeLists.txt

src/android/ElisaMainWindow.qml

src/android/androidmusiclistener.h

src/android/androidmusiclistener.cpp

src/databaseinterface.cpp

src/main.cpp

src/musiclistenersmanager.cpp

initial support for android music indexer and a very small kirigami2 UIClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 43882

CMakeLists.txt

data/AndroidManifest.xml

data/src/org/kde/elisa/ElisaAndroidMusicScanner.java

data/src/org/kde/elisa/ElisaService.java

src/CMakeLists.txt

src/android/ElisaMainWindow.qml

src/android/androidmusiclistener.h

src/android/androidmusiclistener.cpp

src/databaseinterface.cpp

src/main.cpp

src/musiclistenersmanager.cpp

initial support for android music indexer and a very small kirigami2 UI
ClosedPublic
Actions

Revision Contents
Changeset List