Move persistent setting of repeat and shuffle to media playlist
AbandonedPublic
Actions

Authored by astippich on Nov 17 2018, 5:06 PM.

Details

Reviewers

Summary

Use the variant map already present for the mediaplaylist to
store and restore the shuffle and repeat settings. This will
reduce code duplication in case different main qml files are
added for different platforms, e.g. as in D15015

Test Plan

shuffle and repeat are working as before

Diff Detail

Repository

R255 Elisa

Branch

settings_repeat_shuffle

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5045
Build 5063: arc lint + arc unit

astippich requested review of this revision.Nov 17 2018, 5:06 PM

astippich created this revision.

Harbormaster completed remote builds in B5045: Diff 45681.Nov 17 2018, 5:06 PM

astippich abandoned this revision.Jan 5 2019, 9:40 PM

Revision Contents
Changeset List

			Path	Packages
M			src/mediaplaylist.cpp (14 lines)
M			src/qml/ElisaMainWindow.qml (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	45681	a213020		Nov 17 2018, 5:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
aa0acb7f0688	970f51cd96b2	0e56cd905fcc	Alexander Stippich	cleanup	Nov 1 2018, 5:40 PM
0e56cd905fcc	fb1ade373618	1b1f380b7dfb	Alexander Stippich	only change when required	Nov 1 2018, 4:59 PM
1b1f380b7dfb	8038f6ca5c04	a213020030f3	Alexander Stippich	move persistent setting of repeat and shuffle	Oct 24 2018, 7:25 PM

Move persistent setting of repeat and shuffle to media playlistAbandonedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 45681

src/mediaplaylist.cpp

src/qml/ElisaMainWindow.qml

Move persistent setting of repeat and shuffle to media playlist
AbandonedPublic
Actions

Revision Contents
Changeset List