[dolphin] Let users search everywhere
Changes PlannedPublic

Authored by michaelh on Jan 11 2018, 5:13 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Summary

Removed silent restriction to home path when 'Everywhere'-button is checked.

Alternative:
Disable 'Everywhere'-button when in filenamesearch mode.

Test Plan

None

Diff Detail

Repository
R318 Dolphin
Branch
searchEverywhere (branched from Applications/17.12)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh requested review of this revision.Jan 11 2018, 5:13 PM
michaelh created this revision.

I think wanting to use a GUI search tool to look through all of / actually is fairly rare--though I think we should expose the capability anyway for those who want it. The issue is that for users who dowant to only search their home folders, this patch makes it more difficult, because they no longer have an option to search ~ from a folder that's not ~ without searching through all of /, which will make the search take much longer.

How about also adding a third option to limit it to the home directory? That way you would have three options for where the search takes place:

  • The current directory
  • The user's home directory
  • All of /

What do you think?

anthonyfieroni added a subscriber: anthonyfieroni.

This is not good idea at all. In Linux we have many virtual FS that is not good to look in (or you can wait forever). Furthermore Dolphin does not search in hidden folders, so *everywhere* is quite relative.

michaelh added a comment.EditedJan 11 2018, 6:19 PM

The current behaviour is one of the reasons why I preferred find or baloosearch on the command line.
We don't need an extra button to search home. If you want to search home. Go to home and search from there.

  • Consider the following scenario:
$ time find ~/devel -type f | wc -l 
449272

real    1m28,786s
user    0m1,174s
sys     0m5,122s

searching w/ dolphin is approximately 10x slower.

User checks 'everywhere' and expects to wait a long time for the result.
During search there is no indication which folder is just hit.
So only when the search is finished she realizes something went wrong.
Maybe adjusts the search term and goes through the procedure again. For nothing.

  • Worse is, during search symbolic links are followed

Install wine and you get by default

~/.wine/dosdevices/z: => /

So currently without knowing the user is in fact searching the whole harddisk
Who is fully aware of all symbolic links inside the home folder?

  • The 'everywhere' button *does* make sense, when searching with baloo. (Very fast, BTW)

I'm not at all against restricting search to home, but the GUI has to make that clear.
IMHO its best to disable 'everywhere' when searching with filenamesearch.
You still go to / and start your search.

@ngraham/VDG: I think the filesearch box needs to be changed. Please tell me a place where we can discuss my observations.

@anthonyfieroni: I'm aware of that. My point is: I we give the option to the user to search everywhere we should do so.

I think wanting to use a GUI search tool to look through all of / actually is fairly rare

For experienced users. But newbies who don't know where to look for logs or config files and don't know what to expect...?
I, at least was hit by this and it confused me.

We don't need an extra button to search home. If you want to search home. Go to home and search from there.

I have to disagree. Providing a facility to search all of ~ without having to first navigate there is useful. If we remove this functionality and require that users first navigate to ~ before initiating their search, I guarantee that it will confuse people and we will get bug reports about it.

I think wanting to use a GUI search tool to look through all of / actually is fairly rare

For experienced users. But newbies who don't know where to look for logs or config files and don't know what to expect...?
I, at least was hit by this and it confused me.

Newbies don't go looking for log files or config files. :-) People who are technically proficient but new to KDE (like you?) know how to use find and can easily pick up baloosearch. If we do add a way to search /, we have to make sure it doesn't remove existing functionality, and also that it works properly, per what @elvisangelaccio mentioned.

@ngraham/VDG: I think the filesearch box needs to be changed. Please tell me a place where we can discuss my observations.

https://t.me/vdgmainroom

michaelh added a comment.EditedJan 11 2018, 9:17 PM

Telegram is running.

You can use telegram or access the room through the IRC channel #kde-vdg (which can be reached also through matrix.org).

Do I need a smartphone for that? Believe or not, I don't own one.

No. IRC is IRC, with all its clients. Matrix.org has various clients, including a web frontend (through riot.im). Telegram has a web client.

nicolasfella added a subscriber: nicolasfella.EditedJan 11 2018, 9:28 PM

Do I need a smartphone for that? Believe or not, I don't own one.

For Telegram you just need any way to receive a confirmation SMS, then you can use the PC client

Thanks, I'm in already in (konversation worked).

michaelh planned changes to this revision.Feb 3 2018, 8:04 PM

See D10205