Show Date Modified information by default in Dolphin's Information Panel and Tooltips
ClosedPublic

Authored by ngraham on Oct 15 2017, 3:14 AM.

Details

Summary

BUG: 381470

Show Date Modified information by default in Dolphin's Information Panel and Tooltips.

Test Plan

Tested in KDE Neon. Works; a fresh install using a clean baloofileinformationrc file results in Date Modified appearing in the Information Panel and Tooltips by default:

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 15 2017, 3:14 AM
ngraham edited the test plan for this revision. (Show Details)Oct 15 2017, 3:15 AM
ngraham added a project: Dolphin.

Baloo doesn't have active developers so you can add Aacid to accept it.

src/metadatafilter.cpp
44

Increase it like commet advice.

ngraham updated this revision to Diff 20768.Oct 15 2017, 4:58 AM

Update current version

I guess +1 from me. Infopanel and tooltips are disabled by default anyway, so it's not a big deal if we also show the mtime there.

markg requested changes to this revision.Oct 15 2017, 1:11 PM
markg added a subscriber: markg.

+1 for having this property
-1 for the current rather verbose date format. Look at the "Modified" column in the any dolphin details view. It (on my setup) just shows a date and a HH:MM timestamp. That would be enough information, right?

This revision now requires changes to proceed.Oct 15 2017, 1:11 PM
ngraham marked an inline comment as done.Oct 15 2017, 7:15 PM

@markg I actually like the current verbose format. That's somewhat unrelated to this; can we track that change, if any, with a new patch?

markg added a comment.Oct 15 2017, 7:23 PM

@markg I actually like the current verbose format. That's somewhat unrelated to this; can we track that change, if any, with a new patch?

That depends on how you want to do that ;)

What i'm thinking about, but that might be way too specific, is providing a settings field somewhere where you fill in the date time format you want to see. And then use that format everywhere in Dolphin. But that would be a micro setting that probably not everyone would agree to.

Another option is getting it from the settings as both your and my preference is there. Just go to System Settings -> Formats and there you see "Time". There are two lines there, long format and short format. I think it would be acceptable if dolphin is a "Time format" dropdown in it's settings that picks either the long format or the short format. Would that work for you? The default probably has to stay the short format though, as the long one will explode the detail view width.

Honestly I think it's fine the way it is: in the details view, we have a nice compact string that doesn't make the column too wide, and in the Information Panel, we have a longer string that provides more information and isn't too big since text can wrap there.

I do see your point though, and I agree that the long string should be customizable in some way for people who prefer a shorter string. But that seems out of scope for this change; can we stick to this change here, and discuss that other change (which I do approve of:) ) in another patch or bug report?

markg accepted this revision.EditedOct 15 2017, 7:51 PM

Honestly I think it's fine the way it is: in the details view, we have a nice compact string that doesn't make the column too wide, and in the Information Panel, we have a longer string that provides more information and isn't too big since text can wrap there.

I do see your point though, and I agree that the long string should be customizable in some way for people who prefer a shorter string. But that seems out of scope for this change; can we stick to this change here, and discuss that other change (which I do approve of:) ) in another patch or bug report?

Oke, then it's a +1 :)
Hold of a day or 3 before considering this a ship-it though. Unless someone else comes by and approves it as well.

This revision is now accepted and ready to land.Oct 15 2017, 7:51 PM

Great, thank you!

This revision was automatically updated to reflect the committed changes.