remove the public dependency to KConfigWidgets as
this is breaking existing apps, but instead let
applications set their own QPalette, so doesn't add
dependencies and is slightly more flexible
Details
Details
- Reviewers
dfaure rikmills davidedmundson - Group Reviewers
Frameworks - Commits
- R302:0fd3ee28cedd: allow to set a custom palette instead of colorSets
old clients work, no new dependencies,
the kirigami custom palette icons is adaped and works
Diff Detail
Diff Detail
- Repository
- R302 KIconThemes
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
remove the public dependency to KConfigWidgets as this is breaking existing apps
Does it work if you use a forward declaration instead of an include? As far as I know, both "Type f()" and "void f(Type *p)" do not need the actual class/structure declaration, because both are passed as pointers.
Comment Actions
Uh, forget what I wrote. You wanted to pass only the colorSet enum, not the complete color scheme.
+1 to this.
| src/kiconloader.cpp | ||
|---|---|---|
| 870 | You don't seem to be following qApp->palette() anymore if no custom one is set? | |
| src/kiconloader.cpp | ||
|---|---|---|
| 870 | it uses an empty QPalette(), which accordning to the docs, it should fall back to the application's palette | |
Comment Actions
Just to let you know, these last 2 commits to KIconThemes break the icon coloring in existing apps like Kdenlive and KDevelop.
Previously, in a KXmlGuiWindow, doing:
QPalette plt = KColorScheme::createApplicationPalette(config);
setPalette(plt);
qApp->setPalette(palette());
Made the icon theme adapt to the palette. The recent commits break this and it is now required to add :
KIconLoader::global()->setCustomPalette(plt);
To make icon color theming work in existing apps that allow color theme switch.
Regression can be easily tested with KDevelop or Kdenlive using the "Color theme" menu from Settings
Comment Actions
please test with kiconthemes after https://commits.kde.org/kiconthemes/d15a221128bc0727f8dac96a28472f8f3a455160
it should sove the issue