this makes possible having icons loaded with different
colors in different parts of the application, will be needed
by kirigami (which will use this with a plasma-integration extension)
Details
Details
- Reviewers
hein dfaure - Group Reviewers
Frameworks Plasma - Commits
- R302:b06e2ecb32a1: expose the colorset for the stylesheet
i can have icons colored in different ways across a single app
Diff Detail
Diff Detail
- Repository
- R302 KIconThemes
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/kiconloader.h | ||
|---|---|---|
| 465 | I guess this is OK as is, so remove the comment (it's not we can change this later) | |
| src/kiconloader.h | ||
|---|---|---|
| 465 | apparently this is giving problems indeed, polkit is now failing to build since it wasn't explicitly linking to KConfigWidgets, so may be necessary to duplicate the enum | |
Comment Actions
Since this change, polkit-kde-agent-1 fails to build from source with the error:
In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0, from /<<BUILDDIR>>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37: /usr/include/KF5/KIconThemes/kiconloader.h:31:10: fatal error: kcolorscheme.h: No such file or directory #include <kcolorscheme.h> ^~~~~~~~~~~~~~~~ compilation terminated.