Looks working, strangely formatted with a comma in information panel though (2,011) - http://i.imgur.com/CVJSxNO.png

Probably good, maybe fix spaces in code and columns alignment..? @elvisangelaccio ..?

A question: D7215 (a fix like this) was not pushed to Applications/17.08 branch, is this considered a new feature or bug fix?

Also we need a full author name for commit, instead of mzsgmailcom (and email) @mzsgmailcom

In D7755#144703, @alexeymin wrote:

A question: D7215 (a fix like this) was not pushed to Applications/17.08 branch, is this considered a new feature or bug fix?

If it has new strings it's with 94.35% probability a new feature, so master only please

Also we need a full author name for commit, instead of mzsgmailcom (and email) @mzsgmailcom

Yes, you thought you were smart when registering into identity? Thanks for giving us fake data so we can't commit your patches!

In D7755#144746, @aacid wrote:

In D7755#144703, @alexeymin wrote:

A question: D7215 (a fix like this) was not pushed to Applications/17.08 branch, is this considered a new feature or bug fix?

If it has new strings it's with 94.35% probability a new feature, so master only please

Also we need a full author name for commit, instead of mzsgmailcom (and email) @mzsgmailcom

Yes, you thought you were smart when registering into identity? Thanks for giving us fake data so we can't commit your patches!

I registered for KDE Identity a long time ago so I could post on the forums. I did not use my real name then because I do not put my real name out on public forums. Seeing as you cannot commit the patch without it I just added it to my KDE Identity profile.

*EDIT: That's weird, I added my real name in Identity(what I used to log into phabricator), but the change does not show up here, also the "Real Name" input field is greyed out so I cannot update it here, any idea how to fix?

Is your surname really Z* ?

I guess you'll need to contact sysadmin@kde.org for the help you need?

In D7755#144887, @aacid wrote:

Is your surname really Z* ?

I guess you'll need to contact sysadmin@kde.org for the help you need?

No, but I will not be giving that out in public, unless it is an official government site(which this is not).
And the Identity system requires at least 2 characters in the last name field.

So I will contact the sysadmin to see about getting the change made here.
Sorry for wasting time by adding a patch that cannot be commited.

If you do not want to contribute this, can I close this so it doesn't show up on the "approved but not commmited" list?

As I understand he wants to contribute without showing his full name. Is there a way to do so? Maybe somebody else can commit it under his/her name?

He has the copyright to his code, to be able to defend the copyright correctly we need the person name, as far as i can see there's no other way around.

Isn't there a way to transfer his copyright to KDE e.V.?

I'm willing to take over ownership of the patch. I already had literally this exact diff waiting in the wings anyway in case nobody responded to https://www.reddit.com/r/kde/comments/6y3k45/ever_wanted_to_contribute_to_kde_heres_an_easy/

In D7755#144926, @aacid wrote:

He has the copyright to his code, to be able to defend the copyright correctly we need the person name, as far as i can see there's no other way around.

I could just give it to someone else?

In D7755#144927, @nicolasfella wrote:

Isn't there a way to transfer his copyright to KDE e.V.?

I could probably just declare it as copyright to KDE e.V.
AFAIK US copyright law says that it has to be in writing(email, text message, probably this too, counts as writing), that I officially hand-over the copyright to the other party.

In D7755#144947, @ngraham wrote:

I'm willing to take over ownership of the patch. I already had literally this exact diff waiting in the wings anyway in case nobody responded to https://www.reddit.com/r/kde/comments/6y3k45/ever_wanted_to_contribute_to_kde_heres_an_easy/

Okay then, you can take over this patch if you like.
Incidently that, is also why I decided to submit this patch, I read that post on Kreddit.