Differential D7215

Add Genre to additional information for audio files. Fixes T5599
ClosedPublic
Actions

Authored by navarromorales on Aug 9 2017, 11:02 AM.

Details

Reviewers
emmanuelp
Group Reviewers
Dolphin
Commits
R318:8be1e2aa0733: Add Genre to additional information for audio files. Fixes T5599
Summary

I have just imitated the code that made this funcionaliti for artist and album additional information for audio files.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
navarromorales created this revision.Aug 9 2017, 11:02 AM
Restricted Application added subscribers: Dolphin, Konqueror. · View Herald TranscriptAug 9 2017, 11:02 AM
broulik added a reviewer: Dolphin.Aug 9 2017, 11:37 AM
broulik added a subscriber: broulik.
broulik added inline comments.
src/panels/places/placesitemmodel.cpp
869 ↗(On Diff #17923)

I don't think Genre should be shown by default.

navarromorales updated this revision to Diff 17961.Aug 10 2017, 11:57 AM
  • remove Genre from default views
navarromorales added a comment.Aug 23 2017, 9:21 PM

Should I change something else?

emmanuelp accepted this revision.Aug 25 2017, 6:13 PM
emmanuelp added a subscriber: emmanuelp.

LGTM!

This revision is now accepted and ready to land.Aug 25 2017, 6:13 PM
elvisangelaccio added a subscriber: elvisangelaccio.Aug 27 2017, 5:32 PM

@navarromorales What's the email you would like to use for the commit?

navarromorales added a comment.EditedAug 27 2017, 7:11 PM
In D7215#140661, @elvisangelaccio wrote:

@navarromorales What's the email you would like to use for the commit?

Ey! sorry, shoul I have said it anywhere?

I would like to use: navarromoralesdev@gmail.com

Thanks!

Closed by commit R318:8be1e2aa0733: Add Genre to additional information for audio files. Fixes T5599 (authored by navarromorales, committed by elvisangelaccio). · Explain WhyAug 27 2017, 9:17 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Aug 27 2017, 9:19 PM
In D7215#140687, @navarromorales wrote:
In D7215#140661, @elvisangelaccio wrote:

@navarromorales What's the email you would like to use for the commit?

Ey! sorry, shoul I have said it anywhere?

Not really, this is currently a limitation of the phabricator UI.

Revision Contents
Changeset List

Diff 18862

View Options

src/kitemviews/kfileitemmodel.h

Loading...
View Options

src/kitemviews/kfileitemmodel.cpp

Loading...
View Options

src/kitemviews/private/kbaloorolesprovider.cpp

Loading...