This makes it possible to run the unittest without installing the
plugins first.
One thing I don't understand is the need for toString().toInt(),
or in other words, why my json file with a numeric value gets turned
into a string value when using qtplugininfo to inspect the plugin:
User Data: {
"X-KDE-InitialPreference": "5"
}
make uninstall; bin/jobtest
| No Linters Available |
| No Unit Test Coverage |
One thing I don't understand is the need for toString().toInt(),
or in other words, why my json file with a numeric value gets turned
into a string value when using qtplugininfo to inspect the plugin:
Maybe you need to add following in the src/widgets/kurifilterplugin.desktop
[PropertyDef::X-KDE-InitialPreference] Type=int
| src/widgets/kurifilter.cpp | ||
|---|---|---|
| 676–677 | This comment looks outdated now, should probably be removed? | |
Ah, indeed. That, and passing the servicetype file to kcoreaddons_add_plugin. Thanks!
Provide servicetype file to the cmake macro so that the priority is stored as an int.
Looks good to me.
(Maybe modify the commit message to remove the priority int/string bits)
Ah, phabricator is strange, I have indeed modified the commit log before doing arc diff but it didn't update it here.