Differential D4416

Send desktopfilename as part of notifyByPopup hints
ClosedPublic
Actions

Authored by davidedmundson on Feb 2 2017, 7:31 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R289:80c5aa01d207: Send desktopfilename as part of notifyByPopup hints
Summary

It's one of the new hints added in the gnome-only version of the
notification specification.

Adding it will help our interopability there and it might prove more
useful for Plasma in future than the current x-kde-appname.

Test Plan

Ran dbus-monitor
Emitted signal from konversation

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 10866.Feb 2 2017, 7:31 PM
davidedmundson retitled this revision from to Send desktopfilename as part of notifyByPopup hints.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 2 2017, 7:31 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
apol accepted this revision.Feb 2 2017, 11:36 PM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Feb 2 2017, 11:36 PM
apol added a comment.Feb 2 2017, 11:36 PM

Same was done with the transient hint, btw. Maybe it would make sense to add a comment pointing to the documentation this refers to?

hein added a subscriber: hein.Feb 4 2017, 4:02 AM

Gnome-only spec? Why aren't they contributing to fd.o?

apol added a comment.Feb 4 2017, 10:38 AM
In D4416#82951, @hein wrote:

Gnome-only spec? Why aren't they contributing to fd.o?

That's most certainly not the best forum to discuss this.

mck182 added a subscriber: mck182.Feb 4 2017, 3:32 PM
In D4416#82951, @hein wrote:

Gnome-only spec? Why aren't they contributing to fd.o?

"Galago is dead, we took over, deal with it."

https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25

graesslin added a subscriber: graesslin.Feb 4 2017, 4:27 PM
In D4416#83019, @mck182 wrote:
In D4416#82951, @hein wrote:

Gnome-only spec? Why aren't they contributing to fd.o?

"Galago is dead, we took over, deal with it."

https://bugzilla.gnome.org/show_bug.cgi?id=745634#c25

why is it always Matthias Classen?

Closed by commit R289:80c5aa01d207: Send desktopfilename as part of notifyByPopup hints (authored by davidedmundson). · Explain WhyFeb 7 2017, 9:18 AM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Feb 7 2017, 12:40 PM

QApplication::desktopFileName() was only added in Qt 5.7, while frameworks still support Qt 5.6. Please add a Qt version check around the new code.

davidedmundson added a comment.Feb 7 2017, 1:21 PM
In D4416#83780, @cfeck wrote:

QApplication::desktopFileName() was only added in Qt 5.7, while frameworks still support Qt 5.6. Please add a Qt version check around the new code.

Done, thanks

broulik added a subscriber: broulik.Feb 12 2017, 7:03 PM

QCoreApplication::desktopFileName() is the full desktop file name without the path, ie. as far as I can tell with the .desktop suffix, the Gnome spec explicitly says it should be sent without it, though.

Revision Contents
Changeset List

PathPackages
Msrc/notifybypopup.cpp (4 lines)

Diff 10992

View Options

src/notifybypopup.cpp

Loading...